Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <2b7d411b4a7913335082c858cb0d63b9e4bf7c5b.1652103920.git.geert+renesas@glider.be>
 <20fd1a74-c0f5-d8e9-4903-b74c185d5aa3@kernel.org>
In-Reply-To: <20fd1a74-c0f5-d8e9-4903-b74c185d5aa3@kernel.org>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Tue, 10 May 2022 09:30:35 +0200
Message-ID: <CAMuHMdVXHSnOOnn3jchezQc+bsPYTnSPuw_rOe+pyskAVaQGnQ@mail.gmail.com>
Subject: Re: [PATCH] memory: OMAP_GPMC should depend on ARCH_OMAP2PLUS || ARCH_K3
To:     Roger Quadros <rogerq@kernel.org>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Tony Lindgren <tony@atomide.com>,
        "open list:TI ETHERNET SWITCH DRIVER (CPSW)" 
        <linux-omap@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Roger,

On Tue, May 10, 2022 at 9:22 AM Roger Quadros <rogerq@kernel.org> wrote:
> On 09/05/2022 16:48, Geert Uytterhoeven wrote:
> > The Texas Instruments OMAP General Purpose Memory Controller (GPMC) is
> > only present on TI OMAP2/3/4/5, AM33xx, AM43x, DRA7xx, TI81xx, and K3
> > SoCs.  Hence add a dependency on ARCH_OMAP2PLUS || ARCH_K3, to prevent
> > asking the user about this driver when configuring a kernel without
> > OMAP2+ or K3 SoC family support.
> >
> > Fixes: be34f45f0d4aa91c ("memory: omap-gpmc: Make OMAP_GPMC config visible and selectable")
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

> > --- a/drivers/memory/Kconfig
> > +++ b/drivers/memory/Kconfig
> > @@ -105,6 +105,7 @@ config TI_EMIF
> >  config OMAP_GPMC
> >       tristate "Texas Instruments OMAP SoC GPMC driver"
> >       depends on OF_ADDRESS
> > +     depends on ARCH_OMAP2PLUS || ARCH_K3 || COMPILE_TEST
> >       select GPIOLIB
> >       help
> >         This driver is for the General Purpose Memory Controller (GPMC)
>
> Is there any possibility that CONFIG_IRQ_DOMAIN is not set while both
> OF_ADDRESS and COMPILE_TEST are set?
>
> That particular case will lead to build failures.
>
> e.g.
> https://krzk.eu/#/builders/63/builds/162

So it needs an additional dependency on IRQ_DOMAIN.
That is a pre-existing problem, not caused by my patch (which adds
more dependencies, and doesn't remove any).

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds