Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.80.82.1.1\))
Subject: Re: [PATCH v6 18/23] docs: add Rust documentation
From:   Gaelan Steele <gbs@canishe.com>
In-Reply-To: <875ymecp6f.fsf@meer.lwn.net>
Date:   Mon, 9 May 2022 20:14:54 -0700
Cc:     Miguel Ojeda <ojeda@kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
        Jarkko Sakkinen <jarkko@kernel.org>,
        Alex Gaynor <alex.gaynor@gmail.com>,
        Finn Behrens <me@kloenk.de>,
        Adam Bratschi-Kaye <ark.email@gmail.com>,
        Wedson Almeida Filho <wedsonaf@google.com>,
        Michael Ellerman <mpe@ellerman.id.au>,
        Sven Van Asbroeck <thesven73@gmail.com>,
        Wu XiangCheng <bobwxc@email.cn>, Gary Guo <gary@garyguo.net>,
        Boris-Chengbiao Zhou <bobo1239@web.de>,
        Yuki Okushi <jtitor@2k36.org>, Wei Liu <wei.liu@kernel.org>,
        Daniel Xu <dxu@dxuuu.xyz>, Julian Merkle <me@jvmerkle.de>,
        Masahiro Yamada <masahiroy@kernel.org>,
        Michal Marek <michal.lkml@markovi.net>,
        Nick Desaulniers <ndesaulniers@google.com>,
        linux-doc@vger.kernel.org, linux-kbuild@vger.kernel.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <0716311E-FD5A-489A-A17D-C427C1A0EE4E@canishe.com>
References: <20220507052451.12890-1-ojeda@kernel.org>
 <20220507052451.12890-19-ojeda@kernel.org> <875ymecp6f.fsf@meer.lwn.net>
To:     Jonathan Corbet <corbet@lwn.net>
Precedence: bulk


> On May 9, 2022, at 3:32 PM, Jonathan Corbet <corbet@lwn.net> wrote:
>=20
>> +It is convenient to instruct editors/IDEs to format while typing,
>> +when saving or at commit time. However, if for some reason =
reformatting
>> +the entire kernel Rust sources is needed at some point, the =
following can be
>> +run::
>> +
>> +	make LLVM=3D1 rustfmt
>=20
> I will ask whether we want this, though. Why would anybody want to
> mass-reformat the entire body of kernel code? This seems like =
something
> that would generate an endless stream of "helpful" patches and a lot =
of
> churn.

That would only happen if the code diverged from rustfmt=E2=80=99s =
output in the
first place. Generally, in Rust projects, the source tree is always kept
formatted with rustfmt - so running `make LLVM=3D1 rustfmt` would only
ever touch code that you=E2=80=99d just changed.=20

Gaelan=