Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220510152020.1.I6094f0a935212eabc7d9348d6cb5a2517ccc2514@changeid>
In-Reply-To: <20220510152020.1.I6094f0a935212eabc7d9348d6cb5a2517ccc2514@changeid>
From:   Chen-Yu Tsai <wenst@chromium.org>
Date:   Tue, 10 May 2022 15:36:12 +0800
Message-ID: <CAGXv+5FBJScU_-YC=vhPVM0KEO5vtP=KOH_gRnpFivQaHziU_Q@mail.gmail.com>
Subject: Re: [PATCH] arm64: dts: mt8173: add aliases for mt8173 mmc device nodes
To:     Eizan Miyamoto <eizan@chromium.org>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Rob Herring <robh+dt@kernel.org>, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org, Arnd Bergmann <arnd@arndb.de>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi,

On Tue, May 10, 2022 at 1:21 PM Eizan Miyamoto <eizan@chromium.org> wrote:
>
> Doing this makes them get enumerated in a deterministic order so that
> the assigned name in /dev that the mmc devices get assigned is
> consistent across reboots.

Arnd, one of the soc maintainers asked folks not to do this:

https://lore.kernel.org/all/CAK8P3a3_uO23Y0tyfdh26tmCVcyp6XM+ur0WUd4khGUoBb32Hw@mail.gmail.com/

and subsequently all mmc aliases for Rockchip were moved to the board level.

> See ead9f7d7ea9 ("arm64: dts: qcom: sc7180: Assign numbers to eMMC and
> SD") for similar work.

I don't know why it didn't happen for Qualcomm though.

ChenYu


> Signed-off-by: Eizan Miyamoto <eizan@chromium.org>
> ---
>
>  arch/arm64/boot/dts/mediatek/mt8173.dtsi | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> index 6b02cff605fbe..9f3cd54116de9 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> @@ -55,6 +55,10 @@ aliases {
>                 serial1 = &uart1;
>                 serial2 = &uart2;
>                 serial3 = &uart3;
> +               mmc0 = &mmc0;
> +               mmc1 = &mmc1;
> +               mmc2 = &mmc2;
> +               mmc3 = &mmc3;
>         };
>
>         cluster0_opp: opp_table0 {
> --
> 2.36.0.512.ge40c2bad7a-goog
>
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek