Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Jonathan McDowell <noodles@fb.com>
To:     Borislav Petkov <bp@alien8.de>
CC:     Thomas Gleixner <tglx@linutronix.de>,
        James Morris <jmorris@namei.org>,
        Ingo Molnar <mingo@redhat.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Dmitry Kasatkin <dmitry.kasatkin@gmail.com>,
        "x86@kernel.org" <x86@kernel.org>,
        Mimi Zohar <zohar@linux.ibm.com>,
        "Serge E. Hallyn" <serge@hallyn.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-integrity@vger.kernel.org" <linux-integrity@vger.kernel.org>,
        "linux-security-module@vger.kernel.org" 
        <linux-security-module@vger.kernel.org>
Subject: Re: [PATCH v2] Carry forward IMA measurement log on kexec on x86_64
Thread-Topic: [PATCH v2] Carry forward IMA measurement log on kexec on x86_64
Thread-Index: AQHYWY4yqojcPM99qUKBDg6v3vLzMa0WbyIAgAAMsgCAAGptgIAABpuAgAAIwgCAABCKAIAAz2mA
Date:   Tue, 10 May 2022 08:02:50 +0000
Message-ID: <YnocKdTRRHVIpf4t@noodles-fedora.dhcp.thefacebook.com>
References: <YmKyvlF3my1yWTvK@noodles-fedora-PC23Y6EG>
 <YmgjXZphkmDKgaOA@noodles-fedora-PC23Y6EG>
 <YnjvfNs5pgWiomWx@noodles-fedora.dhcp.thefacebook.com>
 <0960C132-581C-4881-8948-C566657C3998@alien8.de>
 <YnlTaawPH6T7LOUs@noodles-fedora.dhcp.thefacebook.com>
 <YnlY87wm6WmQjs7m@zn.tnic>
 <YnlgTCyB2ciaD1so@noodles-fedora.dhcp.thefacebook.com>
 <YnluLIEN9HH+QvrD@zn.tnic>
In-Reply-To: <YnluLIEN9HH+QvrD@zn.tnic>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?oD4OZuuEjNQhhOuaLKTkTmGL8zDoGgoSldcKqEImqaRFAGuPAvV34kYwceTe?=
 =?us-ascii?Q?tuVwdw94VejFv+Ci+RE+XNjMsbGz5UI8JNwpMHbe7BzLjN67LHz/0nCzQXaJ?=
 =?us-ascii?Q?OX0Ccw+uxJtniIfEqS/L7bnjZF8jklOBl3OTR2PIeVbRSxszQTfC9XHRICJv?=
 =?us-ascii?Q?/0C+gfVnYVSqxTCAUu0+Vik2KkZ5N73Cqw5qJF7WsTJMk3D29LOcz2T9/dxp?=
 =?us-ascii?Q?nV2T7MdTdDZKkTSWOKdOhVsF1RtJJByU22dvD19QPPe6Mp/BOI5ZIqWQC9aT?=
 =?us-ascii?Q?9wdmyXrC+jR1i5DvmQkGW/eAlepf6A0KFXitqbLxaGKbx3gYOKJJsvNcl9Hd?=
 =?us-ascii?Q?sJsuJkK8RFENF9RcJO+JSPVKHxD8WuIbQDz+vIhEimfHKAi8mINp+nGZkgy+?=
 =?us-ascii?Q?tymqCAiYp3Q8dcM9deT/iCvLHqy+zYbhEO5MEoAiZXvlZkN+0GCoiI4CONW1?=
 =?us-ascii?Q?LjZqwn/j+EFwQyfaMQW556xtZhUr1HSIP1mcTWU+QyOg8s/lJ3roUpKF+WxE?=
 =?us-ascii?Q?jGPSYA1kQYOlUzHAJGUQSaFZM/BTAqgWz23jwJrs8lpaP8WXfqWTrOsvOnO7?=
 =?us-ascii?Q?HU4z+dVgXnhudsgbBq3NzIhmB15c6m3REZXSi1jYgwaWd7hdxXiVNOwGBfJn?=
 =?us-ascii?Q?Zzg8Ah4unkqF856w1AQhCmL86vyBoarRpInpEfMy22fizs+uIwC5l07kTIVK?=
 =?us-ascii?Q?m782in2cflLGOM0HYsTk0LKR05DewBrgX8gTDSedgImIilHyxVSa8uhiS8xs?=
 =?us-ascii?Q?mkORjc9F4SD9XoAcg8k5BAh66HZX8Xao7q9MMm6xhnjxr4CqEpQi4ykCPgjA?=
 =?us-ascii?Q?/ppl/Qlk0z8aCfHwI/wybohOyHDwsYxC7SbTCC59OfWH0J/54gV96Xf82A8y?=
 =?us-ascii?Q?9Pgp7WgvAS0G8pGwsYC5iiVwYjD+i33xoINceiHnotc2cEiILFg5TDNqRJ7U?=
 =?us-ascii?Q?QjAcIx+KIRbVtgn9rEqDT5wHbMZYAp7YJKo2DkU2A1kYpzVtas2cHDKtKNKC?=
 =?us-ascii?Q?cIcoUL3GrFYiNjrBmPTtln4KnP8GPgVJq06wjz9/D9GYdwe3YFMLRmmtpiMO?=
 =?us-ascii?Q?SIc0Ni+7z2xb3tGLpq7PQi7SzbRkH9Fo0obErTvbzEustLkWxhAbn6GxQzLz?=
 =?us-ascii?Q?g0uYN7qh0pVXkbObjmxCCDh5hWDTKMK7jQNIyejh0LHVSTSFLvmXiuyUInnb?=
 =?us-ascii?Q?v7Av7ktyQc1hLunwaQmp5qkzKz4eHR7JgaYBjZW3jVa2renMZ+IVze6Sxs6s?=
 =?us-ascii?Q?znRv2HnxOjXl6scuSK+uyQMhcv0B8AkLWeygVnU9Li3uIgs8u82GWAc/H6KS?=
 =?us-ascii?Q?Mr3+048lNQdAYwMmOlBH99ljga/024MnVP7FC+1A0KWKR8tU0YkSru0GaAbV?=
 =?us-ascii?Q?OsNkXe06aQOxl3BaWiFT2kyxKt7qrVBDzdYtZ2lGaZizF7bceNqZAjBqrTdc?=
 =?us-ascii?Q?J0sYeSlWc8/FZHzTFkclEyJi3+XBGPf+r6eVvHzS86DimfgGtxgACjjGp4Ym?=
 =?us-ascii?Q?byCruV55yuYdQXGzms6AsCTH/SGrjaFsiAEj13Brz/1pSLQzoksh9HFG1eBF?=
 =?us-ascii?Q?YvpDH7SWaBtjmsAHCAQBvnCOhUxrw6y6sOX7KfUVicgY+JoksaajuNtT46Jr?=
 =?us-ascii?Q?Od2ZVu200jKBNjK+ybxOEQT5UeuwkG/pGO9tjebEbP3SH/I00ov9ML0DlgAC?=
 =?us-ascii?Q?K/EeT8ucmLp7AQN8ow+ejga0tqt6jqHThdAAHKQYOtsOuyvABx1gM0jhHTAu?=
 =?us-ascii?Q?uyXG5hvnAQ=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <6C580C9EE4C6CC489B0012AD1730B25C@namprd15.prod.outlook.com>
MIME-Version: 1.0
X-OriginatorOrg: fb.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR15MB4552.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b4f964b8-b118-4749-25fd-08da325b7a69
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 May 2022 08:02:50.3002
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Yjm6kzK3LXDnZkzwJA/e257jSL6HUh2ryeexL7KXqeTBuPe9Kxj1uM3gPH4Yodkb
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY3PR15MB5090
X-Proofpoint-GUID: dAoQbdLwWiIegPPOWhEVn-qWw0CCR5m1
X-Proofpoint-ORIG-GUID: dAoQbdLwWiIegPPOWhEVn-qWw0CCR5m1
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514
 definitions=2022-05-10_01,2022-05-09_02,2022-02-23_01
X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, May 09, 2022 at 09:40:28PM +0200, Borislav Petkov wrote:
> On Mon, May 09, 2022 at 06:41:17PM +0000, Jonathan McDowell wrote:
> > I'm not tied to setup_data but given the concerns I raise above with
> > device tree on x86 and the need to handle this in the kernel it seemed
> > like a reasonable first approach. You seem to be saying it's not and
> > either adding the device tree infrastructure or doing a command line
> > hack would be preferable?
> 
> All I'm doing is asking more questions to make you give more details as
> to why you wanna do it this way. I'll take a detailed look tomorrow but
> it looks ok from a quick glance.

That's reasonable, thanks for taking the time to do so. I realised
another problem with the command line approach is that this is a flow
involving attestation and potentially signing across the kexec boundary,
so if the command line changes every time due to the memory address we
pass the IMA buffer in then we have to recalculate the expected PCR etc
values for every kexec after we've done the user space buffer
allocation, rather than being able to do so once + offline in advance
for a particular kexec across multiple machines.

J.