Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp5833053iob; Tue, 10 May 2022 04:57:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwC33e0fmzrrBS2GC6RqSNQKZxl2rIzH3IR/vsC3rVvAfMlx3AO9ZC+j7ZkSjX8Qew2ksNf X-Received: by 2002:a17:90b:1c01:b0:1dc:2980:983d with SMTP id oc1-20020a17090b1c0100b001dc2980983dmr22817593pjb.0.1652183820580; Tue, 10 May 2022 04:57:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652183820; cv=none; d=google.com; s=arc-20160816; b=PSIdIKgVCJQfU0B1mI3nwHeRdJz9lck3anQcFIIC4IoNMV83I7Jp0oliAa2b2f95pD uXcde1rs8/82+nx43kqxfU3joDHG/wvCsBd8nv2/do1w3oWaEd6zzPGkhlaFArjR7Ivo 9XMvHWRF90V26rMgFWudQCSMEz1nhyVMW2Ido94tUBz1Sk9hScRNzKSn0X4ixSertHt/ hSdFWX4mqTEQBwQ9Gol4CmpTSY7T5D1rxXlTdXN4iA5/wTbSZlzCsuiiwpUerJMp753Y NOPCNWv7IBZWX4BZ5xBHYuwHeOr//EEH22dj+nZDIBSkzEOm+TnhHBzGC9kyHozyPd7p 9Diw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Z9PfWKauooNjv107xcZ68uwo/12jXdD7Y+qs9mR3gds=; b=iP8FtG6gs8z5zXLnkdbP5Sca8JNK1/cvO4z+jYY59/GNomlD52MmmMEg2yJCZm8EaA vG0Fgky1X3JKnMgHZVREFB19GNHZHHCxFUyLzK+XbcZy4M/7OE3twvOP4UHjfWIlIH0N GJbe9oQB1e/hxR/IOr/Opgo7KajbdojQovY25AEpUK+OKwHdeIEoJf6qgQLVg6pkXw9D xeCxiOBTXN7MzbkfPl6ovz+0MKJh/wxIQf1Vo6GWxlK8kR4Pj3opRKOVVQWGBnzPptZD XDi4WTIjFxcXDUXyYlCSnLcN9mBkxX/3ywD+/trjy0YYlKUBsms0CcPlR0xSimaRyzpn VmdA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=iLj6qPy4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j8-20020a17090276c800b0015eb2ef130dsi2761849plt.417.2022.05.10.04.56.45; Tue, 10 May 2022 04:57:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=iLj6qPy4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239763AbiEJKQS (ORCPT + 99 others); Tue, 10 May 2022 06:16:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43516 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239683AbiEJKQF (ORCPT ); Tue, 10 May 2022 06:16:05 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BAB7E22443A for ; Tue, 10 May 2022 03:12:08 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 7103DB81CA3 for ; Tue, 10 May 2022 10:12:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E9D4AC385C6; Tue, 10 May 2022 10:12:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652177526; bh=QmuWibf0H4i5Fp0lHfXG6BYh3c7qg5D5YVIiI8VF/j0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iLj6qPy4zvtyH2x/7kfRGQc1H4eo53tSgek0rr/aPss3/CnT5dUQwR/glYHI7EMh8 yLsMyjVz6PI7Z12r2H1yr1Cn8JSGkmZlTrnflVNMbSdhOdgpB0mdsFcXf8QdTT5tQp iEUWt2AZeKiyIC3aq2J1yGO3+0taoRYOxJDgwDwx1wchsSWPFUM7PgrDTrxvcG6tPo XzyrJpPfL6oWmGtfdzNduZJIAvbQs+z+lmc7thOfdZuA5upHNayL6XRrp76IK+4XRJ sJ5LwyhSMkQNHqrqA40li2Z8+5f49EGGNyvExttI1rEBIiuU6rlVxcN9Po5rGbnDF6 9qzSLengJGJWQ== Date: Tue, 10 May 2022 12:12:00 +0200 From: Christian Brauner To: Carlos Llamas Cc: Greg Kroah-Hartman , Arve =?utf-8?B?SGrDuG5uZXbDpWc=?= , Todd Kjos , Martijn Coenen , Joel Fernandes , Hridya Valsaraju , Suren Baghdasaryan , kernel-team@android.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] binder: fix printk format for commands Message-ID: <20220510101200.kjbe4ibvscxaquoj@wittgenstein> References: <20220509231901.3852573-1-cmllamas@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220509231901.3852573-1-cmllamas@google.com> X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 09, 2022 at 11:19:01PM +0000, Carlos Llamas wrote: > Make sure we use unsigned format specifier %u for binder commands as > most of them are encoded above INT_MAX. This prevents negative values > when logging them as in the following case: > > [ 211.895781] binder: 8668:8668 BR_REPLY 258949 0:0, cmd -2143260157 size 0-0 ptr 0000006e766a8000-0000006e766a8000 > > Signed-off-by: Carlos Llamas > --- Looks good to me, Acked-by: Christian Brauner (Microsoft)