Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp5903634iob; Tue, 10 May 2022 06:24:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwKhDRpBrVbkwALd2PGdXAMD/GzxKrgMczvm2aoP2qzBniQTQR9LkYhRWTNsltwYaPb0zQP X-Received: by 2002:a05:6402:1e94:b0:427:e496:6da1 with SMTP id f20-20020a0564021e9400b00427e4966da1mr23279739edf.136.1652189072322; Tue, 10 May 2022 06:24:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652189072; cv=none; d=google.com; s=arc-20160816; b=QKv1qTogd8oaRcvqGp5LKbpU46Bsgpvq/R9YuQrWElqP8R4hHN+UsnqxOFTRWwSm4g GN0hr4AHNAOpVbfRxaqCug448QtzVxZtPaIHmlMcUBlOXGbMsSuVadM0fbKiIAEtTnbZ Q1zhNa283XLWP9pqyNtNy+qaAYBfo4+nutbpjYLOP5bTx8BgQnVdM7PT8gF2XxgCt1WI gGliMzjaRB+Tz+79r3YG2vGyvng69phSLXirPvCEysmZpaRxVpDPxys6cRPcBucPn21W j6GVW1NtXNgPmELBwR1gbXLSiT4PWqBXgVrOCoIsLDIXjrqGfCOuHhdQsWoc4rR0O2Ue WUxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=BLV2Kejle2mncMhZ2oLLp5aes/dhC1Pap/eqk1KO9co=; b=UzFRgpsocgKaYH1+0Avmb1LoJREQhJqLPTaPk91+Shn0rPb9mcVncdvPWDe//GInMA /wsTdwP5aM3fn5sFPxDIG2HjwzZNf//uNteyy3ZahkA5E0YgjtmJbsFoawgkiyTLqCRq NnMGPKd+r6WUYHc0OSH93VciDev0Rob4QaiHwwIVE5k0uLqh73KTpcTzjxk+XbSnE9z0 8DBbHkXTXQYFr7NNFmPWm7vZy6T3ZBtOxXt3Q3LwK9hVi0c6VZX+csdEmEQPE5b65Fw4 cB01LjQ4V75PJL5XETECBuKFxx3r5LTm17OzNEAn816eNoVPGtTmdJ6Rx28zsc8+Vn7t O0/Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=kdq2FPsx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l14-20020aa7c3ce000000b00425ec219fe2si14595424edr.264.2022.05.10.06.24.07; Tue, 10 May 2022 06:24:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=kdq2FPsx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239573AbiEJKMu (ORCPT + 99 others); Tue, 10 May 2022 06:12:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33802 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229956AbiEJKMl (ORCPT ); Tue, 10 May 2022 06:12:41 -0400 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF250185C85; Tue, 10 May 2022 03:08:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652177325; x=1683713325; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=FEwpRe0W3NxiPGNEO5T4Th0jnvzANcK4YMMXxjuh76U=; b=kdq2FPsxM+RaYtG5iEDFtNXz54S01iJiIlrCh1nBn0X12zn5Um5blB/K Ic1xOCJvVhPdUNf/cPTfplnHCQaD1mQtzURC44mAO6VTt9MI8en/GIwx0 NxB/DQNMKTNvgL/ZAHy11T5AksMUI94w5hs0uDMrW/Dsb10EhVfH7LNSt TcNMuEmWtkfc7C6G3Bahh5PRVBIU5yugpJigRqbLYPO5dKi5+XTcTNjW+ lHDz2gy34PV2cejasf5fNQxr4/499MllCGtrH7WngPOO3dogbPIJzhq+A sgzQy+Pjm/FQvyHZD9JGfttZ6cZhRfPD3gx20zrNCG9AsGadJjoBNbaY3 Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10342"; a="269464879" X-IronPort-AV: E=Sophos;i="5.91,214,1647327600"; d="scan'208";a="269464879" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 May 2022 03:08:35 -0700 X-IronPort-AV: E=Sophos;i="5.91,214,1647327600"; d="scan'208";a="570605764" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 May 2022 03:08:29 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1noMn3-00EI7L-0j; Tue, 10 May 2022 13:08:25 +0300 Date: Tue, 10 May 2022 13:08:24 +0300 From: Andy Shevchenko To: Tyrone Ting Cc: avifishman70@gmail.com, tmaimon77@gmail.com, tali.perry1@gmail.com, venture@google.com, yuenn@google.com, benjaminfair@google.com, robh+dt@kernel.org, krzysztof.kozlowski@canonical.com, wsa@kernel.org, jarkko.nikula@linux.intel.com, semen.protsenko@linaro.org, sven@svenpeter.dev, jie.deng@intel.com, jsd@semihalf.com, lukas.bulwahn@gmail.com, olof@lixom.net, arnd@arndb.de, tali.perry@nuvoton.com, Avi.Fishman@nuvoton.com, tomer.maimon@nuvoton.com, KWLIU@nuvoton.com, JJLIU0@nuvoton.com, kfting@nuvoton.com, openbmc@lists.ozlabs.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 2/9] i2c: npcm: Change the way of getting GCR regmap Message-ID: References: <20220510091654.8498-1-warp5tw@gmail.com> <20220510091654.8498-3-warp5tw@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220510091654.8498-3-warp5tw@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 10, 2022 at 05:16:47PM +0800, Tyrone Ting wrote: > From: Tali Perry > > Change the way of getting NPCM system manager reigster (GCR) > and still maintain the old mechanism as a fallback if getting > nuvoton,sys-mgr fails while working with the legacy devicetree > file. ... > @@ -2236,6 +2236,7 @@ static int npcm_i2c_probe_bus(struct platform_device *pdev) > static struct regmap *clk_regmap; > int irq; > int ret; > + struct device_node *np = pdev->dev.of_node; Can we keep "longer line first" order? -- With Best Regards, Andy Shevchenko