Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220510152020.1.I6094f0a935212eabc7d9348d6cb5a2517ccc2514@changeid>
 <CAGXv+5FBJScU_-YC=vhPVM0KEO5vtP=KOH_gRnpFivQaHziU_Q@mail.gmail.com>
In-Reply-To: <CAGXv+5FBJScU_-YC=vhPVM0KEO5vtP=KOH_gRnpFivQaHziU_Q@mail.gmail.com>
From:   Arnd Bergmann <arnd@arndb.de>
Date:   Tue, 10 May 2022 09:59:29 +0200
Message-ID: <CAK8P3a06-fCBUAu3KWu75yBsdN9M4szkr+7Ngu8FcO+jW+PYhA@mail.gmail.com>
Subject: Re: [PATCH] arm64: dts: mt8173: add aliases for mt8173 mmc device nodes
To:     Chen-Yu Tsai <wenst@chromium.org>
Cc:     Eizan Miyamoto <eizan@chromium.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        DTML <devicetree@vger.kernel.org>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        "moderated list:ARM/Mediatek SoC..." 
        <linux-mediatek@lists.infradead.org>, Arnd Bergmann <arnd@arndb.de>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, May 10, 2022 at 9:36 AM Chen-Yu Tsai <wenst@chromium.org> wrote:
> On Tue, May 10, 2022 at 1:21 PM Eizan Miyamoto <eizan@chromium.org> wrote:
> >
> > Doing this makes them get enumerated in a deterministic order so that
> > the assigned name in /dev that the mmc devices get assigned is
> > consistent across reboots.
>
> Arnd, one of the soc maintainers asked folks not to do this:
>
> https://lore.kernel.org/all/CAK8P3a3_uO23Y0tyfdh26tmCVcyp6XM+ur0WUd4khGUoBb32Hw@mail.gmail.com/
>
> and subsequently all mmc aliases for Rockchip were moved to the board level.

Right, please move the aliases into the per-board dts files, and make sure
to only list the ones that are actually connected on a given machine.

> > See ead9f7d7ea9 ("arm64: dts: qcom: sc7180: Assign numbers to eMMC and
> > SD") for similar work.
>
> I don't know why it didn't happen for Qualcomm though.

It takes a while to get things consistent, need to have another look there.

      Arnd