Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Shubhrajyoti Datta <shubhraj@xilinx.com>
To:     Greg KH <gregkh@linuxfoundation.org>
CC:     "linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
        Michal Simek <michals@xilinx.com>,
        "jirislaby@kernel.org" <jirislaby@kernel.org>,
        git <git@xilinx.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 3/7] tty: xilinx_uartps: Add check for runtime_get_sync
 calls
Thread-Topic: [PATCH 3/7] tty: xilinx_uartps: Add check for runtime_get_sync
 calls
Thread-Index: AQHYW6ErQ7FqpGCLDU6R47eTuYGS760QzEKAgAdEs0A=
Date:   Tue, 10 May 2022 11:53:36 +0000
Message-ID: <DM6PR02MB6635C3E7DEBAAA146D3DF440AAC99@DM6PR02MB6635.namprd02.prod.outlook.com>
References: <20220429081422.3630070-1-shubhrajyoti.datta@xilinx.com>
 <20220429081422.3630070-4-shubhrajyoti.datta@xilinx.com>
 <YnQ4lxfJUGe4TyFi@kroah.com>
In-Reply-To: <YnQ4lxfJUGe4TyFi@kroah.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?qtdlUNjh4Oj7sHDwXeqIN68QPRFgqaDUwqG8evoZPEfI9TY18RlWrw5Ho5a1?=
 =?us-ascii?Q?SYdMv5zc7S4iQYVgATwTBc89pynnDbMey2qbGn44qUuubqLxqK1HzM5SPtnB?=
 =?us-ascii?Q?APDXA69fQfXNnoQgCsu/cyWWp+p4nWRdbhGdk5dxsYERkH+EUHNtMJ2KouA1?=
 =?us-ascii?Q?IWssJZpJRPiAWLPHA3QJPDKlrglzLr5oymebhQfzjY1RwKvambWIcek4hyoe?=
 =?us-ascii?Q?jkESAH4TOeOoPpQ8loXCfNxKs8U7k23sInu4skXaSsKlivlzBuClpBzLqLKU?=
 =?us-ascii?Q?mUuC942TG/C2zHVvustBqMApIb1lswoCkkpNO4HdTh4kcAxKxPDgOBnNVs8R?=
 =?us-ascii?Q?RRZmE6cFBcqZJKiBXufnyiFM4lxxzDwT2JpQCLZT6vFbS7T+RkMSR7jJFWNC?=
 =?us-ascii?Q?+BqB482Eivmy3SD7DvdTeiFTU3RdylwXXlWDFo6TlIF2fndE14yNhcqbdrV2?=
 =?us-ascii?Q?M7ClUe976shL4LqSJlhTYHl+XQWus1Sy0ljbQOc+8avLCRJh96tPIqg1rVDk?=
 =?us-ascii?Q?kWPA+qujCaxFPlQ+MMJXXc2R66AWdQtvJGE/p7oVHGONUeOy71V8hMM8pqzz?=
 =?us-ascii?Q?mP9INpE5oAWDDbIZXSymijHhHcpUOEC5dsJuS5rjnK+aOY2K+/t2Hwu0/zl0?=
 =?us-ascii?Q?J6Si0peG1q6AxVTsys0FgoT/kpnvLsqDjxhXtTFg0iBZHi0Of4dcJRJU9teJ?=
 =?us-ascii?Q?j7k3A82PdG/z0MOY2RR0IQWAdd31qMc3Oa8Y3JtHvQIPzO3C/AOTQAULQMkl?=
 =?us-ascii?Q?ahyWf9s8kylpCNhI4QwWJUUL1ZoHi4eyd+RVOXAJmSdi998ioglY9HpX4uMJ?=
 =?us-ascii?Q?obt+QvjLTcYP6ROAQaFJaibS3MXwqPQAwZXUKEwnOTaarJEsWW7JJ9v1uL7A?=
 =?us-ascii?Q?b7/i5BRsExdZ6CaZs8VJzqJJBV2/z2Nn/F1c3+GDharnhTd1dye+pOnK9QCJ?=
 =?us-ascii?Q?GWRLQKv5Tig2BvawoOLoSrD7ypG8lAjZdP1joEwLYGc9t9WEwQAykHnLA7nE?=
 =?us-ascii?Q?jCOVV/aBYD3e8WHDu2DxFD5gA9Wd31WdyyJ4aK686JawvOC3K6dYX9PyMAvu?=
 =?us-ascii?Q?pvCI+TIMGFgRlywCUE5LDfqxmgcAzx8VHcVWqCMJ52vEF6PwSXvI2v+0JHyf?=
 =?us-ascii?Q?ddokOis/Ib9FOW3Jzp7oPblTXZepCwhlYWDHU3TORlZ2AivvfIHlvW/Jlv1i?=
 =?us-ascii?Q?fm1sSMXOSkVp+KBtxdb+o5z22gaHUNnFUlSn4jxxJIitXnmWgL2WCB2Qpew7?=
 =?us-ascii?Q?EwT4Cw+t2nMp4/1WhO0BqoYoyWPRD6MuGBSrnikTOI2yqR20PlUigmjD/VoX?=
 =?us-ascii?Q?y0t5vcec4thNqDRXAVCiXa3WHVU4HxnvmlJTPXi8O9GVSh0Y8YAGGo9joCZX?=
 =?us-ascii?Q?ByaS7C9kGtt4KvEQ0gILMjocd/+iqV78NivWXD8K9AjbMdmATjt4ZBKKrQ77?=
 =?us-ascii?Q?oUsucFsBzR51CKyI6ouYDlOsPjheTotZuNkua0+m2fiYJ9qga2iJ2i/U0Loe?=
 =?us-ascii?Q?qC6TErEjrwzUft5rqBnGYtnLqZhLDaIoNOsgszGEBFcUq5Ot4WWr1siQOtak?=
 =?us-ascii?Q?RnO2YFcLakbbJHuTdZu7uDantUaG4l3PrtSlncNt+MgNRhgVTnkizoG4gDZy?=
 =?us-ascii?Q?TihKuhCo2o53QkUiMKV/IfWE5MLvtjN88QqarrVQwP5y2HK+NjamhpIicVfG?=
 =?us-ascii?Q?SJ4OYTPUbuJ7dij3ltBe594/77dQRy8CPAG2Pf4lhrxIvoseKNYOgviZwmZ+?=
 =?us-ascii?Q?Hvk53qfOLA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: xilinx.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR02MB6635.namprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 19fa14a6-be48-4157-a673-08da327bb7a9
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 May 2022 11:53:36.8812
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: jw3gJuaoHdD09yBrt7GupNK2dQFrWs+barVtC8J+nM54JlD5WPyjYz3r/WWbncN5OajujbIOESuoSnYfXGPfqw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR02MB4091
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Greg KH <gregkh@linuxfoundation.org>
> Sent: Friday, May 6, 2022 2:21 AM
> To: Shubhrajyoti Datta <shubhraj@xilinx.com>
> Cc: linux-serial@vger.kernel.org; Michal Simek <michals@xilinx.com>;
> jirislaby@kernel.org; git <git@xilinx.com>; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH 3/7] tty: xilinx_uartps: Add check for runtime_get_sy=
nc calls
>=20
> On Fri, Apr 29, 2022 at 01:44:18PM +0530, Shubhrajyoti Datta wrote:
> > Add a check for the return value of runtime get_sync calls.
> >
> > Addresses-Coverity: Event check_return.
> > Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
> > ---
> >  drivers/tty/serial/xilinx_uartps.c | 6 +++++-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/tty/serial/xilinx_uartps.c
> > b/drivers/tty/serial/xilinx_uartps.c
> > index 8f15fe24a0eb..868f4e587263 100644
> > --- a/drivers/tty/serial/xilinx_uartps.c
> > +++ b/drivers/tty/serial/xilinx_uartps.c
> > @@ -1100,13 +1100,17 @@ static void cdns_uart_poll_put_char(struct
> > uart_port *port, unsigned char c)  static void cdns_uart_pm(struct uart=
_port
> *port, unsigned int state,
> >  		   unsigned int oldstate)
> >  {
> > +	int ret;
> > +
> >  	switch (state) {
> >  	case UART_PM_STATE_OFF:
> >  		pm_runtime_mark_last_busy(port->dev);
> >  		pm_runtime_put_autosuspend(port->dev);
> >  		break;
> >  	default:
> > -		pm_runtime_get_sync(port->dev);
> > +		ret =3D pm_runtime_get_sync(port->dev);
> > +		if (ret < 0)
> > +			dev_err(port->dev, "Failed to enable clocks\n");
>=20
> So you just ignore the error?  SHouldn't you propagate it back upward?

The cdns_uart_pm is void so we cannot propagate it upward.

>=20
> thanks,
>=20
> greg k-h