Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 10 May 2022 15:36:34 +0200
From:   Michal Hocko <mhocko@suse.com>
To:     CGEL <cgel.zte@gmail.com>
Cc:     akpm@linux-foundation.org, hannes@cmpxchg.org, willy@infradead.org,
        shy828301@gmail.com, roman.gushchin@linux.dev, shakeelb@google.com,
        linmiaohe@huawei.com, william.kucharski@oracle.com,
        peterx@redhat.com, hughd@google.com, vbabka@suse.cz,
        songmuchun@bytedance.com, surenb@google.com,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        cgroups@vger.kernel.org, Yang Yang <yang.yang29@zte.com.cn>
Subject: Re: [PATCH] mm/memcg: support control THP behaviour in cgroup
Message-ID: <YnpqYte2jLdcBiPg@dhcp22.suse.cz>
References: <20220505033814.103256-1-xu.xin16@zte.com.cn>
 <YnUlntNFR4zeD+qa@dhcp22.suse.cz>
 <6275d3e7.1c69fb81.1d62.4504@mx.google.com>
 <YnjmPAToTR0C5o8x@dhcp22.suse.cz>
 <6278fa75.1c69fb81.9c598.f794@mx.google.com>
 <Ynj/l+pyFJxKfcbQ@dhcp22.suse.cz>
 <6279c354.1c69fb81.7f6c1.15e0@mx.google.com>
 <Yno3pNQOn1lAMPnu@dhcp22.suse.cz>
 <627a5214.1c69fb81.1b7fb.47be@mx.google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <627a5214.1c69fb81.1b7fb.47be@mx.google.com>
Precedence: bulk

On Tue 10-05-22 11:52:51, CGEL wrote:
> On Tue, May 10, 2022 at 12:00:04PM +0200, Michal Hocko wrote:
> > On Tue 10-05-22 01:43:38, CGEL wrote:
> > > On Mon, May 09, 2022 at 01:48:39PM +0200, Michal Hocko wrote:
> > > > On Mon 09-05-22 11:26:43, CGEL wrote:
> > > > > On Mon, May 09, 2022 at 12:00:28PM +0200, Michal Hocko wrote:
> > > > > > On Sat 07-05-22 02:05:25, CGEL wrote:
> > > > > > [...]
> > > > > > > If there are many containers to run on one host, and some of them have high
> > > > > > > performance requirements, administrator could turn on thp for them:
> > > > > > > # docker run -it --thp-enabled=always
> > > > > > > Then all the processes in those containers will always use thp.
> > > > > > > While other containers turn off thp by:
> > > > > > > # docker run -it --thp-enabled=never
> > > > > > 
> > > > > > I do not know. The THP config space is already too confusing and complex
> > > > > > and this just adds on top. E.g. is the behavior of the knob
> > > > > > hierarchical? What is the policy if parent memcg says madivise while
> > > > > > child says always? How does the per-application configuration aligns
> > > > > > with all that (e.g. memcg policy madivise but application says never via
> > > > > > prctl while still uses some madvised - e.g. via library).
> > > > > >
> > > > > 
> > > > > The cgroup THP behavior is align to host and totally independent just likes
> > > > > /sys/fs/cgroup/memory.swappiness. That means if one cgroup config 'always'
> > > > > for thp, it has no matter with host or other cgroup. This make it simple for
> > > > > user to understand or control.
> > > > 
> > > > All controls in cgroup v2 should be hierarchical. This is really
> > > > required for a proper delegation semantic.
> > > >
> > > 
> > > Could we align to the semantic of /sys/fs/cgroup/memory.swappiness?
> > > Some distributions like Ubuntu is still using cgroup v1.
> > 
> > cgroup v1 interface is mostly frozen. All new features are added to the
> > v2 interface.
> >
> 
> So what about we add this interface to cgroup v2?

Can you come up with a sane hierarchical behavior?

[...]
> > > For micro-service architecture, the application in one container is not a
> > > set of loosely tight processes, it's aim at provide one certain service,
> > > so different containers means different service, and different service
> > > has different QoS demand. 
> > 
> > OK, if they are tightly coupled you could apply the same THP policy by
> > an existing prctl interface. Why is that not feasible. As you are noting
> > below...
> > 
> > >     5.containers usually managed by compose software, which treats container as
> > > base management unit;
> > 
> > ..so the compose software can easily start up the workload by using prctl
> > to disable THP for whatever workloads it is not suitable for.
> 
> prctl(PR_SET_THP_DISABLE..) can not be elegance to support the semantic we
> need. If only some containers needs THP, other containers and host do not need
> THP. We must set host THP to always first, and call prctl() to close THP for
> host tasks and other containers one by one,

It might not be the most elegant solution but it should work.
Maintaining user interfaces for ever has some cost and the THP
configuration space is quite large already. So I would rather not add
more complication in unless that is absolutely necessary.

> in this process some tasks that start before we call prctl() may
> already use THP with no need.

As long as all those processes have a common ancestor I do not see how
that would be possible.

-- 
Michal Hocko
SUSE Labs