Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH v2 1/2] dt-bindings: remoteproc: qcom: Add SC7280 MSS
 bindings
To:     Matthias Kaehlcke <mka@chromium.org>, Rob Herring <robh@kernel.org>
CC:     <swboyd@chromium.org>, <linux-remoteproc@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <bjorn.andersson@linaro.org>,
        <robh+dt@kernel.org>, <mathieu.poirier@linaro.org>,
        <krzysztof.kozlowski@canonical.com>, <agross@kernel.org>,
        <dianders@chromium.org>, <ohad@wizery.com>,
        <linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <evgreen@chromium.org>
References: <1652082798-5855-1-git-send-email-quic_sibis@quicinc.com>
 <1652082798-5855-2-git-send-email-quic_sibis@quicinc.com>
 <1652098858.589911.3576234.nullmailer@robh.at.kernel.org>
 <YnlpU+sCfO86+qc2@google.com>
From:   Sibi Sankar <quic_sibis@quicinc.com>
Message-ID: <765e57e3-a780-3553-62b6-b8713a21c0d8@quicinc.com>
Date:   Tue, 10 May 2022 16:36:34 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <YnlpU+sCfO86+qc2@google.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hey Matthias,
Thanks for taking time to review the series.

I'll re-order the clock names in the bindings and fix the pdc_sync typo
in the next re-spin. The interconnects missing warnings should go away
since patch 2 adds it.

-Sibi

On 5/10/22 12:49 AM, Matthias Kaehlcke wrote:
> On Mon, May 09, 2022 at 07:20:58AM -0500, Rob Herring wrote:
>> On Mon, 09 May 2022 13:23:17 +0530, Sibi Sankar wrote:
>>> Add MSS PIL loading bindings for SC7280 SoCs.
>>>
>>> Signed-off-by: Sibi Sankar <quic_sibis@quicinc.com>
>>> ---
>>>   .../bindings/remoteproc/qcom,sc7280-mss-pil.yaml   | 261 +++++++++++++++++++++
>>>   1 file changed, 261 insertions(+)
>>>   create mode 100644 Documentation/devicetree/bindings/remoteproc/qcom,sc7280-mss-pil.yaml
>>>
>>
>> Running 'make dtbs_check' with the schema in this patch gives the
>> following warnings. Consider if they are expected or the schema is
>> incorrect. These may not be new warnings.
>>
>> Note that it is not yet a requirement to have 0 warnings for dtbs_check.
>> This will change in the future.
>>
>> Full log is available here: https://patchwork.ozlabs.org/patch/
> 
> The culprit is this snippet in arch/arm64/boot/dts/qcom/sc7280-chrome-common.dtsi:
> 
> /* Modem setup is different on Chrome setups than typical Qualcomm setup */
> &remoteproc_mpss {
> 	status = "okay";
> 	compatible = "qcom,sc7280-mss-pil";
> 	iommus = <&apps_smmu 0x124 0x0>, <&apps_smmu 0x488 0x7>;
> 	memory-region = <&mba_mem>, <&mpss_mem>;
> };
> 
> The original compatible string from sc7280.dtsi is 'qcom,sc7280-mpss-pas'.
> 
>> remoteproc@4080000: clock-names:1: 'snoc_axi' was expected
>> 	arch/arm64/boot/dts/qcom/sc7280-crd.dtb
>> 	arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r0.dtb
>> 	arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r1.dtb
>> 	arch/arm64/boot/dts/qcom/sc7280-idp2.dtb
>> 	arch/arm64/boot/dts/qcom/sc7280-idp.dtb
>>
>> remoteproc@4080000: clock-names:2: 'offline' was expected
>> 	arch/arm64/boot/dts/qcom/sc7280-crd.dtb
>> 	arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r0.dtb
>> 	arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r1.dtb
>> 	arch/arm64/boot/dts/qcom/sc7280-idp2.dtb
>> 	arch/arm64/boot/dts/qcom/sc7280-idp.dtb
> 
> The fix probably consists in adding overrides for 'clocks' and
> 'clock-names' to the extension in sc7280-chrome-common.dtsi, unless
> we add a dedicated 'qcom,sc7280-mss-pil' node to sc7280.dtsi. This
> can be done once the binding landed.
> 
>> remoteproc@4080000: 'interconnects' is a required property
>> 	arch/arm64/boot/dts/qcom/sc7280-crd.dtb
>> 	arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r0.dtb
>> 	arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r1.dtb
>> 	arch/arm64/boot/dts/qcom/sc7280-idp2.dtb
>> 	arch/arm64/boot/dts/qcom/sc7280-idp.dtb
> 
> This can be fixed by adding an 'interconnects' to either the
> extension in sc7280-chrome-common.dtsi, or the original node if
> 'qcom,sc7280-mpss-pas' uses the same interconnect.
> 
>> remoteproc@4080000: reset-names:1: 'pdc_sync' was expected
>> 	arch/arm64/boot/dts/qcom/sc7280-crd.dtb
>> 	arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r0.dtb
>> 	arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r1.dtb
>> 	arch/arm64/boot/dts/qcom/sc7280-idp2.dtb
>> 	arch/arm64/boot/dts/qcom/sc7280-idp.dtb
>>
> 
> This could be fixed by aligning the reset names of the
> 'qcom,sc7280-mpss-pas' and 'qcom,sc7280-mss-pil' bindings.
> The reset is called 'pdc_reset' for 'mpss-pas', and 'pdc_sync'
> for 'mpss-pil'.
>