Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 10 May 2022 15:27:56 +0200
From:   Maxime Ripard <maxime@cerno.tech>
To:     Stefan Wahren <stefan.wahren@i2se.com>
Cc:     Florian Fainelli <f.fainelli@gmail.com>,
        Ray Jui <rjui@broadcom.com>,
        Scott Branden <sbranden@broadcom.com>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>,
        bcm-kernel-feedback-list@broadcom.com, linux-clk@vger.kernel.org,
        linux-rpi-kernel@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: bcm2835: fix bcm2835_clock_choose_div
Message-ID: <20220510132756.qmyjca53xu44iwn7@houat>
References: <20220428183010.1635248-1-stefan.wahren@i2se.com>
 <20220503145804.b2xz4etzc6kpr3fk@houat>
 <ee39ddd1-bfce-012d-5e04-448d779ed995@i2se.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="iiuqzltjsvoixdta"
Content-Disposition: inline
In-Reply-To: <ee39ddd1-bfce-012d-5e04-448d779ed995@i2se.com>
Precedence: bulk


--iiuqzltjsvoixdta
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, May 07, 2022 at 11:26:28AM +0200, Stefan Wahren wrote:
> Am 03.05.22 um 16:58 schrieb Maxime Ripard:
> > Hi,
> >=20
> > On Thu, Apr 28, 2022 at 08:30:10PM +0200, Stefan Wahren wrote:
> > > The commit 09e3b18ca5de ("clk: bcm2835: Remove unused variable")
> > > accidentially breaks the behavior of bcm2835_clock_choose_div() and
> > > booting of Raspberry Pi. The removed do_div macro call had side effec=
ts,
> > > so we need to restore it.
> > >=20
> > > Fixes: 09e3b18ca5de ("clk: bcm2835: Remove unused variable")
> > > Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> > I only found this patch after debugging why the HDMI driver was
> > returning -EINVAL at probe on -rc5.
> >=20
> > Acked-by: Maxime Ripard <maxime@cerno.tech>
> > Tested-by: Maxime Ripard <maxime@cerno.tech>
>=20
> Thanks,
>=20
> does this go via clk-fixes?

Yep, it should.

Stephen, could we merge this?

Maxime

--iiuqzltjsvoixdta
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYnpoRgAKCRDj7w1vZxhR
xXXWAP4unHPnJJ+pfUOyHlW0LlgxC5dGW9PKPQF5+/AGot2oNAEAgBckc8lfPpYH
RQ67UzgFYAKV6AlepFjtnRlbxpQRJg8=
=yS+i
-----END PGP SIGNATURE-----

--iiuqzltjsvoixdta--