Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp6144667iob; Tue, 10 May 2022 11:18:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxvg+41uRjjNX14FPrPiDj4ciOtyVYDoVm2uRXPtVH0GVZekUwWa4gN3sp06nMzYPeFVvOm X-Received: by 2002:a05:6402:28b6:b0:425:e137:e31a with SMTP id eg54-20020a05640228b600b00425e137e31amr24683532edb.215.1652206713347; Tue, 10 May 2022 11:18:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652206713; cv=none; d=google.com; s=arc-20160816; b=EKDvWilKMHA4Hf5/hqAcHtH0Yz/vFiJtXZW5VonVZzISlE9GW2ODvgsOAeBR3pS1/B elPSo2I/U2gMfmjR+v53Q4Mo/nEsCWlTNSGInrmRbx9cKqtPDyRM7oo4PDCK4Eb7xM8p Jims5lS3JTK2lrffIC920oaeq4q0GSZ2DDSNjEkpFce24HCiWCBA7BZlBxfk49ahxUf6 dfZVF21jwaUjS2gQJC3Aa92N6Mm0ltJhLHo71z+8bA/WtO4VfXJtQOJsblj9kuG4K/gU F2vmj1IQLpIcseow9cgU5/eUhZB2mXShVH9Vk7BH5dBGKVG56GWpUSJFbdPYUhk+C+Eb 0xEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Xx+3WvvebX7SK15U9J3OV6yJYQTwYRjXD7e19Hx4wNQ=; b=0xmi/rotJdDwL7nYZ2xtWiVPQLQUy/O6qWKoO14VLV6G2rVriNq+BcmXUcRB7U0BxU SNWz98iuFoAvhnn2o4zORwppmuBbWxfHnKQW2rl4uC983rVtBi4k3TcrEDj2hP8W5J9l eLE+oc9GWnwuPKKcQXFJ9AcvXfB9XQKbHxlBQWewJhC6p1sZACxPbglLmvYe3wrWbfx4 dQlrANrsT/JtqrwWQhSEN9UHVsOB52CvtHcw68T14ZN3nKVoTETPdnRC6getvjmWyK+s 5xjWibftKFWruqcdY2eC2klDLDBGeePEWp+8OovSqQYAO9DfaXCcsFMEm8d06ORQ1P90 cOhQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=mS4WstrV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j39-20020a05640223a700b00425f5e2bd8bsi15641042eda.305.2022.05.10.11.18.07; Tue, 10 May 2022 11:18:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=mS4WstrV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344040AbiEJOUl (ORCPT + 99 others); Tue, 10 May 2022 10:20:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44428 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245041AbiEJNrN (ORCPT ); Tue, 10 May 2022 09:47:13 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 519577658; Tue, 10 May 2022 06:34:05 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id C2F3DCE1E67; Tue, 10 May 2022 13:34:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 99DBDC385A6; Tue, 10 May 2022 13:34:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1652189642; bh=IOMGjic0Y5MCySd6f210PJpYaIrCb0vu1Km2VJOHEZ4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mS4WstrVFv3qxxZHYNkcK9nbdpaH/yZyLnecDXaNB6zlsj282AmQjK+ngg9/HEhUK AEakTtIYKHSpcEs78nhS0Tl8woG+ALJvoblBzeev3tpRUA2qmX1QKniyYkc97+t5nP WnXb6A8a8KWgqBqt/W72Kdbo1Osf9AkSrWTXrz7w= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, pali@kernel.org, =?UTF-8?q?Marek=20Beh=FAn?= , Lorenzo Pieralisi Subject: [PATCH 5.15 115/135] PCI: aardvark: Disable link training when unbinding driver Date: Tue, 10 May 2022 15:08:17 +0200 Message-Id: <20220510130743.700907942@linuxfoundation.org> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220510130740.392653815@linuxfoundation.org> References: <20220510130740.392653815@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Pali Roh?r commit 759dec2e3dfdbd261c41d2279f04f2351c971a49 upstream. Disable link training circuit in driver unbind sequence. We want to leave link training in the same state as it was before the driver was probed. Link: https://lore.kernel.org/r/20211130172913.9727-11-kabel@kernel.org Signed-off-by: Pali Roh?r Signed-off-by: Marek Beh?n Signed-off-by: Lorenzo Pieralisi Signed-off-by: Marek Beh?n Signed-off-by: Greg Kroah-Hartman --- drivers/pci/controller/pci-aardvark.c | 5 +++++ 1 file changed, 5 insertions(+) --- a/drivers/pci/controller/pci-aardvark.c +++ b/drivers/pci/controller/pci-aardvark.c @@ -1725,6 +1725,11 @@ static int advk_pcie_remove(struct platf if (pcie->reset_gpio) gpiod_set_value_cansleep(pcie->reset_gpio, 1); + /* Disable link training */ + val = advk_readl(pcie, PCIE_CORE_CTRL0_REG); + val &= ~LINK_TRAINING_EN; + advk_writel(pcie, val, PCIE_CORE_CTRL0_REG); + /* Disable outbound address windows mapping */ for (i = 0; i < OB_WIN_COUNT; i++) advk_pcie_disable_ob_win(pcie, i);