Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 10 May 2022 17:30:53 +0200
From:   Henning Schild <henning.schild@siemens.com>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     Mark Gross <markgross@kernel.org>,
        Wim Van Sebroeck <wim@linux-watchdog.org>,
        Guenter Roeck <linux@roeck-us.net>,
        linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
        platform-driver-x86@vger.kernel.org,
        linux-watchdog@vger.kernel.org, Enrico Weigelt <lkml@metux.net>,
        Gerd Haeussler <gerd.haeussler.ext@siemens.com>
Subject: Re: [PATCH 0/2] simatic-ipc additions to p2sb apl lake gpio
Message-ID: <20220510173053.10a14aeb@md1za8fc.ad001.siemens.net>
In-Reply-To: <20220504171951.0d569632@md1za8fc.ad001.siemens.net>
References: <20220131151346.45792-1-andriy.shevchenko@linux.intel.com>
        <20220308193522.26696-1-henning.schild@siemens.com>
        <YnJ2tYjCpJi7yc4j@smile.fi.intel.com>
        <20220504171951.0d569632@md1za8fc.ad001.siemens.net>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?kvD55vauXx+L+SpeqlC/jHw1rvOXkYawCt3UEVlaEluNqm8TChGuTH3ir/Yq?=
 =?us-ascii?Q?zgDkgb9rXXCJT/ydzYSVPNWT8mXOZ8aQ/0HvYxXrMI+aCwieEi2RqOpXQb+L?=
 =?us-ascii?Q?mG7AoaSEUnwyc010wolBaN60hMaPXyccgygqCWMTE7vfi6P6cTdeK1ofVnT3?=
 =?us-ascii?Q?SR5FjZpVwdi++QnNwIuTi8cm3RkdLsgbaKHiLH625RZZGg+eYkg6fYt1dc63?=
 =?us-ascii?Q?BOQUdBhP4NJkGDiZX6kMe+HATN+VP+pP//DNPBX8JkVy8DzuhGMT0Araj/eX?=
 =?us-ascii?Q?nBSja2R07Mm6tMYXeqVDpAG5DkZWIGDPKjyxWqCcz3yZBrEgh6KbVymci7QQ?=
 =?us-ascii?Q?i84SLvDKx9Y70GtBsgpTW8Nk02X4gEJEL2XKZ796MDRU6JcDJw6yoyvuqJ3g?=
 =?us-ascii?Q?9JeyRiufiolFUSJX3q4NQT3iuHdr1ZrNNJ7V+yW2r15lhtourd+VlA+ZFhTi?=
 =?us-ascii?Q?8gI0aK+oEt/7ZWfLNYe6/WFdg4E5zzEoY4V+2OnK2KJRGVYQsQTNMwOUnMQb?=
 =?us-ascii?Q?/dPBbaoGnI3L7ejnG0n8jPnD6XdvhJ5mb+kT29a0UZRXZ01iQ1Tg6+MNTXcM?=
 =?us-ascii?Q?9oyi1Np2ZdSuY3ite33JyidC3lsaXmuit1pVAEAVmL0LE609WjjBp0fsLvhY?=
 =?us-ascii?Q?l59nrWvLRvRDWZr84xcSxNmVv/B+TbQpLPOuFJQhVjcJ8IG/XvjLP+sej42A?=
 =?us-ascii?Q?UsOh87Puikza8uLtBCpTabG86+RANg9Xik6hFw4c+rJ1OVCDUCKgTvSmFu6h?=
 =?us-ascii?Q?BJzShHwfD5JM2XOakpcm8NIE5wrT8xKj025NwdsOMYNNuhGxE5/1XCcUvSTl?=
 =?us-ascii?Q?T4RxUSU6Jdu9qQBeKvZIkicwjQKoBIGzle8lDhpEFL4pi9u4IQBk7xbZM5vz?=
 =?us-ascii?Q?s5Nnk4BdKrBgcGmVC86xf55/gBAcn2OM1zfspaVRLNoGzehOpqchQEHcfRvv?=
 =?us-ascii?Q?JomyRhK7EhJBYJCIO3wDZiLTyqG8Hl1yRMQjbbBPwJVmXSoVrmiHnnkxtYdp?=
 =?us-ascii?Q?3EpKHuvkvGbGcf8ch6Dx5bRu84jAdSQxLgpDplJErakfp9Ha7h9Pup+jbgKw?=
 =?us-ascii?Q?UW8InN9eH20rR+BVN0Ga0NzRihTBem15CSkNkKvqpmyBMF3N8JMw4c6QjAdP?=
 =?us-ascii?Q?R81UGGGs7j8FcXqcDyTmhBVrwBIsNC9b8nwl/UYPWVg/iHERYRyh7sSJbhS2?=
 =?us-ascii?Q?IjWIvzv2S6Psf1gO7k3omjAm0L81NpJS9Ihw7rLiAP/aXg33ixs9p8Q/T/da?=
 =?us-ascii?Q?uB8Jd3W8d327TSxFdky3hhgZ7IkVYvPYA81wT9Vzz3fFaHEDouWEjTRbDfXJ?=
 =?us-ascii?Q?v3NAFUcG5GeszuHvhutLCH1SLUhGWoNo+IoB+qTrPOUNnVZDMD9zT3htLHVt?=
 =?us-ascii?Q?sXxoMHJa8CIJj15ICFxnWkPndh1OX5wqCRkiTR1Z6StNLlRl4szqGS0/Fbuw?=
 =?us-ascii?Q?e9JZx4rzfL/CUlwsgjn5kanf8W+DmwgggQ/3VXo6Aaksjn2vacmJKxduU2Dr?=
 =?us-ascii?Q?luZidfZFbnxaaf1tX9NoVuMiC8gUuj8A1K9szPEKITSuYLhhcCYRzaiTQ0+o?=
 =?us-ascii?Q?qDiDT4fdHcERouTZhteAD4X5K7AK44lITBbKSwWJFkphVYcH80i1kAFv1WGI?=
 =?us-ascii?Q?bwGR4exgSLvXsQIzzcy0IPv0ymnbxRYE2eVWMNsOicCym958CZwpDnippRNC?=
 =?us-ascii?Q?Fdcq3FhonZj4HLEZ8xgHmsaiwrqPmgiHAVb3yLYNhswB3nCB/4aBhu09tMQm?=
 =?us-ascii?Q?w6f9C9P3voZQRbwJzy1bH2aVzKsONpY=3D?=
X-OriginatorOrg: siemens.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3b264c0f-0eda-4589-ad2d-08da329a1445
X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 May 2022 15:30:57.4059
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iFN7xRD4ZLI6a/iyTyS8R0AgOEi83liAxgSUEEYLP3Le6FZqPmpsBXsOMEcGjX2Bj6pQ+zKf/3CmyRi4niC7E8TimYJ5+fosfMc0EMDt3Mo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR10MB2339
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am Wed, 4 May 2022 17:19:51 +0200
schrieb Henning Schild <henning.schild@siemens.com>:

> Am Wed, 4 May 2022 15:51:01 +0300
> schrieb Andy Shevchenko <andriy.shevchenko@linux.intel.com>:
> 
> > On Tue, Mar 08, 2022 at 08:35:20PM +0100, Henning Schild wrote:  
> > > This switches the simatic-ipc modules to using the p2sb interface
> > > introduced by Andy with "platform/x86: introduce p2sb_bar()
> > > helper".
> > > 
> > > It also switches to one apollo lake device to using gpio leds.
> > > 
> > > I am kind of hoping Andy will take this on top and propose it in
> > > his series.    
> > 
> > First of all, they are not applicable to my current version [1] of
> > the series (it maybe something changed in the Simatic drivers
> > upstream, because I have got conflicts there. For the record, I'm
> > using Linux Next as a base.  
> 
> That is possible, some sparse findings have been fixed lately.
> 
> > Second question is could it be possible to split first patch into
> > three, or it has to be in one?  
> 
> I assume one for leds one for wdt and finally drop stuff from
> platform, and i will go with that assumption for a next round based
> on your tree directly.
> Can you explain why that will be useful? While it is kind of a
> separation of concerns and subsystems ... it also kind of all belongs
> together and needs to be merged in a rather strict order.
> 
> regards,
> Henning
> 
> > [1]: https://gitlab.com/andy-shev/next/-/tree/topic/p2sb-next
> > It would be nice if you can perform another round of testing.

Just got around to testing this with my patches on top. My stuff will
need some more work before i can send again.

Is this a rebasing branch? 
With efc7d77ea372 ("EDAC, pnd2: convert to use common P2SB accessor")
I am seeing problems while booting ... things do work but still error
messages which probably should not be there.

[    2.215715] gpio gpiochip0: (apollolake-pinctrl.0): not an immutable chip, please consider fixing it!
[    2.217506] broxton-pinctrl apollolake-pinctrl.1: Failed to attach ACPI GPIO chip
[    2.217542] gpio gpiochip1: (apollolake-pinctrl.1): not an immutable chip, please consider fixing it!
[    2.217771] i801_smbus 0000:00:1f.1: Failed to enable SMBus PCI device (-22)
[    2.217788] i801_smbus: probe of 0000:00:1f.1 failed with error -22
[    2.221460] broxton-pinctrl apollolake-pinctrl.2: Failed to attach ACPI GPIO chip
[    2.221482] gpio gpiochip2: (apollolake-pinctrl.2): not an immutable chip, please consider fixing it!
[    2.222010] broxton-pinctrl apollolake-pinctrl.3: Failed to attach ACPI GPIO chip
[    2.222023] gpio gpiochip3: (apollolake-pinctrl.3): not an immutable
chip, please consider fixing it!

regards,
Henning


> > > Henning Schild (2):
> > >   simatic-ipc: convert to use common P2SB accessor
> > >   leds: simatic-ipc-leds-gpio: add GPIO version of Siemens driver
> > > 
> > >  drivers/leds/simple/Kconfig                   |  11 ++
> > >  drivers/leds/simple/Makefile                  |   3 +-
> > >  drivers/leds/simple/simatic-ipc-leds-gpio.c   | 108
> > > ++++++++++++++++++ drivers/leds/simple/simatic-ipc-leds.c        |
> > > 77 +------------ drivers/platform/x86/simatic-ipc.c            |
> > > 43 +------ drivers/watchdog/Kconfig                      |   1 +
> > >  drivers/watchdog/simatic-ipc-wdt.c            |  15 +--
> > >  .../platform_data/x86/simatic-ipc-base.h      |   2 -
> > >  8 files changed, 139 insertions(+), 121 deletions(-)
> > >  create mode 100644 drivers/leds/simple/simatic-ipc-leds-gpio.c
> > > 
> > > -- 
> > > 2.34.1
> > >     
> >   
>