Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e5820cda-ce5c-9b15-8822-7a6b858f806e@oracle.com>
Date:   Tue, 10 May 2022 09:18:34 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.0
Subject: Re: [PATCH v5 1/3] vdpa: Fix error logic in vdpa_nl_cmd_dev_get_doit
Content-Language: en-US
To:     Eli Cohen <elic@nvidia.com>, mst@redhat.com, jasowang@redhat.com
Cc:     virtualization@lists.linux-foundation.org,
        linux-kernel@vger.kernel.org
References: <20220510112734.205669-1-elic@nvidia.com>
 <20220510112734.205669-2-elic@nvidia.com>
From:   Si-Wei Liu <si-wei.liu@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <20220510112734.205669-2-elic@nvidia.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bS91MGVCQlFqTVhBdHdlU0pDLzN0RUhYR1MvenFuR0ZFTWgzRmxNTGNSOXhI?=
 =?utf-8?B?L21kR3p1d2tUQmk3bXJlWmxnL2xMMnFjdG1IOUpxNlV4dlB1dkN2OXZDbjRy?=
 =?utf-8?B?QXhSc0JBVlhaTjFSVCtsQ2h5Mm9hUlFYaXpWczVFSmU5aUVQWk5QeEJjMjdD?=
 =?utf-8?B?ZmJiQ1REcG52Ti9scFB5U21JcU9mKzdLRnNJb0U2ekRlRU9MSzBpenliQk5Q?=
 =?utf-8?B?aHNudXU5N2NXSVZWbDJER21xWUVxdHN0N3N6Ym1vNG9SQmpveDhXK2RpKzNP?=
 =?utf-8?B?UnBoQ2NKZTl3TjBlL21xbVZaWkhvQXhxL2t5SGxnWUxyR1dpa3VOanBFNE1N?=
 =?utf-8?B?R29nME5UdklORWhnaGsrNXUxZi9OTnRsdVZKcjFWUHJJeTg4cU52N0xXdFJZ?=
 =?utf-8?B?NCtjYWhVSTFkT29lZldHeElGd2t6dVBmMVVXUjRHVkNleUJ0QXdkZHR1dlFn?=
 =?utf-8?B?UTRuOE9tazFiajNaOUE3ZkFTZXc1b0pRZXhwRXNLOFJGb0QwOFRNaFFHdzly?=
 =?utf-8?B?ald5N0pEdzZqbk1UWnBzdkFUUisyZVdmTVVHUXZMOVFLQnNMcVg2WWlLc3dR?=
 =?utf-8?B?ZjNtSm5lMEErSHJSYjBmRlN5cGNURGtMWkIzcUgxb1c2TFZXVmZ2QktNL3Ns?=
 =?utf-8?B?K0phd1RzNEJLRXVCdnhjQWFGVlk2OS8vVElLRHVJaXREU0pWZ2ZOUFF4WkZ1?=
 =?utf-8?B?QTAvNTBDZ0RkbFUwQzRnWnpXQjlLNmdKL2VNbURNTWtqYjhjNG9iQ2YvdFNP?=
 =?utf-8?B?QmtBaUZuQ2RJbmdpZDVMNmI4Ym1DbkVaWWdBa2pOb242YStzY1g2VzBRdFIy?=
 =?utf-8?B?S1VTRXFUTVdMeUJzNkpQSWp3MVd4YUFtcHg5bzhKUklFVUNSUXRtRyszdTV3?=
 =?utf-8?B?aHFoN1JYd2pxeGxuQU9OTDRJK0ZaNlBuVWl6NElZdHN1VUE3TEZ6dDYxMS9Q?=
 =?utf-8?B?UGZPRjlZdnhwWUZKbEJvNnNWNDMrUTZTSG4wbCtxbkV2VDNkNkFPb0VFMjkw?=
 =?utf-8?B?aGNpSDZwcUxCTVVSMHgxd3pNb1JwTkVoQXJoZEYvZlRuSG5ubnBNZDRnWEFx?=
 =?utf-8?B?dG04NUlWbjh3MDlZUnQzVFZOV0EvUndpMHVKQzVBMFVxVFhXWU83TForOW5B?=
 =?utf-8?B?MENySHFaUmhFWUwxbG5UN3A0MU9GSnAzeHZKSUQzYS9yODFaV2g5TXB0aFRa?=
 =?utf-8?B?NVIyQW9WYmgrRENRSGFXV0F4V3NPUmxZYVpxdGkvY2E5eFZuQjRKQ0pxV2FY?=
 =?utf-8?B?cmJXelNKcVdYU2lIMVR5NVMxUHNJK09jMEgvcHkyWVZ5T1VPWGEwUElnYXo3?=
 =?utf-8?B?MU85MUErWmY0V3kxZDRsV1B5a05HWnVaS3Y5SnE4SnY2Mkc1bmxQblJjakFS?=
 =?utf-8?B?Y2NubnFDSXNCdyt0ZXhyWG5YNDRMMExlRW1jbnBrMXhlKzBDc0dxUWs0VWI0?=
 =?utf-8?B?OUZ6UGVSSCt5M0FXY25DTE5oc2dmMWE3Ujd3RFpxOThraWZVQUpyTHErRjJ6?=
 =?utf-8?B?U1o1a1VvazZpRWRLZTZGTnlOM0MvMUcrbFN1cWxvY21HOCtPRnlIT2xhSWRN?=
 =?utf-8?B?ZFQ3Q0I2bWZsVC8vcFM1SlNnd3VxNGhWZnBCMTVUVjRzb0Y1a0M1RC9MY3c0?=
 =?utf-8?B?aUxGaHljUWUvZ1BHU0ZWSFBYWG9YSG1oeFpKcG84NjIxbkNvQ2gyVWJpK3Vk?=
 =?utf-8?B?L1NwSWhFK0laUi93NFBVQi9jZHFBKzRzMkpraWh5SzM2YjJscjJTRXducU1y?=
 =?utf-8?B?S0g1TitPSysveGcyWllab0VmVlh4Q25yMThvQnljRjhBSERUU1NRZWh4OWpM?=
 =?utf-8?B?Ynp5REVJbUlJZVQwa0hld2VYZlhxY2NtZEM4U1VDNFNVMHc1TGNPWUxWRjF0?=
 =?utf-8?B?Yk1lTVd5cG9nTUpZRGV3YmR5akJvdHhOM21lcWdaS2JsMHZhS2dnNVFkMjZZ?=
 =?utf-8?B?NXJvQlZPcGhScHYvSW9aTEFyV2JHRXpuZjJ4ejNyWU0ra2pReURhSWZzNUpF?=
 =?utf-8?B?U2YyWXR6TjliQnNSRm8zckVndWpsd1F1c3IzSWhMSDd2aTMyZm5KNGVUd0Jm?=
 =?utf-8?B?bEhIclk3VTdIOEM2alJDR3ZOb0podkJVTm01Y211cllsNHZzUkpVQ0lBOFFO?=
 =?utf-8?B?Ly82TDl1akczeGticDhVcE85L2VUd3lmZnhnOVl0STRHeUtuZUVaS3JleW9l?=
 =?utf-8?B?UzhGaThUS3FicEI2MldaVWMxSC8yRXJqVHQ2NGFsTG9VblZROWg2ZzJ5MlNu?=
 =?utf-8?B?Nlh1T2tEczQ2dkRtR2tmcUk4cnpWVy9HSU0yZWcwMUtLSmdDTXE3anloczJ3?=
 =?utf-8?B?WjdsQ2s5SE9EWnpMdHRMc3V0ZlRhQ3FMUlZxVDdQUFE1Z01Vc3NzUT09?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 16e57441-6f8a-48f1-db21-08da32a0bd56
X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB3287.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 May 2022 16:18:38.0338
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: A1ZmqvLHTIrY7s3yc61XDnaEyICWqU6YphGerHmHAmWIiomtrh8dXO+9WFQFumqThFQeWivWwlR9cOXmJnhulA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB5295
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858
 definitions=2022-05-10_04:2022-05-09,2022-05-10 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 malwarescore=0
 suspectscore=0 phishscore=0 spamscore=0 bulkscore=0 mlxscore=0
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2205100071
X-Proofpoint-GUID: VO_hO3bpv_Y8zNHRxvXP-nnW_CotslvU
X-Proofpoint-ORIG-GUID: VO_hO3bpv_Y8zNHRxvXP-nnW_CotslvU
X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 5/10/2022 4:27 AM, Eli Cohen wrote:
> In vdpa_nl_cmd_dev_get_doit(), if the call to genlmsg_reply() fails we
> must not call nlmsg_free() since this is done inside genlmsg_reply().
>
> Fix it.
>
> Fixes: bc0d90ee021f ("vdpa: Enable user to query vdpa device info")
> Acked-by: Jason Wang <jasowang@redhat.com>
> Signed-off-by: Eli Cohen <elic@nvidia.com>
Reviewed-by: Si-Wei Liu <si-wei.liu@oracle.com>
> ---
>   drivers/vdpa/vdpa.c | 13 +++++++++----
>   1 file changed, 9 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/vdpa/vdpa.c b/drivers/vdpa/vdpa.c
> index 2b75c00b1005..fac89a0d8178 100644
> --- a/drivers/vdpa/vdpa.c
> +++ b/drivers/vdpa/vdpa.c
> @@ -756,14 +756,19 @@ static int vdpa_nl_cmd_dev_get_doit(struct sk_buff *skb, struct genl_info *info)
>   		goto mdev_err;
>   	}
>   	err = vdpa_dev_fill(vdev, msg, info->snd_portid, info->snd_seq, 0, info->extack);
> -	if (!err)
> -		err = genlmsg_reply(msg, info);
> +	if (err)
> +		goto mdev_err;
> +
> +	err = genlmsg_reply(msg, info);
> +	put_device(dev);
> +	mutex_unlock(&vdpa_dev_mutex);
> +	return err;
> +
>   mdev_err:
>   	put_device(dev);
>   err:
>   	mutex_unlock(&vdpa_dev_mutex);
> -	if (err)
> -		nlmsg_free(msg);
> +	nlmsg_free(msg);
>   	return err;
>   }
>