Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp6222922iob; Tue, 10 May 2022 13:14:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz9O6UpfW4sKV4HEZIloy/ct4nAdiMmFvYikmyD76HFAHs1+YG1VloDcRJ4w2ykXQaUDft0 X-Received: by 2002:a50:eb05:0:b0:428:9cb3:5cb1 with SMTP id y5-20020a50eb05000000b004289cb35cb1mr12808883edp.344.1652213645807; Tue, 10 May 2022 13:14:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652213645; cv=none; d=google.com; s=arc-20160816; b=TcruKnwHibfn/G82ygeNLgw/IwX+82D1qc/O6TezW+z4VB+VNmYsYtSAwUxwWcV7hL kw5sbLFsQHclugGTp3uzZxYXvlJHzdFVW086d0XkQc0DR+6m/E7qewDyKFqkNihQwF62 S7KJRdplvQxOzcOrQ3n3OWvF3fTRoVQKcCQa276dGpCUOx/6ZO6KmuGniN5/SKVEN6Rb gl89ZFNGnbDlE34POVKgu84U+5cKFJWGmgAbva6u8hLest0Ykmxt7vhIEcQC64J0Zp7r FYCsB7kcWhdAQYF0dMf+anD/MGARSWZ/shMojlXkz9E5nZCNOqnY/UURf98dfjSyUNzy X/8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:sender:dkim-signature; bh=5sDgeD0YOOWBC8MnsZdewpm6fm+8JdOylgUar+PbYV8=; b=mV36f0MT/Nwc6587pKuPBX0jCa2BOcsDLTN5ZM4FC0UlQmhOAAv9htT3bJYv2Xhgyz D5ssxM7ZoyRmILZxJe2+TeiNJywo27Sec9uSSSyz30NSmIOrV6nn8wpv/bqpq4ohmlk8 DswtnEG3h9shJd4x+uy8Z8cjLV6xnyv51NH8SZqygGioY9P76dOKLBxrLpRaEYRyBLKs XVpngm1b7OImFl7loE3jYJRKFlDEU90a+EN0I3R+nn3RInM2yrV4nBRJPhPkB/gRwekf 0GcQD1vY6+Z5cYzB5d/m88QoCn4fkA8aoeUqn+46K+AaGwh1MA0JriAR1zB7JzG0ApU6 YEEA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=E8vh1kib; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ne5-20020a1709077b8500b006f476161a18si240121ejc.744.2022.05.10.13.13.41; Tue, 10 May 2022 13:14:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=E8vh1kib; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348850AbiEJSZ5 (ORCPT + 99 others); Tue, 10 May 2022 14:25:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40772 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245188AbiEJSZy (ORCPT ); Tue, 10 May 2022 14:25:54 -0400 Received: from mail-pg1-x52a.google.com (mail-pg1-x52a.google.com [IPv6:2607:f8b0:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7ED1C50E13; Tue, 10 May 2022 11:25:53 -0700 (PDT) Received: by mail-pg1-x52a.google.com with SMTP id r192so11126214pgr.6; Tue, 10 May 2022 11:25:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=5sDgeD0YOOWBC8MnsZdewpm6fm+8JdOylgUar+PbYV8=; b=E8vh1kibB970hzIpWVqJvrUM/XAa+WhlHnQFKxRLbh2erbItToTT6MRIvKSM0P4r2x 58dJE/MPLzbdvNTF/8JgkiZpQ+hkUiVXgM/IptFaGGnZoMvr+KfASvNybW4eIs7Gs2P/ 84WqOoBsFK3g0q4ZavWX9GVFjNFZuiil5rhwquelrWdxHNCbQxcbagx4CVcyzGC0nZeY N4llZYPHZytpybWUkGUmCzeUXQ8BdEzXFnUyvcg0E+uA8JZH9nCmcFl8u8et4fY4uCGb ELlIp5TsPXGhKeOsZM4/YeYzYMepEc6xwCceDtSxF+OdsmYoPeboh+xZ6Kfte0dCYDN+ GcZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=5sDgeD0YOOWBC8MnsZdewpm6fm+8JdOylgUar+PbYV8=; b=hyb3FxOaKIHQzX6VW4/tWEKcEWnOTFxmoYjPxMCNmMnWzijgtzX2OpZmhnVO3HfsEc WgNMz7LcqMBHW2K4HnyF/1Q/avVZRqFxbv1oCSXznPYgpoYlqy0+E0B80NvpXxOcqlsG E0ZsGI3Z1CiTKqd/5wyM2oV3jEE8yABU1aPARdiOFNnWJPO5bN0O0EOLcLjyurLRAxNM N+Hpsrm4MvIga2o0BLflZCJgzn/usQCvyjXIQwOvkShYD2pGuFlITW0GGZpfkTvDdVy1 5ZtzBq7+jvvHXvC7V+RbtpQdNVvv6KhiL212yS/M+1t12EdOMOifLOMBKgSfSeB3S45Y ZTBQ== X-Gm-Message-State: AOAM530T2QEwZFIzY2SQ9vvkdeoBpnHk8/3PLjNumJu7TSpNApAB/te+ FcD7+HB7pPQ91gyFdmdAdEE= X-Received: by 2002:a63:4f48:0:b0:3c6:b640:6046 with SMTP id p8-20020a634f48000000b003c6b6406046mr9396578pgl.118.1652207152804; Tue, 10 May 2022 11:25:52 -0700 (PDT) Received: from localhost ([2620:10d:c090:400::4:6c64]) by smtp.gmail.com with ESMTPSA id a25-20020aa780d9000000b0050dc7628182sm11266714pfn.92.2022.05.10.11.25.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 May 2022 11:25:52 -0700 (PDT) Sender: Tejun Heo Date: Tue, 10 May 2022 08:25:50 -1000 From: Tejun Heo To: Chengming Zhou Cc: axboe@kernel.dk, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, duanxiongchun@bytedance.com, songmuchun@bytedance.com Subject: Re: [PATCH] blk-iocost: combine local_stat and desc_stat to stat Message-ID: References: <20220510034757.21761-1-zhouchengming@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220510034757.21761-1-zhouchengming@bytedance.com> X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 10, 2022 at 11:47:57AM +0800, Chengming Zhou wrote: > When we flush usage, wait, indebt stat in iocg_flush_stat(), we use > local_stat and desc_stat, which has no point since the leaf iocg > only has local_stat and the inner iocg only has desc_stat. Also > we don't need to flush percpu abs_vusage for these inner iocgs. > > This patch combine local_stat and desc_stat to stat, only flush > percpu abs_vusage for active leaf iocgs, then build inner walk > list to propagate. > > Signed-off-by: Chengming Zhou Acked-by: Tejun Heo Thanks. -- tejun