Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220510025004.2561532-1-wanjiabing@vivo.com>
In-Reply-To: <20220510025004.2561532-1-wanjiabing@vivo.com>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Tue, 10 May 2022 11:07:53 -0400
Message-ID: <CADnq5_OiFNWgwgqP12cniuFVNNRWVrfGKgBNOPAjBSu5cLsMHw@mail.gmail.com>
Subject: Re: [PATCH] drm/amdgpu: Remove duplicated argument in vcn_v4_0
To:     Wan Jiabing <wanjiabing@vivo.com>
Cc:     Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>, James Zhu <James.Zhu@amd.com>,
        Leo Liu <leo.liu@amd.com>,
        amd-gfx list <amd-gfx@lists.freedesktop.org>,
        Maling list - DRI developers 
        <dri-devel@lists.freedesktop.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Applied.  Thanks!

Alex

On Mon, May 9, 2022 at 10:50 PM Wan Jiabing <wanjiabing@vivo.com> wrote:
>
> Fix following coccicheck warning:
> ./drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c:724:4-36: duplicated argument to & or |
>
> Remove duplicated UVD_SUVD_CGC_GATE__SRE_H264_MASK.
>
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
>  drivers/Gap/drm/amd/amdgpu/vcn_v4_0.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c b/drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c
> index c37dbac9d96b..9119e966ffff 100644
> --- a/drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c
> @@ -722,7 +722,6 @@ static void vcn_v4_0_disable_clock_gating(struct amdgpu_device *adev, int inst)
>                 | UVD_SUVD_CGC_GATE__SCM_MASK
>                 | UVD_SUVD_CGC_GATE__SDB_MASK
>                 | UVD_SUVD_CGC_GATE__SRE_H264_MASK
> -               | UVD_SUVD_CGC_GATE__SRE_H264_MASK
>                 | UVD_SUVD_CGC_GATE__SRE_HEVC_MASK
>                 | UVD_SUVD_CGC_GATE__SIT_H264_MASK
>                 | UVD_SUVD_CGC_GATE__SIT_HEVC_MASK
> --
> 2.36.0
>