Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp6275807iob; Tue, 10 May 2022 14:39:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzP9wyFvx83QatvvOyFAuqejwtdtETjfdXRf4F9Ai55WGEiLtSPRH2W/NPq/OxkaLDS5xJA X-Received: by 2002:a05:6402:e9f:b0:41c:df21:b113 with SMTP id h31-20020a0564020e9f00b0041cdf21b113mr25874289eda.217.1652218760348; Tue, 10 May 2022 14:39:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652218760; cv=none; d=google.com; s=arc-20160816; b=hsS01EmvrG5oABQm2p6wIRk4O2dVPtZdt1bbmb5p0eCMcwMyFmPZJq9xHm+2upE4I0 0TXzOT7bUAjXHVXfKP0uy8eLl8YwYGTE0DsMtaHfha7gs2SS7sgwgd5QXuy2jFZAfDwX aVGYFll0b6ZGCgyFYlnGK8qd7AncIacg51OrQq1AmuYSV9hU3L6ahfiol8BdA3DUXW9c aVVOHKrdCIea6roErjNoRj0ORaBjScGDlAPOcyzKsXHxTTb3grGbuvxCqfQRBXCbBDsX DsQFmNNF2tUME7kk1DneE8rUfUtE1tTzy3HBP3mpvL9eAff04k5uPIUMzPPQ5iKzYHId Bl6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=YlcWQ+1kLkT6PG9bM64j864UAyPZnWFZdmXfBe/vu98=; b=mVxA/HqW1FWaBKRa4PhwFdHLxvSBLCKvof5vkk6Ytrqy0pSa4qKvIQ06ycWrXCX2RV QVmznOGJcADVJXYrEspCEgyXhe9U0aF81SRbERBpOzWwcXCrb8Gp+GBqQ7DtlMGm+t3q hgsdMZoqdPYqcNmfkKdVRwsKwGtqW9htvV1ds3M+mzaCfKpdoAy32aU8sDqutd31YbqZ mGQwDi/EGR2bIqEUKeYloz64Hc2CcEpCuLg8MyRc6UVmCeKEuKZyefXW1NIUKJ5ToSMY dt9HuawCgGAXiLavpQmy/JzCiGSOEkR+r8lc6eFgsIUSDKF0CmVGECjRpXsY03ijo1MS Ni8w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=eTqR5CHH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id nb29-20020a1709071c9d00b006f50917110esi636121ejc.163.2022.05.10.14.38.55; Tue, 10 May 2022 14:39:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=eTqR5CHH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245539AbiEJOG6 (ORCPT + 99 others); Tue, 10 May 2022 10:06:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55152 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244378AbiEJNlv (ORCPT ); Tue, 10 May 2022 09:41:51 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3EBBD2A1539; Tue, 10 May 2022 06:30:04 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7ED30615C8; Tue, 10 May 2022 13:30:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9268EC385C2; Tue, 10 May 2022 13:29:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1652189399; bh=M++pNsSDyjD/GlMxredGq+cpP1ZDMWAdbPKhR1TW1Ls=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=eTqR5CHHWvdUbA3ZxYCw5lsqo4vScpAMAsZVYvfhY+0aCnAcOhKXzsF+aUg5/5Mlw sUzyQgJwg1GoHPZSAXbAbQKSOilRjjLR4PdLnnYoStUk4Puf/16SZ6KHFci5N9HqS+ WzDT6ZA+Tg5fqGA+Kcb1VOp75WOEJhndR6w7rB3M= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Takashi Sakamoto , Takashi Iwai Subject: [PATCH 5.15 004/135] ALSA: fireworks: fix wrong return count shorter than expected by 4 bytes Date: Tue, 10 May 2022 15:06:26 +0200 Message-Id: <20220510130740.524398135@linuxfoundation.org> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220510130740.392653815@linuxfoundation.org> References: <20220510130740.392653815@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Takashi Sakamoto commit eb9d84b0ffe39893cb23b0b6712bbe3637fa25fa upstream. ALSA fireworks driver has a bug in its initial state to return count shorter than expected by 4 bytes to userspace applications when handling response frame for Echo Audio Fireworks transaction. It's due to missing addition of the size for the type of event in ALSA firewire stack. Fixes: 555e8a8f7f14 ("ALSA: fireworks: Add command/response functionality into hwdep interface") Cc: Signed-off-by: Takashi Sakamoto Link: https://lore.kernel.org/r/20220424102428.21109-1-o-takashi@sakamocchi.jp Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/firewire/fireworks/fireworks_hwdep.c | 1 + 1 file changed, 1 insertion(+) --- a/sound/firewire/fireworks/fireworks_hwdep.c +++ b/sound/firewire/fireworks/fireworks_hwdep.c @@ -34,6 +34,7 @@ hwdep_read_resp_buf(struct snd_efw *efw, type = SNDRV_FIREWIRE_EVENT_EFW_RESPONSE; if (copy_to_user(buf, &type, sizeof(type))) return -EFAULT; + count += sizeof(type); remained -= sizeof(type); buf += sizeof(type);