Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Liam Howlett <liam.howlett@oracle.com>
To:     SeongJae Park <sj@kernel.org>
CC:     "maple-tree@lists.infradead.org" <maple-tree@lists.infradead.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        "damon@lists.linux.dev" <damon@lists.linux.dev>
Subject: Re: [PATCH v9 15/69] damon: Convert __damon_va_three_regions to use
 the VMA iterator
Thread-Topic: [PATCH v9 15/69] damon: Convert __damon_va_three_regions to use
 the VMA iterator
Thread-Index: AQHYX1QE+HvcVvuhWk2ltHXx1nzXSq0X9zAAgABf6YA=
Date:   Tue, 10 May 2022 16:27:53 +0000
Message-ID: <20220510162745.txhq4nu6kuselskh@revolver>
References: <20220504011215.661968-1-Liam.Howlett@oracle.com>
 <20220510104428.152064-1-sj@kernel.org>
In-Reply-To: <20220510104428.152064-1-sj@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Ggqk5oWgLIUSBnewkVkSjeN+S9n7TkkXWODu899J8eRWhSk8JOTkAB4EfCMU?=
 =?us-ascii?Q?eyDAwAAyzW/44POXqd2PuFYwjQXjHqnvHLQKE6kXj+vKLGXV6GQ2kiH4Z47L?=
 =?us-ascii?Q?MY5Ho4+VxvpbgP1xrMwtSWFPmrk9eVzQBYsDIZJYZr7vtzaMvV+rag+pZsvJ?=
 =?us-ascii?Q?buslPdas1BviOlFy3rm4KFbZgDJ+lQn2D1gnl03wFRFIBwcCVncZkm0kUYGi?=
 =?us-ascii?Q?bqeOqocgfCV7WkZR/bfOiViskivLig0JM7QBjVw39JI1KSZa5iNeBYZQApNS?=
 =?us-ascii?Q?f4fHOGEH5VJjqtxneBwbjWhxD2LhxyXBYUGG47YMqWWeV0rIFx4LBkDSlzPL?=
 =?us-ascii?Q?8qywQKdRHsrI7jQbX9JtKw1uj+QcdbfAbm1tu56OZhkOnyCM4g5tHgSKWcK3?=
 =?us-ascii?Q?45SG+nqieCjWFwfAzkKcoQ2HtAzl/4Pq0/0nkW9clFwnMr8XE8M90PYn6az5?=
 =?us-ascii?Q?GOgdbDEnc2a4cqdFVkUsxcrwRUmZ5nEHAt8yaFkHzlyC+MWNQe+/f5dSvAjQ?=
 =?us-ascii?Q?JOfSBCrcHu73RRNAFJgiSUrWufckEUHiI6UmtpMcMISkHzHPa22qIvvg+YTN?=
 =?us-ascii?Q?JRTug373G5dZkUGdT0YIbFe93FiT/GWKYuq1qM/Bw569ah9YA4BoibJpa/T1?=
 =?us-ascii?Q?ezUd/24GD6RACnNvYu+OgRAtswsJBkDzEvia06KC0AslTQlPi5jiivRjjCli?=
 =?us-ascii?Q?b8icIynjd54oV8lreGdVpEc33ZeAADP3LypI8R6lp2WulIc5zh+/4t3A5u1T?=
 =?us-ascii?Q?YNQQUp0xQ1UxlVuhaHqqt2Oqqlq3Oucyf76w1Nm3+MVDoa7tQY+x2AHwp+3y?=
 =?us-ascii?Q?VmdFHKCrY2t86nyRKzj44QDczlP5hzdL4bSur49+Yrp7yGRZ8Yvjb62okDB3?=
 =?us-ascii?Q?D06io0hXeYBuJW9JjMpO/ltiPGkhC8ZS+h7xDw/REHnIILSiSpTLc6pdJnc9?=
 =?us-ascii?Q?Cpgf/o3rfjQcZX1+ecuQBTEMn+BobjwvcQc3QCGa4nXEafKSY6JXwHkxtpay?=
 =?us-ascii?Q?GNblGPXfU95SgzdXK7LQ4qgdXFYKEwnPrPXldnszmEU73n4P+qPVqfkVm1R7?=
 =?us-ascii?Q?ZlWHrPjeCZv3IKRbknHhMc4e//hRGfT3C9SDBdBZNZJyyN965DPjtuukGCZC?=
 =?us-ascii?Q?S+xyxh/O7jLjxbdldTUH7c1pJ9qAB3uun4v/q9mIeC2qAPsdpRfU5W1SL/uQ?=
 =?us-ascii?Q?lrxPgP8mQ/RtR0rP/j/Q2eaBd8MiIRvCtV2BWrvoaUhQWRgd1KQnxaR0mLs3?=
 =?us-ascii?Q?wrlk+FEG3pnyLSsTCU7Gf1QLbntM3Jcq16INmWlAdIvhTi0Pj4YWi3x5gkKQ?=
 =?us-ascii?Q?OgOTbkDMxK+qOmyM1vinLi+tDiRiUfVu7LWnSdID+6dpND702pORnFXQyKDc?=
 =?us-ascii?Q?rDoNoNS5FPmWh5kZyuBOO50b4VW/fYT0zWT9xl1STOlsJjndfHsfcAyzMaOL?=
 =?us-ascii?Q?muIkZy/2Tm4sLLNGdi/bKxWqgffBRwyViomBdZhwKPpq022StNy/gECtGcJD?=
 =?us-ascii?Q?Bb/MXKAkdBtGtD6t6q8Q07Y93xf6QiuAGhJa7sSPIYfq8ErdXSXntkcE9m/R?=
 =?us-ascii?Q?Am1f8IGen4pcZTPBMxJXuKl3vtYGI+ZVXK2uL5LWJD/I9XT7ZDPTuFkFLrPF?=
 =?us-ascii?Q?Xq74h60u3Tha08t/buZJbnqdp8yl73iKv3ZTLTRnNHCL0jSBVTath9WMMXLO?=
 =?us-ascii?Q?giTkANepmB9w0Qme9mpoC76Fthpw/rNgzs0Hty7L9POPBSrRvz6+HR5bgeT2?=
 =?us-ascii?Q?PaUNEmyClBp4jTSqWVAGuAqCpl8yU3o=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <88D4B5948A6E09458087791ECCA3D02B@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 214a1001-870d-4f8c-b998-08da32a20877
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 May 2022 16:27:53.4345
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: neKhSOG+JTItv9tJtsB8u0cjS6dkobVjvu82F6Eqb9b1ulYi+DQmwl/ZJ55XRrtLCBhK2Aa5rAWETI9gToCtgw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB3827
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858
 definitions=2022-05-10_04:2022-05-09,2022-05-10 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxlogscore=606
 spamscore=0 bulkscore=0 adultscore=0 suspectscore=0 mlxscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2205100072
X-Proofpoint-GUID: UJD0AwAqlPg3_J9dl3WBAIPd6iHniJk1
X-Proofpoint-ORIG-GUID: UJD0AwAqlPg3_J9dl3WBAIPd6iHniJk1
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

* SeongJae Park <sj@kernel.org> [220510 03:44]:
> On Wed, 4 May 2022 01:12:26 +0000 Liam Howlett <liam.howlett@oracle.com> =
wrote:
>=20
> > From: "Liam R. Howlett" <Liam.Howlett@Oracle.com>
> >=20
> > This rather specialised walk can use the VMA iterator.  If this proves =
to
> > be too slow, we can write a custom routine to find the two largest gaps=
,
> > but it will be somewhat complicated, so let's see if we need it first.
> >=20
> > Update the kunit test case to use the maple tree.  This also fixes an
> > issue with the kunit testcase not adding the last VMA to the list.
> >=20
> > Fixes: 17ccae8bb5c9 (mm/damon: add kunit tests)
> > Signed-off-by: Liam R. Howlett <Liam.Howlett@Oracle.com>
> > Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> > Reviewed-by: SeongJae Park <sj@kernel.org>
> > ---
> >  mm/damon/vaddr-test.h | 37 +++++++++++-------------------
> >  mm/damon/vaddr.c      | 53 ++++++++++++++++++++++---------------------
> >  2 files changed, 40 insertions(+), 50 deletions(-)
> >=20
> > diff --git a/mm/damon/vaddr-test.h b/mm/damon/vaddr-test.h
> > index 5431da4fe9d4..dbf2b8759607 100644
> > --- a/mm/damon/vaddr-test.h
> > +++ b/mm/damon/vaddr-test.h
> > @@ -13,34 +13,21 @@
> >  #define _DAMON_VADDR_TEST_H
> > =20
> >  #include <kunit/test.h>
> > +#include "../../mm/internal.h"
>=20
> V9 maple tree patchset has moved the definition of vma_mas_store() from
> internal.h to mmap.c, so inclusion of internal.h wouldn't needed here, ri=
ght?
>=20
> If we end up moving the definitions back to internal.h, because this file=
 is
> under mm/damon/, we can also use shorter include path, "../internal.h".

Yeah, that seems like a good plan.

I will be moving it back to internal to restore functionality to nommu.