Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ede9e050-3b60-ba0e-c626-044f7825adb7@gmail.com>
Date:   Tue, 10 May 2022 23:07:23 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.0
Subject: Re: [PATCH] mtd: parsers: add support for Sercomm partitions
Content-Language: en-US
To:     Miquel Raynal <miquel.raynal@bootlin.com>
Cc:     Richard Weinberger <richard@nod.at>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        Rob Herring <robh+dt@kernel.org>,
        NOGUCHI Hiroshi <drvlabo@gmail.com>,
        Hauke Mehrtens <hauke@hauke-m.de>,
        Karim <Karimdplay@gmail.com>, M <x1@disroot.org>,
        linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org
References: <20220329122016.4122899-1-csharper2005@gmail.com>
 <20220330100958.57dc4d61@xps13>
From:   Mikhail Zhilkin <csharper2005@gmail.com>
In-Reply-To: <20220330100958.57dc4d61@xps13>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi Miquel,

On 3/30/2022 11:09 AM, Miquel Raynal wrote:
> Hi Mikhail,
>
> csharper2005@gmail.com wrote on Tue, 29 Mar 2022 12:20:16 +0000:
>
>> This adds an MTD partition parser for the Sercomm partition table that
>> is used in some Beeline, Netgear and Sercomm routers.
>>
>> The Sercomm partition map table contains real partition offsets, which
>> may differ from device to device depending on the number and location of
>> bad blocks on NAND.
>>
>> Device tree example:
>> partitions {
>> 	compatible = "sercomm,sc-partitions", "fixed-partitions";
>> 	#address-cells = <1>;
>> 	#size-cells = <1>;
>>
>> 	partition@0 {
>> 		label = "u-boot";
>> 		reg = <0x0 0x100000>;
>> 		scpart-id = <0>;
>> 		read-only;
>> 	};
>> };
> You'll need a DT binding patch and Rob's ack!

I hope that I near to finish with DT binding...

Link:
https://lore.kernel.org/all/20220510162314.20810-1-csharper2005@gmail.com/

Link:
https://lore.kernel.org/all/20220510162403.20861-1-csharper2005@gmail.com/

>> This is essentially the same code as proposed by NOGUCHI Hiroshi
>> <drvlabo@gmail.com> here:
> I would credit Hiroshi with a Suggested-by at least

I read submitting patches rules again and thought that Signed-off-by is
suitable for this case. Is this ok?

Link:
https://lore.kernel.org/all/20220510162655.21011-1-csharper2005@gmail.com/

>> https://github.com/openwrt/openwrt/pull/1318#issuecomment-420607394
> And use a Link: tag for this.
>
Fixed, thanks!

Link:
https://lore.kernel.org/all/20220510162655.21011-1-csharper2005@gmail.com/

> Thanks,
> Miquèl
-- 
Best regards,
Mikhail