Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp6492322iob; Tue, 10 May 2022 21:25:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyodLigUL/Y8DTxLtoU7bbw6e9iGVWmWTUL/M6dBSMjye4hwiB3xyhlG/LjsCnZm4pU2+wR X-Received: by 2002:a17:907:6096:b0:6f7:afe7:83e1 with SMTP id ht22-20020a170907609600b006f7afe783e1mr18716387ejc.469.1652243121127; Tue, 10 May 2022 21:25:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652243121; cv=none; d=google.com; s=arc-20160816; b=gwP/MmoyWvMdS9D2ccBBy6rTansMbvswuM5gk7GxcwNJWFU+XcPwtrCRpYX05P/lqy rS6/9+w+BvGOunxxKYjC22ERjV9i1SdBDqwP3Odd6OGYZJnT+ZF05MHP1svgR+usLURI 1q8WM+2BjXh27JtduB2yVZKEQpJdKyBV5fxFb2QLSNDg2dgg5LnZw8Th6Ir5jHVP+OVZ XrtamVQ3QN2RZG+YgJzyu86pM2GEuooWHBgVl+tEmj1Z/EXyIi39TP+R1b59xt8rBxxC pYk/Gs1zm8oJxdcad/TH4qZzNrll+3VvEEXIHTp6JQniCAxZPDYvF4PizegnAT05gnOg vJVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=V0UajMzXFBNf7cUMuc7pmjx3pa00PRDw60cm0sn0muk=; b=YcQRCAdN6nmJ61kbHk/Cp2wbkGCqAt0rgLtljMkKyqsCBitYOD1SNIE5y3b4HLFKkR nNdIKM5MjvTbJrgyV20DT70ZX8wGxCEfgH6/CXGYrlGL6LiSaFGbukVPYdYAyCTZbCA4 ouU80qNoPTO4Ur5f6CzBXfXwPEtKS6H655gr6biUGjuW4pmoerVD8591htaLcBfzVm46 WosXO4ZL8Vx676eaL+otN2IPwvnqDYYaKJM5IpyhgFxszajegysfLBmqkhg0PLGxOhTf ubiUoSe7nqovDhBEFuN54kwe20gpIvYPiDWxdE0qqhFt6pmwlPNp5VUyjtlXdljoBtqq NbtQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=lgt9ntka; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hq42-20020a1709073f2a00b006e84b300cdesi1128770ejc.54.2022.05.10.21.24.56; Tue, 10 May 2022 21:25:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=lgt9ntka; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243691AbiEJOdO (ORCPT + 99 others); Tue, 10 May 2022 10:33:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43120 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344266AbiEJOHs (ORCPT ); Tue, 10 May 2022 10:07:48 -0400 Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 455A821333B; Tue, 10 May 2022 06:42:06 -0700 (PDT) Received: by mail-pj1-x1030.google.com with SMTP id fv2so15904481pjb.4; Tue, 10 May 2022 06:42:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=V0UajMzXFBNf7cUMuc7pmjx3pa00PRDw60cm0sn0muk=; b=lgt9ntka8XC6Yi2GBLVPGUc7IL9mqeVrgCUn+a495s7WoVDLZsuLi8UBqCVFBGR4gl CXJ6XZlsjCnYG/dPov2d+syOxEJD9983PlWVPtDJO2w6qjp+j23q9pHTEgbgsLoF/sXi 6FVIqlso1nwB6AVxDNCM6TuCDpAlcK8DyBLW39KMkw2X5GPwaG4L/d8pWoA5oQyfYGpI 2YZ9JPS375oUN3AvwfnXyALr+6YVzOmI/Q51+h90/MtQQV4XHqibYRRYWBGbD/nWcRqZ nAJG9MvA8fvA+Dxd6ZmMGEApfljXC5eQopjE1jdfILLO2IhaAcEoHZVcK9W+3zxOy1ZD tuow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=V0UajMzXFBNf7cUMuc7pmjx3pa00PRDw60cm0sn0muk=; b=tk8oiFyf6U94Wtdz1KNGzPkMjRKLdOV0u7U7486AHHvCuEefuwEGCQRdYnjWTX0uA/ 7b9TAGrMCC4sRgjes/PfkiSnwdNhEqZ7dCyGLZI2AovWm5sWOSONhdpHIGRFfylI+MxX Pi0lfrRS9G8ehywj+eM6bCH5RGxv2oEvCwUe1MrpEZl4k3XvaAx5C6IckD/l0MURMJJN FP+oBBCV05s5aGGwq1uxdjmLKOr/AtQ216OZqdD0y8fbj4fwvv3qHkt6F9/IW+w4fvMP D9W8H1psIToqnoh7t+p7GMHzqOy6qbVURpSF5mGFAVVONpL8JMY8BbAzYlrVpn3vcn+I opfw== X-Gm-Message-State: AOAM530V8MrzlJFn1ww4mBcROCYxu+hsCI2+j3/R6Jy7c3NOC89IW27O sIsCOYckSV3l7jzWydfcYw== X-Received: by 2002:a17:90a:d3d2:b0:1dd:30bb:6a45 with SMTP id d18-20020a17090ad3d200b001dd30bb6a45mr88985pjw.206.1652190125550; Tue, 10 May 2022 06:42:05 -0700 (PDT) Received: from localhost.localdomain ([144.202.91.207]) by smtp.gmail.com with ESMTPSA id a13-20020aa794ad000000b0050dc76281desm10768620pfl.184.2022.05.10.06.42.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 May 2022 06:42:05 -0700 (PDT) From: Zheyu Ma To: tharvey@gateworks.com, mchehab@kernel.org Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Zheyu Ma Subject: [PATCH] media: TDA1997x: Fix the error handling in tda1997x_probe() Date: Tue, 10 May 2022 21:41:46 +0800 Message-Id: <20220510134146.1727701-1-zheyuma97@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The driver should disable the regulator when failing to probe. Signed-off-by: Zheyu Ma --- drivers/media/i2c/tda1997x.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/i2c/tda1997x.c b/drivers/media/i2c/tda1997x.c index 8fafce26d62f..0de7acdf58a7 100644 --- a/drivers/media/i2c/tda1997x.c +++ b/drivers/media/i2c/tda1997x.c @@ -2798,6 +2798,7 @@ static int tda1997x_probe(struct i2c_client *client, cancel_delayed_work(&state->delayed_work_enable_hpd); mutex_destroy(&state->page_lock); mutex_destroy(&state->lock); + tda1997x_set_power(state, 0); err_free_state: kfree(state); dev_err(&client->dev, "%s failed: %d\n", __func__, ret); -- 2.25.1