Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Haowen Bai <baihaowen@meizu.com>
To:     <tyreld@linux.ibm.com>
CC:     <baihaowen@meizu.com>, <benh@kernel.crashing.org>,
        <linux-kernel@vger.kernel.org>, <linuxppc-dev@lists.ozlabs.org>,
        <mpe@ellerman.id.au>, <oohall@gmail.com>, <paulus@samba.org>,
        <ruscur@russell.cc>
Subject: [PATCH V2] powerpc/eeh: Drop redundant spinlock initialization
Date:   Wed, 11 May 2022 09:27:56 +0800
Message-ID: <1652232476-9696-1-git-send-email-baihaowen@meizu.com>
In-Reply-To: <08d9470c-20db-52b8-7015-84f0ed29ad0c@linux.ibm.com>
References: <08d9470c-20db-52b8-7015-84f0ed29ad0c@linux.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

slot_errbuf_lock has declared and initialized by DEFINE_SPINLOCK,
so we don't need to spin_lock_init again, drop it.

Signed-off-by: Haowen Bai <baihaowen@meizu.com>
---
V1->V2: update comment

 arch/powerpc/platforms/pseries/eeh_pseries.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/powerpc/platforms/pseries/eeh_pseries.c b/arch/powerpc/platforms/pseries/eeh_pseries.c
index f9af879c0222..abf0b577d055 100644
--- a/arch/powerpc/platforms/pseries/eeh_pseries.c
+++ b/arch/powerpc/platforms/pseries/eeh_pseries.c
@@ -847,8 +847,7 @@ static int __init eeh_pseries_init(void)
 		return -EINVAL;
 	}
 
-	/* Initialize error log lock and size */
-	spin_lock_init(&slot_errbuf_lock);
+	/* Initialize error log size */
 	eeh_error_buf_size = rtas_token("rtas-error-log-max");
 	if (eeh_error_buf_size == RTAS_UNKNOWN_SERVICE) {
 		pr_info("%s: unknown EEH error log size\n",
-- 
2.7.4