Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Kuniyuki Iwashima <kuniyu@amazon.co.jp>
To:     <keescook@chromium.org>
CC:     <ast@kernel.org>, <cong.wang@bytedance.com>, <davem@davemloft.net>,
        <hch@infradead.org>, <kuba@kernel.org>, <kuniyu@amazon.co.jp>,
        <linux-hardening@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <netdev@vger.kernel.org>, <pabeni@redhat.com>,
        <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH] af_unix: Silence randstruct GCC plugin warning
Date:   Wed, 11 May 2022 11:22:17 +0900
Message-ID: <20220511022217.58586-1-kuniyu@amazon.co.jp>
In-Reply-To: <20220511000109.3628404-1-keescook@chromium.org>
References: <20220511000109.3628404-1-keescook@chromium.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk

From:   Kees Cook <keescook@chromium.org>
Date:   Tue, 10 May 2022 17:01:09 -0700
> While preparing for Clang randstruct support (which duplicated many of
> the warnings the randstruct GCC plugin warned about), one strange one
> remained only for the randstruct GCC plugin. Eliminating this rids
> the plugin of the last exception.
> 
> It seems the plugin is happy to dereference individual members of
> a cross-struct cast, but it is upset about casting to a whole object
> pointer. This only manifests in one place in the kernel, so just replace
> the variable with individual member accesses. There is no change in
> executable instruction output.
> 
> Drop the last exception from the randstruct GCC plugin.
> 
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Christoph Hellwig <hch@infradead.org>
> Cc: Paolo Abeni <pabeni@redhat.com>
> Cc: Kuniyuki Iwashima <kuniyu@amazon.co.jp>
> Cc: Alexei Starovoitov <ast@kernel.org>
> Cc: Cong Wang <cong.wang@bytedance.com>
> Cc: Al Viro <viro@zeniv.linux.org.uk>
> Cc: netdev@vger.kernel.org
> Cc: linux-hardening@vger.kernel.org
> Signed-off-by: Kees Cook <keescook@chromium.org>

LGTM, thank you.

Acked-by: Kuniyuki Iwashima <kuniyu@amazon.co.jp>