Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp6639321iob; Wed, 11 May 2022 01:59:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwzBcoxM1PUlEZkvZ6QJ+plqK9lQKupH0V9SJkoU0cNIXsdslXVLsKN4kGT2+54CWmxlu86 X-Received: by 2002:a17:90b:4d11:b0:1dc:ec4f:a19c with SMTP id mw17-20020a17090b4d1100b001dcec4fa19cmr4198331pjb.117.1652259575879; Wed, 11 May 2022 01:59:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652259575; cv=none; d=google.com; s=arc-20160816; b=gtuIYXQRbJ/spEWme49NmmP5P58hkJN39MwLwhyJL1Lh1mXTVbb00BnFNETVy8utNn KXXJ8jnVATrlrip7mvYF5+xrMQHJG+2MP7bRXksoLhxAPbup+/ySaYJ1L7W0dmNCzyBN uG2QdMVjGSqpnE8TM73/uUxQfprN08SfKF8WbLnMgUuDK0ZQKRbUz4pSwIIYACN7xxIR /vkZNh0lUcXSyfE8XcN0Q/DU8ndn9UzkM9EwjrHQF+T56YRh7EgfXPGysUkxBpqIpCL3 q1vdiv/hm/ILtzZUX2YqHBEZqcitsv0QmxYcgyYEAU+bgK8qxJ7yRyhmOwxUT/IZRoSM PIDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id; bh=1wEl4hKP70nqNM7+s33aDLROWITXXzeuUXQCyFgNxKQ=; b=RLJa9AUoP5BnwtYPt3Pf4Zde6VfGZ6Ejit/DQyeqD0hSX1UIiMN+V3FmDLxx1QYObq lAq2f8J6OhtfFmXJGvXvpNciSrwMb1ItuBB2qFzRxXzMWlMhTjvAtKzN+tx0Fya/PJXj vXOifcvi+baWye8mdSK7RWQhpQ/hlD3FRyQRD+rimX5bWPxi8mi2fnCEQGjOmehIYmXs iB6y43btA9hQfmeGAdHTJnxaC6mvMqVfrL6FSoL+IWwOQ9fjsoLhLdS3RsBLPkycamAM uDWiXFva/WDK0Rb6rl/08YE8tQmjnVObsG8Fttg4ykGpZDZiJyMYNsR76hfkpWxec3Pb 6Yqw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g10-20020a056a0023ca00b0050ad51e0abbsi1896848pfc.70.2022.05.11.01.59.21; Wed, 11 May 2022 01:59:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242425AbiEKGvt (ORCPT + 99 others); Wed, 11 May 2022 02:51:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40214 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242751AbiEKGv1 (ORCPT ); Wed, 11 May 2022 02:51:27 -0400 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4882357128; Tue, 10 May 2022 23:51:19 -0700 (PDT) Received: by mail-wr1-f54.google.com with SMTP id d5so1527136wrb.6; Tue, 10 May 2022 23:51:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=1wEl4hKP70nqNM7+s33aDLROWITXXzeuUXQCyFgNxKQ=; b=fL0QpNLjw5Bu1FPrB1EV69pKMr1WMiaxGDyNCVRaUu88Bdh1KTpsixQhD9bddg7O+u 6Rvz0mzL/8eE4ABC986jenh9G4Kw7NCZqqmkwbDj02D2UNWsh14SR/maEjFDo2OxI2gj Lk+rHMVrXcEl+uIjjiaaY5mMAGV2ypdg4W7V20ejr8UNBYDll3HZv9lktTcS1Lnz+sPn 0Mwf2Y6F08Nq5wTIm31d8qBM5kyCtuiX7JEsILRPAeDBk6KglhUDvYf03Z1RfpUG1jfF WRxTmTq866PI9cwsOBGHYQyf2C7eRHcvciooxoepfEylwhINYPyqS8KGR8xoLro166J9 VTwQ== X-Gm-Message-State: AOAM530BpgUxgyylrVAGSsY/zJipdAQrKOw5EMpW/1mQrb6Hj/7i2q9j g6JLWtUKKY1Y3eLDXkJG0jE= X-Received: by 2002:a05:6000:144a:b0:20c:6b73:804 with SMTP id v10-20020a056000144a00b0020c6b730804mr21963700wrx.88.1652251877878; Tue, 10 May 2022 23:51:17 -0700 (PDT) Received: from ?IPV6:2a0b:e7c0:0:107::70f? ([2a0b:e7c0:0:107::70f]) by smtp.gmail.com with ESMTPSA id r5-20020a05600c424500b003942a244f3asm4242899wmm.19.2022.05.10.23.51.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 May 2022 23:51:17 -0700 (PDT) Message-ID: Date: Wed, 11 May 2022 08:51:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v4 1/1] soc: fujitsu: Add A64FX diagnostic interrupt driver Content-Language: en-US To: Hitomi Hasegawa , linux-arm-kernel@lists.infradead.org, soc@kernel.org, linux-serial@vger.kernel.org, sumit.garg@linaro.org Cc: arnd@arndb.de, olof@lixom.net, catalin.marinas@arm.com, will@kernel.org, gregkh@linuxfoundation.org, jason.wessel@windriver.com, daniel.thompson@linaro.org, dianders@chromium.org, linux-kernel@vger.kernel.org, kgdb-bugreport@lists.sourceforge.net, peterz@infradead.org References: <20220511062113.2645747-1-hasegawa-hitomi@fujitsu.com> <20220511062113.2645747-2-hasegawa-hitomi@fujitsu.com> From: Jiri Slaby In-Reply-To: <20220511062113.2645747-2-hasegawa-hitomi@fujitsu.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11. 05. 22, 8:21, Hitomi Hasegawa wrote: > --- /dev/null > +++ b/drivers/soc/fujitsu/a64fx-diag.c > @@ -0,0 +1,155 @@ ... > +#define BMC_DIAG_INTERRUPT_STATUS_OFFSET (0x0044) > +#define BMC_DIAG_INTERRUPT_ENABLE_OFFSET (0x0040) And I noticed here, I would: * remove unneeded parentheses * drop the "_OFFSET" suffix * just write 8bit values (0x40, 0x44), given they fit * order them numerically, 0x40 goes first thanks, -- js suse labs