Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <21bb1776-6ee9-c32d-0049-cd52b14fd133@bytedance.com>
Date:   Wed, 11 May 2022 08:02:11 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: Re: [PATCH 0/3] nvme: enable smart AEN
Content-Language: en-US
To:     Sagi Grimberg <sagi@grimberg.me>
Cc:     axboe@fb.com, linux-nvme@lists.infradead.org, kbusch@kernel.org,
        hch@lst.de, linux-kernel@vger.kernel.org
References: <20220507065026.260306-1-pizhenwei@bytedance.com>
 <3c233d71-af16-d230-c207-b9c2ae38afbb@grimberg.me>
From:   zhenwei pi <pizhenwei@bytedance.com>
In-Reply-To: <3c233d71-af16-d230-c207-b9c2ae38afbb@grimberg.me>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 5/11/22 03:13, Sagi Grimberg wrote:
> 
>> Hi,
>>
>> There are several changes in this series:
>> - Add missing NVME_SMART_CRIT_PMR_UNRELIABLE enum type.
>> - Add missing NVME_AEN_CFG_SMART_CRIT_* enum types.
>> - Enable smart AEN.
> 
> Is there another side to this patchset? meaning some userland agent
> that listens to these events and does something with these?

I tried to test SMART AEN end to end by QEMU NVMe emulation. I did not 
realize that the SMART AEN CFG is not optional.

Also sent this to QEMU(Klaus corrected me):
https://patchwork.kernel.org/project/qemu-devel/cover/20220507072644.263105-1-pizhenwei@bytedance.com/

-- 
zhenwei pi