Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Lu, Brent" <brent.lu@intel.com>
To:     Terry Chen <terry_chen@wistron.corp-partner.google.com>,
        "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
CC:     "Rojewski, Cezary" <cezary.rojewski@intel.com>,
        "pierre-louis.bossart@linux.intel.com" 
        <pierre-louis.bossart@linux.intel.com>,
        "liam.r.girdwood@linux.intel.com" <liam.r.girdwood@linux.intel.com>,
        "yang.jie@linux.intel.com" <yang.jie@linux.intel.com>,
        "broonie@kernel.org" <broonie@kernel.org>,
        "perex@perex.cz" <perex@perex.cz>,
        "tiwai@suse.com" <tiwai@suse.com>,
        "cujomalainey@chromium.org" <cujomalainey@chromium.org>,
        "seanpaul@chromium.org" <seanpaul@chromium.org>,
        "Bowman, Casey G" <casey.g.bowman@intel.com>,
        "mark_hsieh@wistron.corp-partner.google.com" 
        <mark_hsieh@wistron.corp-partner.google.com>,
        "Gopal, Vamshi Krishna" <vamshi.krishna.gopal@intel.com>,
        "Chiang, Mac" <mac.chiang@intel.com>,
        "kai.vehmanen@linux.intel.com" <kai.vehmanen@linux.intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] [v3]FROMLIST: ASoC: Intel: sof_cs42l42: adding support
 for ADL configuration and BT offload audio
Thread-Topic: [PATCH] [v3]FROMLIST: ASoC: Intel: sof_cs42l42: adding support
 for ADL configuration and BT offload audio
Thread-Index: AQHYZP/rutgSvWVg6E+qvH7tXhu/H60ZPIjw
Date:   Wed, 11 May 2022 06:55:45 +0000
Message-ID: <SA2PR11MB4891262E970A79FCCF3B345597C89@SA2PR11MB4891.namprd11.prod.outlook.com>
References: <20220511062514.1743838-1-terry_chen@wistron.corp-partner.google.com>
In-Reply-To: <20220511062514.1743838-1-terry_chen@wistron.corp-partner.google.com>
Accept-Language: en-US
Content-Language: en-US
dlp-version: 11.6.500.15
dlp-product: dlpe-windows
dlp-reaction: no-action
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?VkY3qcS5MrNgInue/iDU+ImTfaL54fz/SStL3MTC+BCHZyvWGRxB+InD2phS?=
 =?us-ascii?Q?Gv7ggcYVIA//ehAF3LXj5joLkEznp1VN/mzVr9HLtQNSozr2Z8dSZSASyueB?=
 =?us-ascii?Q?pqj0NlcO0QRun6t36dSxmI9kM+DYztCks1YyGxQPOTCmLY1kWmsNtGtDfPna?=
 =?us-ascii?Q?FnGQeL94/KQbxzpePedXtEIIablenZuJlKSWPX4Hzpjcjf5PC81gN3w3jUVJ?=
 =?us-ascii?Q?A/Lboo3RYtwfoxcUH2Np7je67UCuAgTxCSU30REtdJNsCAT8D51TexOTVmT/?=
 =?us-ascii?Q?mai3cH74Gu/BC9/E3vH1JYauJ75L1hheyHUD546p9oqD9kpM7dmDDJbs9TLl?=
 =?us-ascii?Q?BI+tpGyuWDW1K97ynL6hDxsbREiuMcLYtvyRSNFJt533d6Xr5Ylhng9SbEXf?=
 =?us-ascii?Q?yYT3GCUYciLQSTQgi4ltIKynZi3cCbwkPlc3VPRd08bjhyGYjR56pQs5J0MB?=
 =?us-ascii?Q?yvq6CtUhjYqgW1MsXavpeWjru8tchwtaRIu3fdYhGDY/bwSCDT6XNtXDlrjx?=
 =?us-ascii?Q?WUHEwhgqSJdQLcQktpxjbqcz4+DrWUiTOEqlH6Tb1P730JdqzFHVyPgTTJLC?=
 =?us-ascii?Q?U8BLJBg3DJgeyZkNZdmGPUNHNjdUYXUB4jnbmFcmNAKY20T11kcIc/n2I95c?=
 =?us-ascii?Q?AQaNUpb+drDsiU/tdSzwvZHcbRgfYcOu8yW5jceDJ9IAlAWDIk6jl7JxgURu?=
 =?us-ascii?Q?uVEee76c+B0BHP5SfUsGk0O/VInrD4JIO/gy+UfJOCNyb6tsO7vAnzI7VyW/?=
 =?us-ascii?Q?pscGZmo5Ya2UrL9upTNKRbWooeIjvu319u7YV48TMEW8HjTsBDDDL3msgpt4?=
 =?us-ascii?Q?+ObC7ehgMaZITE47ufdUSpuGteQA1S8AutPHEZP6GCh6tP73HzCqJddjpZpv?=
 =?us-ascii?Q?g5eJXYHRb0/4wd7hE/N+RLIl7sTF7CxzDx94Q1DpY41Adfu3S3jD2bPW75Y1?=
 =?us-ascii?Q?tWA61pS4gSyDmujJzf+GwnOqvM54ROmw24DfGvG83vAfA9RjCkYKaVs24M/u?=
 =?us-ascii?Q?AySmQeT+AGxa+sdNrjNW16B7EDSavt6cG84UtL3q2J5MeOZXW6hNq3rXS/lt?=
 =?us-ascii?Q?TKYokMI3H2XzD+HBU+9XhSqrL61bfV6usyTrPSBmJ1BtPnUGuLTDxZ1KyVkp?=
 =?us-ascii?Q?87IhN5r6UI+ytAaZeARkFQsuIZI4frs7NXtyBLD2AxR3QCD8CJS2RuhToEns?=
 =?us-ascii?Q?q6o/sIXFI7iV8vFn81TDpP92xjIZBIvKqDpFcnWbVOcpfthiICM1o5lb6sL8?=
 =?us-ascii?Q?lrtSrA3Kx7yOenRbFeYiOj/0aw3yngJQGERrzdljDjQsRka91NKuvbzCw3mX?=
 =?us-ascii?Q?QFdG2Y6KRdKnYrRGTHUa7Ca4wch6QOeg65tTWxw07LvRZYI/6g/0TLSrWKvZ?=
 =?us-ascii?Q?LQq3KURySU72BfZWyfFnJLUuKmmKkUkpXz3JtOdmEFOMnaOQu3y41/rl7sfy?=
 =?us-ascii?Q?0+9+tW6pe/jCfnCLX8oRwz131vH2KVoUkwvRZKCtjbHpj9fACenSG1eqOqMc?=
 =?us-ascii?Q?OAdEWNbYVYmmW/dSqPSx+43/lJnqz5BLydFHqLGqYavwenBDsO37VhZQr5vB?=
 =?us-ascii?Q?FOGSmFiF7oGxc7hyVbkVkL84OwXmX0yOGz87AZXxHayRvCtzy/7vZ2SxFbF+?=
 =?us-ascii?Q?Zr8v2RK2+sbJEdenTLKenGP6uj9XGcrzNXtiYGpVGPfj5dp1wnPJN5tEVHZA?=
 =?us-ascii?Q?5xDEGdJJv1G7Bve4i2ZegE6aHamw5c0ZuL38L6GnbOgfktPWHW+IYwGv4UW3?=
 =?us-ascii?Q?3XENtjliYA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SA2PR11MB4891.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 79a4f410-9cb6-49ec-5196-08da331b45e4
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 May 2022 06:55:45.5446
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 5q/PClVKX0cHhlL9xOCCmL2G8lxWTYLT3QQrNvG7gsa4WeFwvY76l2kfvjlcaNj6iFsaenSEzrMQGYh6Sr/dJQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3018
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>=20
> +static int create_bt_offload_dai_links(struct device *dev,
> +				       struct snd_soc_dai_link *links,
> +				       struct snd_soc_dai_link_component
> *cpus,
> +				       int *id, int ssp_bt)
> +{
> +	int ret =3D 0;
Unused variable, please remove it.
> +
> +	/* bt offload */
> +	if (!(sof_cs42l42_quirk & SOF_BT_OFFLOAD_PRESENT))
> +		return 0;
> +
> +	links[*id].name =3D devm_kasprintf(dev, GFP_KERNEL, "SSP%d-BT",
> +					 ssp_bt);
> +	if (!links[*id].name) {
> +		ret =3D -ENOMEM;
Remove it, too. And also the brackets.
> +		goto devm_err;
> +	}
> +
> +	links[*id].id =3D *id;
> +	links[*id].codecs =3D dummy_component;
> +	links[*id].num_codecs =3D ARRAY_SIZE(dummy_component);
> +	links[*id].platforms =3D platform_component;
> +	links[*id].num_platforms =3D ARRAY_SIZE(platform_component);
> +
> +	links[*id].dpcm_playback =3D 1;
> +	links[*id].dpcm_capture =3D 1;
> +	links[*id].no_pcm =3D 1;
> +	links[*id].cpus =3D &cpus[*id];
> +	links[*id].num_cpus =3D 1;
> +
> +	links[*id].cpus->dai_name =3D devm_kasprintf(dev, GFP_KERNEL,
> +						   "SSP%d Pin",
> +						   ssp_bt);
> +	if (!links[*id].cpus->dai_name) {
> +		ret =3D -ENOMEM;
Same here.
> +		goto devm_err;
> +	}
> +
> +	(*id)++;
> +
> +	return 0;
> +
> +devm_err:
> +	return -ENOMEM;
> +}
> +

> --- a/sound/soc/intel/common/soc-acpi-intel-adl-match.c
> +++ b/sound/soc/intel/common/soc-acpi-intel-adl-match.c
> @@ -384,6 +384,14 @@ struct snd_soc_acpi_mach
> snd_soc_acpi_intel_adl_machines[] =3D {
>  		.sof_fw_filename =3D "sof-adl.ri",
>  		.sof_tplg_filename =3D "sof-adl-cs35l41.tplg",
>  	},
> +	{
> +		.id =3D "10134242",
> +		.drv_name =3D "adl_mx98360a_cs4242",
> +		.machine_quirk =3D snd_soc_acpi_codec_list,
> +		.quirk_data =3D &adl_max98360a_amp,
> +		.sof_fw_filename =3D "sof-adl.ri",
I remember that the 'sof_fw_filename' has been removed for a while. Please
apply the patch to the for-next branch on the broonie tree. Build the kerne=
l
and make sure there is no error before sending the patch.

Brent