Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp6657821iob; Wed, 11 May 2022 02:28:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx8t7hluqaHrg6t2GmTmXy+TL5HDVaUITSmMpe/EweK/d3yyfZ0OeKkIe6adH26YioMPcHv X-Received: by 2002:a17:907:2da5:b0:6f4:7cd1:8cf5 with SMTP id gt37-20020a1709072da500b006f47cd18cf5mr23995097ejc.328.1652261297805; Wed, 11 May 2022 02:28:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652261297; cv=none; d=google.com; s=arc-20160816; b=tf65QjPZdIt6qW1Y21FVZGCW4/p2o3tzbnL7qHkll0zF0IwHsYnesrMG29kGSbSHxN K8T+1oRDEtO1YymKkfha7qnBz4OU9KKPdVZv0M15BQIbrA9ydaOBdTXzZYswEUtcEobq DCEk3NBDG1NTicLfrZWlJHWkxmDLG4nuCuQmMiymE7ahUsGa2OqejPP3WbPiWAiiOxlp 1Rowm4u7EFGXrgAEkdbgLcSgQj3bxhUf/uwX/5PUrMv8Xu79mCzhWUhbK8kxEDh3qytz M2ATvPOev6bUgXzYl0Sv3r0ZKZygEOTN5c7sL9UyQly2JtFg6m71SuYXbDnI1aMQOYYq SWhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=t6NkPp/fJ68js/PCdUN+2mVyG6GXe+GCTEKHdPawF68=; b=Kmo7o4uro1ydAYdncF0xqefTAKY1zEn/U81mFdfocFSPyRNTVVVYDaLAYdg5ko3UOF u47klPmYCtpZlzDS2oeWDSr3f6rCzN+QJ3dDcvPROQxwD5rRrqyusWR60UpvTWSzZwjx yWdM5bMJ5kQCciLUhp2XBq2OdBuZm0CvvBg031Lj2QTLfjiqTh6sgyGi/GlEMbid34mm uGR/aQ+h1Qn1HB/gymreefoHCAHuyP19HUfUlOQuokyX9RC9FfxvRz1MH8xccPgWef1n rCV0vI2pejN/u33ATo+ulqLX1g5ba9VA/32WC+SRtPhETH9NjmdKvWEV7DCu++zbynMv 4Zfg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id di17-20020a170906731100b006f3a97bb895si1925262ejc.588.2022.05.11.02.27.54; Wed, 11 May 2022 02:28:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242432AbiEKHBl (ORCPT + 99 others); Wed, 11 May 2022 03:01:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43264 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233352AbiEKHBd (ORCPT ); Wed, 11 May 2022 03:01:33 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0356648E40; Wed, 11 May 2022 00:01:32 -0700 (PDT) Received: from kwepemi500015.china.huawei.com (unknown [172.30.72.54]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Kym3475jfzGpcY; Wed, 11 May 2022 14:58:40 +0800 (CST) Received: from huawei.com (10.175.127.227) by kwepemi500015.china.huawei.com (7.221.188.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 11 May 2022 15:01:28 +0800 From: Zheng Bin To: , , , CC: , Subject: [PATCH -next] tty: serial: max3100: Add missing uart_unregister_driver in max3100_probe Date: Wed, 11 May 2022 15:15:23 +0800 Message-ID: <20220511071523.3128725-1-zhengbin13@huawei.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.127.227] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemi500015.china.huawei.com (7.221.188.92) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org max3100_probe misses a call uart_unregister_driver in error path, this patch fixes that. Signed-off-by: Zheng Bin --- drivers/tty/serial/max3100.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/tty/serial/max3100.c b/drivers/tty/serial/max3100.c index 0b5f21fbb53d..6d34ca2a3f7b 100644 --- a/drivers/tty/serial/max3100.c +++ b/drivers/tty/serial/max3100.c @@ -752,6 +752,7 @@ static int max3100_probe(struct spi_device *spi) if (!max3100s[i]) break; if (i == MAX_MAX3100) { + uart_unregister_driver(&max3100_uart_driver); dev_warn(&spi->dev, "too many MAX3100 chips\n"); mutex_unlock(&max3100s_lock); return -ENOMEM; @@ -759,6 +760,7 @@ static int max3100_probe(struct spi_device *spi) max3100s[i] = kzalloc(sizeof(struct max3100_port), GFP_KERNEL); if (!max3100s[i]) { + uart_unregister_driver(&max3100_uart_driver); dev_warn(&spi->dev, "kmalloc for max3100 structure %d failed!\n", i); mutex_unlock(&max3100s_lock); -- 2.31.1