Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d5aecbb9-a897-9423-833f-432907b5be87@molgen.mpg.de>
Date:   Wed, 11 May 2022 08:38:24 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH] md: remove useless INIT_LIST_HEAD()
Content-Language: en-US
To:     Haowen Bai <baihaowen@meizu.com>
Cc:     Song Liu <song@kernel.org>, linux-raid@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <1652237069-11486-1-git-send-email-baihaowen@meizu.com>
From:   Paul Menzel <pmenzel@molgen.mpg.de>
In-Reply-To: <1652237069-11486-1-git-send-email-baihaowen@meizu.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Dear Haowen,


Thank you for your patch.

Am 11.05.22 um 04:44 schrieb Haowen Bai:
> list candidates has been inited staticly through LIST_HEAD,

initialized statically

> so there's no need to call another INIT_LIST_HEAD. Simply remove
> it.

Please reflow for 75 characters per line.

> Signed-off-by: Haowen Bai <baihaowen@meizu.com>
> ---
>   drivers/md/md.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/md/md.c b/drivers/md/md.c
> index 707e802d0082..eb2b23ef5ecc 100644
> --- a/drivers/md/md.c
> +++ b/drivers/md/md.c
> @@ -6491,7 +6491,6 @@ static void autorun_devices(int part)
>   					 struct md_rdev, same_set);
>   
>   		pr_debug("md: considering %s ...\n", bdevname(rdev0->bdev,b));
> -		INIT_LIST_HEAD(&candidates);
>   		rdev_for_each_list(rdev, tmp, &pending_raid_disks)
>   			if (super_90_load(rdev, rdev0, 0) >= 0) {
>   				pr_debug("md:  adding %s ...\n",


Kind regards,

Paul