Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp6660532iob; Wed, 11 May 2022 02:32:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxQ/NGLuwbV+3BCbFZxl8bQBMiUQEiC7OKRTzJdXV2C8nwLKa3eMzc7bxrQQE6zpzq2nu1+ X-Received: by 2002:a17:90b:4ac1:b0:1dc:20c4:6363 with SMTP id mh1-20020a17090b4ac100b001dc20c46363mr4393373pjb.79.1652261526002; Wed, 11 May 2022 02:32:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652261525; cv=none; d=google.com; s=arc-20160816; b=0SKHnxqUK/TZu6XZRaH55BBLFxzoAX8b9iBF+kQ4JrJEBhoUswWQsIqN9X21OFKSlL GNxm3wEHmZ2GMU/cnKetavBry7dWDsR+cwQUL5zcnY95lrmRN6ocUdp/BaOVTkQO/paP 0E4NndZTnDgZK/sgz+wkn8JGjIDDTv/VQzrV/noFnHvZDyOviaVxvTg5RwpWMqP+G28J rGeUbs/yMWs2yATwRmMztOE6P9I+rA+mocMAbm+yd+RmuFV3pB87tAXYUF21kq5PH/2A Sdw5DB0FISndsuxOequj51DxAo3r2AeTF8AOkkddPl4sBZYNwOo05Kh2lClWA95B3VAd NU4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from; bh=7AQ9pDgmUR3/5GMyR8/qw5HmgtauCGUA6F4/hdOHZ/Y=; b=ms6KFVHGdQlJWZntbkINx6hml+UMnzw2yAoqa32sXnofmDJWOKPzYz2pHjEJEh/ZZE JNIE17Kc2xM3smoc5zj/Dum+xmOlo43XF/6zNGbK8sPJ6NkLanzagCl/OX3Z+pp6zSvF /xPZGHMhnXIxlemDe7SOKChHWQ3GKJPkh44H2ETyyg62an+IRSk/8H4OmrWwrkz9rAnq hzIIKisfyugviNb4H8AJyk7+Z36YB2No0JcPYi5R1tWlbdJxEa+hibK4lzXk3mA+Hkuc vL/wF8jgHq4TyYEpPTT0JRkzCt0ATRw1u8Ht0VbUXwpC1cH+RSeSCu/3TjgZa4rTzBSL 2weA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p10-20020a635b0a000000b003c62592bfadsi2065353pgb.805.2022.05.11.02.31.49; Wed, 11 May 2022 02:32:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241315AbiEKHSd (ORCPT + 99 others); Wed, 11 May 2022 03:18:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53064 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232103AbiEKHSa (ORCPT ); Wed, 11 May 2022 03:18:30 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 24931E15EA; Wed, 11 May 2022 00:18:28 -0700 (PDT) Received: from dggpeml500024.china.huawei.com (unknown [172.30.72.54]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4KymTK6TpYzbngy; Wed, 11 May 2022 15:17:57 +0800 (CST) Received: from huawei.com (10.175.112.208) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 11 May 2022 15:18:25 +0800 From: Yuan Can To: CC: , , , , Subject: [PATCH] rtc: gamecube: Add missing iounmap in gamecube_rtc_read_offset_from_sram Date: Wed, 11 May 2022 07:13:54 +0000 Message-ID: <20220511071354.46202-1-yuancan@huawei.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.175.112.208] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpeml500024.china.huawei.com (7.185.36.10) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The hw_srnprot needs to be unmapped when gamecube_rtc_read_offset_from_sram returns. Fixs: 86559400b3ef9d (rtc: gamecube: Add a RTC driver for the GameCube, Wii and Wii U) Signed-off-by: Yuan Can --- drivers/rtc/rtc-gamecube.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/rtc/rtc-gamecube.c b/drivers/rtc/rtc-gamecube.c index 18ca3b38b2d0..c2717bb52b2b 100644 --- a/drivers/rtc/rtc-gamecube.c +++ b/drivers/rtc/rtc-gamecube.c @@ -267,6 +267,7 @@ static int gamecube_rtc_read_offset_from_sram(struct priv *d) ret = regmap_read(d->regmap, RTC_SRAM_BIAS, &d->rtc_bias); if (ret) { pr_err("failed to get the RTC bias\n"); + iounmap(hw_srnprot); return -1; } -- 2.17.1