Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 11 May 2022 09:16:43 +0200
From:   Miquel Raynal <miquel.raynal@bootlin.com>
To:     Mikhail Zhilkin <csharper2005@gmail.com>
Cc:     Richard Weinberger <richard@nod.at>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        Rob Herring <robh+dt@kernel.org>,
        NOGUCHI Hiroshi <drvlabo@gmail.com>,
        Hauke Mehrtens <hauke@hauke-m.de>,
        Karim <Karimdplay@gmail.com>, M <x1@disroot.org>,
        linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org
Subject: Re: [PATCH] mtd: parsers: add support for Sercomm partitions
Message-ID: <20220511091643.064f9d13@xps13>
In-Reply-To: <ede9e050-3b60-ba0e-c626-044f7825adb7@gmail.com>
References: <20220329122016.4122899-1-csharper2005@gmail.com>
        <20220330100958.57dc4d61@xps13>
        <ede9e050-3b60-ba0e-c626-044f7825adb7@gmail.com>
Organization: Bootlin
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Mikhail,

csharper2005@gmail.com wrote on Tue, 10 May 2022 23:07:23 +0300:

> Hi Miquel,
>=20
> On 3/30/2022 11:09 AM, Miquel Raynal wrote:
> > Hi Mikhail,
> >
> > csharper2005@gmail.com wrote on Tue, 29 Mar 2022 12:20:16 +0000:
> > =20
> >> This adds an MTD partition parser for the Sercomm partition table that
> >> is used in some Beeline, Netgear and Sercomm routers.
> >>
> >> The Sercomm partition map table contains real partition offsets, which
> >> may differ from device to device depending on the number and location =
of
> >> bad blocks on NAND.
> >>
> >> Device tree example:
> >> partitions {
> >> 	compatible =3D "sercomm,sc-partitions", "fixed-partitions";
> >> 	#address-cells =3D <1>;
> >> 	#size-cells =3D <1>;
> >>
> >> 	partition@0 {
> >> 		label =3D "u-boot";
> >> 		reg =3D <0x0 0x100000>;
> >> 		scpart-id =3D <0>;
> >> 		read-only;
> >> 	};
> >> }; =20
> > You'll need a DT binding patch and Rob's ack! =20
>=20
> I hope that I near to finish with DT binding...
>=20
> Link:
> https://lore.kernel.org/all/20220510162314.20810-1-csharper2005@gmail.com/
>=20
> Link:
> https://lore.kernel.org/all/20220510162403.20861-1-csharper2005@gmail.com/
>=20
> >> This is essentially the same code as proposed by NOGUCHI Hiroshi
> >> <drvlabo@gmail.com> here: =20
> > I would credit Hiroshi with a Suggested-by at least =20
>=20
> I read submitting patches rules again and thought that Signed-off-by is
> suitable for this case. Is this ok?

Either you take his work almost like it is and he must be the author
*and* the first signed-off-by line, or you take the authorship if you
think you did enough modifications to the code and in this case you can
either credit him with a suggested-by before your signed-off, or you
can credit him with a co-developed-by + his signed-off and then yours.

>=20
> Link:
> https://lore.kernel.org/all/20220510162655.21011-1-csharper2005@gmail.com/
>=20
> >> https://github.com/openwrt/openwrt/pull/1318#issuecomment-420607394 =20
> > And use a Link: tag for this.
> > =20
> Fixed, thanks!
>=20
> Link:
> https://lore.kernel.org/all/20220510162655.21011-1-csharper2005@gmail.com/
>=20
> > Thanks,
> > Miqu=C3=A8l =20


Thanks,
Miqu=C3=A8l