Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <278d1d30-a7ad-11df-5242-5472a841a3b3@linux.alibaba.com>
Date:   Wed, 11 May 2022 09:24:09 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH 1/2] arm64/hugetlb: Use ptep_get() to get the pte value of
 a huge page
To:     Muchun Song <songmuchun@bytedance.com>
Cc:     catalin.marinas@arm.com, will@kernel.org, mike.kravetz@oracle.com,
        akpm@linux-foundation.org, willy@infradead.org,
        anshuman.khandual@arm.com, christophe.leroy@csgroup.eu,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-mm@kvack.org
References: <cover.1652180088.git.baolin.wang@linux.alibaba.com>
 <6aabddaf4cae5ae2205c3a7df9b9e15dbd61b641.1652180088.git.baolin.wang@linux.alibaba.com>
 <YnqK+Hah0wzMvT1p@FVFYT0MHHV2J.usts.net>
From:   Baolin Wang <baolin.wang@linux.alibaba.com>
In-Reply-To: <YnqK+Hah0wzMvT1p@FVFYT0MHHV2J.usts.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 5/10/2022 11:55 PM, Muchun Song wrote:
> On Tue, May 10, 2022 at 07:12:52PM +0800, Baolin Wang wrote:
>> The original huge_ptep_get() on ARM64 is just a wrapper of ptep_get(),
>> which will not take into account any contig-PTEs dirty and access bits.
>> Meanwhile we will implement a new ARM64-specific huge_ptep_get()
>> interface in following patch, which will take into account any contig-PTEs
>> dirty and access bits and only be allowed to pass the head pte of
>> a contig-PTE/PMD size page.
> 
> IIUC, the huge_ptep_get() you have implemented in patch 2 could
> handle non-head pte. It'll return the original pte without potential
> AD bit. I admit it is more efficeent to use ptep_get() directly,
> but the judgement here should be updated.

Ah, right. I missed the 'ncontig' will be 0 if a non-head pte passed. 
Will update the commit message in next version. Thanks for reviewing.

> 
> With this update.
> 
> Reviewed-by: Muchun Song <songmuchun@bytedance.com>