Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 11 May 2022 09:09:55 +0100
Message-ID: <8735hg7ang.wl-maz@kernel.org>
From:   Marc Zyngier <maz@kernel.org>
To:     Antonio Borneo <antonio.borneo@foss.st.com>
Cc:     Thomas Gleixner <tglx@linutronix.de>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        <linux-kernel@vger.kernel.org>,
        <linux-stm32@st-md-mailman.stormreply.com>,
        <linux-arm-kernel@lists.infradead.org>,
        Ludovic Barre <ludovic.barre@foss.st.com>,
        Loic Pallardy <loic.pallardy@foss.st.com>,
        Pascal Paillet <p.paillet@foss.st.com>
Subject: Re: [PATCH 1/7] irqchip/stm32-exti: set_affinity return IRQ_SET_MASK_OK_DONE if no parent
In-Reply-To: <05d9a88de4a7c415545043fab1e577e7f6151b8c.camel@foss.st.com>
References: <20220510164123.557921-1-antonio.borneo@foss.st.com>
        <878rr96xuo.wl-maz@kernel.org>
        <05d9a88de4a7c415545043fab1e577e7f6151b8c.camel@foss.st.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue)
 FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1
 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, 11 May 2022 07:39:43 +0100,
Antonio Borneo <antonio.borneo@foss.st.com> wrote:
>=20
> Hi Marc,
>=20
> On Tue, 2022-05-10 at 19:34 +0100, Marc Zyngier wrote:
> > Antonio,
> >=20
> > On Tue, 10 May 2022 17:41:17 +0100,
> > Antonio Borneo <antonio.borneo@foss.st.com> wrote:
> > >=20
> > > From: Ludovic Barre <ludovic.barre@foss.st.com>
> > >=20
> > > If no parent, there is no specific action to do in
> > > stm32 irqchip, and so return IRQ_SET_MASK_OK_DONE.
> > >=20
> > > Signed-off-by: Ludovic Barre <ludovic.barre@foss.st.com>
> > > Signed-off-by: Antonio Borneo <antonio.borneo@foss.st.com>
> > > ---
> > > =C2=A0drivers/irqchip/irq-stm32-exti.c | 2 +-
> > > =C2=A01 file changed, 1 insertion(+), 1 deletion(-)
> > >=20
> > > diff --git a/drivers/irqchip/irq-stm32-exti.c
> > > b/drivers/irqchip/irq-stm32-exti.c
> > > index 9d18f47040eb..10c9c742c216 100644
> > > --- a/drivers/irqchip/irq-stm32-exti.c
> > > +++ b/drivers/irqchip/irq-stm32-exti.c
> > > @@ -614,7 +614,7 @@ static int stm32_exti_h_set_affinity(struct
> > > irq_data *d,
> > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0if (d->parent_data->c=
hip)
> > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0return irq_chip_set_affinity_parent(d, dest,
> > > force);
> > > =C2=A0
> > > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0return -EINVAL;
> > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0return IRQ_SET_MASK_OK_DON=
E;
> > > =C2=A0}
> > > =C2=A0
> > > =C2=A0static int __maybe_unused stm32_exti_h_suspend(void)
> >=20
> > <rant>
> > Can you *please* use a cover-letter when sending more that a single
> > patch? I expect there is an overarching motive to this series. Where
> > is it described?
> >=20
> > Also, please look at the way the subject lines are written for most
> > irqchip patches:
> >=20
> > irqchip/foo: Frobify the bar callback return value
> >=20
> > Note the capital letter after the ':', and the fact that it starts
> > with a verb. Here, I would have liked to see:
> >=20
> > irqchip/stm32-exti: Fix set_affinity() return value
> >=20
> > and leave the meat of the description to the commit log (instead of
> > saying the exact same thing twice).
> > </rant>
>=20
> thanks for your review and the hints on this series.
> I will shortly send a V2.

No rush. I'm about to close the 5.19 irqchip tree.

Thanks,

	M.

--=20
Without deviation from the norm, progress is not possible.