Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7aceb944-4c53-8cc8-473d-fc8a9da0ef11@bytedance.com>
Date:   Wed, 11 May 2022 16:18:16 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: Re: [PATCH v2 5/5] mm/memory-failure.c: simplify
 num_poisoned_pages_inc/dec
Content-Language: en-US
To:     =?UTF-8?B?SE9SSUdVQ0hJIE5BT1lBKOWggOWPoyDnm7TkuZ8p?= 
        <naoya.horiguchi@nec.com>
Cc:     "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <20220509105641.491313-1-pizhenwei@bytedance.com>
 <20220509105641.491313-6-pizhenwei@bytedance.com>
 <20220511082011.GC211620@hori.linux.bs1.fc.nec.co.jp>
From:   zhenwei pi <pizhenwei@bytedance.com>
In-Reply-To: <20220511082011.GC211620@hori.linux.bs1.fc.nec.co.jp>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 5/11/22 16:20, HORIGUCHI NAOYA(堀口 直也) wrote:
> On Mon, May 09, 2022 at 06:56:41PM +0800, zhenwei pi wrote:
>> Originally, do num_poisoned_pages_inc() in memory failure routine,
>> use num_poisoned_pages_dec() to rollback the number if filtered/
>> cancelled.
>>
>> Suggested by Naoya, do num_poisoned_pages_inc() only in
>> action_result(), this make this clear and simple.
>>
>> Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
> 
> I found that action_result(MF_MSG_UNKNOWN) in try_memory_failure_hugetlb()
> does not follow the rule, so that could break the counter.
> I don't think this is the issue in your patch, so I'm fine with this patch.
> 
> I'll submit a fix later for this, which will add hugetlb_set_page_hwpoison()
> in the path.  That will have a bit non-trivial change because we need do
> this in hugeltb_lock.
> 
> Anyway, thank you for this work.
> 
> Acked-by: Naoya Horiguchi <naoya.horiguchi@nec.com>

A million thanks to you!

-- 
zhenwei pi