Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220510131136.1103-1-mario.limonciello@amd.com>
In-Reply-To: <20220510131136.1103-1-mario.limonciello@amd.com>
From:   Jian-Hong Pan <jhp@endlessos.org>
Date:   Wed, 11 May 2022 10:39:25 +0800
Message-ID: <CAPpJ_efn1YiLRtbhNwDEr8j+jJfZrHBM9fukDJpuH0czJpgRTQ@mail.gmail.com>
Subject: Re: [PATCH] ACPI: PM: Block ASUS B1400CEAE from suspend to idle by default
To:     Mario Limonciello <mario.limonciello@amd.com>
Cc:     "Rafael J. Wysocki" <rafael@kernel.org>,
        Len Brown <lenb@kernel.org>,
        "open list:ACPI" <linux-acpi@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Mario Limonciello <mario.limonciello@amd.com> =E6=96=BC 2022=E5=B9=B45=E6=
=9C=8810=E6=97=A5 =E9=80=B1=E4=BA=8C =E4=B8=8B=E5=8D=889:11=E5=AF=AB=E9=81=
=93=EF=BC=9A
>
> ASUS B1400CEAE fails to resume from suspend to idle by default.  This was
> bisected back to commit df4f9bc4fb9c ("nvme-pci: add support for ACPI
> StorageD3Enable property") but this is a red herring to the problem.
>
> Before this commit the system wasn't getting into deepest sleep state.
> Presumably this commit is allowing entry into deepest sleep state as
> advertised by firmware, but there are some other problems related to
> the wakeup.
>
> As it is confirmed the system works properly with S3, set the default for
> this system to S3.
>
> Reported-by: Jian-Hong Pan <jhp@endlessos.org>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=3D215742
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
>  drivers/acpi/sleep.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
>
> diff --git a/drivers/acpi/sleep.c b/drivers/acpi/sleep.c
> index c992e57b2c79..3147702710af 100644
> --- a/drivers/acpi/sleep.c
> +++ b/drivers/acpi/sleep.c
> @@ -373,6 +373,18 @@ static const struct dmi_system_id acpisleep_dmi_tabl=
e[] __initconst =3D {
>                 DMI_MATCH(DMI_PRODUCT_NAME, "20GGA00L00"),
>                 },
>         },
> +       /*
> +        * ASUS B1400CEAE hangs on resume from suspend (see
> +        * https://bugzilla.kernel.org/show_bug.cgi?id=3D215742).
> +        */
> +       {
> +       .callback =3D init_default_s3,
> +       .ident =3D "ASUS B1400CEAE",
> +       .matches =3D {
> +               DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> +               DMI_MATCH(DMI_PRODUCT_NAME, "ASUS EXPERTBOOK B1400CEAE"),
> +               },
> +       },
>         {},
>  };
>
> --
> 2.34.1
>

Tested-by: Jian-Hong Pan <jhp@endlessos.org>