Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220510100328.9191-1-warp5tw@gmail.com> <20220510100328.9191-2-warp5tw@gmail.com>
 <28029d30-6d18-d28c-a7d2-d86b9ab9ad35@linaro.org> <CACD3sJa6qEPDD58NqiXJ+hHHSSbB6BRqEPXuX+m49ei8HrHF+g@mail.gmail.com>
In-Reply-To: <CACD3sJa6qEPDD58NqiXJ+hHHSSbB6BRqEPXuX+m49ei8HrHF+g@mail.gmail.com>
From:   Tyrone Ting <warp5tw@gmail.com>
Date:   Wed, 11 May 2022 08:28:40 +0800
Message-ID: <CACD3sJa2qdocMXX3QFj5OdjFGd95M5nArJqPpEMjCYmb2ZvgHA@mail.gmail.com>
Subject: Re: [PATCH v4 1/9] dt-bindings: i2c: npcm: support NPCM845
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        avifishman70@gmail.com, Tomer Maimon <tmaimon77@gmail.com>,
        Tali Perry <tali.perry1@gmail.com>,
        Patrick Venture <venture@google.com>,
        Nancy Yuen <yuenn@google.com>,
        Benjamin Fair <benjaminfair@google.com>, robh+dt@kernel.org,
        Wolfram Sang <wsa@kernel.org>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        jarkko.nikula@linux.intel.com, semen.protsenko@linaro.org,
        sven@svenpeter.dev, jsd@semihalf.com, lukas.bulwahn@gmail.com,
        olof@lixom.net, arnd@arndb.de, Tyrone Ting <warp5tw@gmail.com>,
        tali.perry@nuvoton.com, Avi.Fishman@nuvoton.com,
        tomer.maimon@nuvoton.com, KWLIU@nuvoton.com, JJLIU0@nuvoton.com,
        kfting <kfting@nuvoton.com>
Cc:     openbmc@lists.ozlabs.org, linux-i2c@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Tyrone Ting <warp5tw@gmail.com> =E6=96=BC 2022=E5=B9=B45=E6=9C=8811=E6=97=
=A5 =E9=80=B1=E4=B8=89 =E4=B8=8A=E5=8D=888:25=E5=AF=AB=E9=81=93=EF=BC=9A
>
> Hi Krzysztof:
>
> Thank you for your review and it will be addressed.
>
> Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> =E6=96=BC 2022=E5=B9=
=B45=E6=9C=8810=E6=97=A5 =E9=80=B1=E4=BA=8C =E4=B8=8B=E5=8D=886:59=E5=AF=AB=
=E9=81=93=EF=BC=9A
> >
> > On 10/05/2022 12:03, Tyrone Ting wrote:
> > >
> > >  maintainers:
> > >    - Tali Perry <tali.perry1@gmail.com>
> > >
> > >  properties:
> > >    compatible:
> > > -    const: nuvoton,npcm750-i2c
> > > +    enum:
> > > +      - nuvoton,npcm750-i2c
> > > +      - nuvoton,npcm845-i2c
> > >
> > >    reg:
> > >      maxItems: 1
> > > @@ -36,6 +37,10 @@ properties:
> > >      default: 100000
> > >      enum: [100000, 400000, 1000000]
> > >
> > > +  nuvoton,sys-mgr:
> > > +    $ref: "/schemas/types.yaml#/definitions/phandle"
> >
> > Minor nit: No quotes. The other places don't have it.
> >
> >
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >
> >
> > Best regards,
> > Krzysztof
>
> Best regards,
> Tyrone