Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <05d9a88de4a7c415545043fab1e577e7f6151b8c.camel@foss.st.com>
Subject: Re: [PATCH 1/7] irqchip/stm32-exti: set_affinity return
 IRQ_SET_MASK_OK_DONE if no parent
From:   Antonio Borneo <antonio.borneo@foss.st.com>
To:     Marc Zyngier <maz@kernel.org>
CC:     Thomas Gleixner <tglx@linutronix.de>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        <linux-kernel@vger.kernel.org>,
        <linux-stm32@st-md-mailman.stormreply.com>,
        <linux-arm-kernel@lists.infradead.org>,
        Ludovic Barre <ludovic.barre@foss.st.com>,
        Loic Pallardy <loic.pallardy@foss.st.com>,
        Pascal Paillet <p.paillet@foss.st.com>
In-Reply-To: <878rr96xuo.wl-maz@kernel.org>
References: <20220510164123.557921-1-antonio.borneo@foss.st.com>
         <878rr96xuo.wl-maz@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Date:   Wed, 11 May 2022 08:39:43 +0200
MIME-Version: 1.0
User-Agent: Evolution 3.44.1 
Precedence: bulk

Hi Marc,

On Tue, 2022-05-10 at 19:34 +0100, Marc Zyngier wrote:
> Antonio,
>=20
> On Tue, 10 May 2022 17:41:17 +0100,
> Antonio Borneo <antonio.borneo@foss.st.com> wrote:
> >=20
> > From: Ludovic Barre <ludovic.barre@foss.st.com>
> >=20
> > If no parent, there is no specific action to do in
> > stm32 irqchip, and so return IRQ_SET_MASK_OK_DONE.
> >=20
> > Signed-off-by: Ludovic Barre <ludovic.barre@foss.st.com>
> > Signed-off-by: Antonio Borneo <antonio.borneo@foss.st.com>
> > ---
> > =C2=A0drivers/irqchip/irq-stm32-exti.c | 2 +-
> > =C2=A01 file changed, 1 insertion(+), 1 deletion(-)
> >=20
> > diff --git a/drivers/irqchip/irq-stm32-exti.c
> > b/drivers/irqchip/irq-stm32-exti.c
> > index 9d18f47040eb..10c9c742c216 100644
> > --- a/drivers/irqchip/irq-stm32-exti.c
> > +++ b/drivers/irqchip/irq-stm32-exti.c
> > @@ -614,7 +614,7 @@ static int stm32_exti_h_set_affinity(struct
> > irq_data *d,
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0if (d->parent_data->chi=
p)
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0return irq_chip_set_affinity_parent(d, dest,
> > force);
> > =C2=A0
> > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0return -EINVAL;
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0return IRQ_SET_MASK_OK_DONE;
> > =C2=A0}
> > =C2=A0
> > =C2=A0static int __maybe_unused stm32_exti_h_suspend(void)
>=20
> <rant>
> Can you *please* use a cover-letter when sending more that a single
> patch? I expect there is an overarching motive to this series. Where
> is it described?
>=20
> Also, please look at the way the subject lines are written for most
> irqchip patches:
>=20
> irqchip/foo: Frobify the bar callback return value
>=20
> Note the capital letter after the ':', and the fact that it starts
> with a verb. Here, I would have liked to see:
>=20
> irqchip/stm32-exti: Fix set_affinity() return value
>=20
> and leave the meat of the description to the commit log (instead of
> saying the exact same thing twice).
> </rant>

thanks for your review and the hints on this series.
I will shortly send a V2.

Regards,
Antonio