Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220510080533.51032-1-yiyang13@huawei.com>
In-Reply-To: <20220510080533.51032-1-yiyang13@huawei.com>
From:   Max Filippov <jcmvbkbc@gmail.com>
Date:   Wed, 11 May 2022 02:04:02 -0700
Message-ID: <CAMo8BfJr1jSr-K8tOFb6Qkco1L1om2oP30rKt2X+RdCQgOWKSw@mail.gmail.com>
Subject: Re: [PATCH -next] xtensa/simdisk: fix error handling in proc_read_simdisk()
To:     Yi Yang <yiyang13@huawei.com>
Cc:     Chris Zankel <chris@zankel.net>, Al Viro <viro@zeniv.linux.org.uk>,
        "open list:TENSILICA XTENSA PORT (xtensa)" 
        <linux-xtensa@linux-xtensa.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Jens Axboe <axboe@kernel.dk>, wangweiyang2@huawei.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Yi,

On Tue, May 10, 2022 at 1:07 AM Yi Yang <yiyang13@huawei.com> wrote:
>
> The frist simple_read_from_buffer() will change ppos. if ppos >= 1.
> The second simple_read_from_buffer() will does not work and return 0.
>
> Fixes: a69755b18774 ("xtensa simdisk: switch to proc_create_data()")
> Signed-off-by: Yi Yang <yiyang13@huawei.com>
> ---
>  arch/xtensa/platforms/iss/simdisk.c | 18 +++++++++++++-----
>  1 file changed, 13 insertions(+), 5 deletions(-)

Thank you for the fix. I've rearranged the patch a bit, expanding the commit
message and fixing the build warning that it introduced and have posted v2.
If there's no objections to it I'll add it to my xtensa tree.

-- 
Thanks.
-- Max