Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
IronPort-SDR: KxjJQLqQGusJyqhrTXrzzKdHcykNSQpgCafWiv7qeSr4sFBqtshLPqrNkutXWqtiapzBrtG4pp
 /Q/ZYHuyzS3zU/MdYoJolAA5R3GkHpEFGNdMiTiLq5D1IOF+6C7mAKEKieM3thCZVBsycGPort
 v9osfcTm6Hl1AAUTivFGoNJ0tgX8eaHvhUWIf7KPhdDm7XvsQ1XnHsGNbUIoZfPLSvN4IUNelP
 hVZsAb6nlLOujW7dMTWuyFEVL2J5/fPTNxMMusy0PTJ2W5uw1EvxHTt//s/r6TuC7/8YG8fhxW
 8eYzk9QBZ8tKIipiOYGTXk3Y
IronPort-SDR: 6lsCvq1HWaPv/ykdIDYIxRuXSsN7O+QjwvT8zndQdEbJVOh1s7PQh1wWvhDaC7WYHRAc9yPadJ
 ndVGFubImyJyb3FLmQT2XuJr5KWblZplEbkCfS786Sc0eF2d4q2T5WUUs35l3TCt2FzGyy95iH
 vvChvKzhPnxN3HSLmNVbThKnw+XK+pIE7xIzQPKT1+rTY+8lVQE+tNcWMIkfgdo6Im8gr0bFh2
 ToF6jqyqOYPGh/rnvaujgKafMceswijr2WAIg175omX19smDSSrRUN9UzvbRR5Jhuv1LTSfJDm
 Db8=
WDCIronportException: Internal
Message-ID: <6122a113-9ea2-c3b3-153d-dac1f6a38dbb@opensource.wdc.com>
Date:   Wed, 11 May 2022 09:36:36 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.9.0
Subject: Re: [PATCH] ata: pata_octeon_cf: Fix refcount leak in octeon_cf_probe
Content-Language: en-US
To:     Miaoqian Lin <linmq006@gmail.com>,
        Sergey Shtylyov <s.shtylyov@omp.ru>,
        Jeff Garzik <jgarzik@redhat.com>,
        David Daney <david.daney@cavium.com>,
        linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220511062723.56652-1-linmq006@gmail.com>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <20220511062723.56652-1-linmq006@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2022/05/11 8:27, Miaoqian Lin wrote:
> of_find_device_by_node() takes reference, we should use put_device()
> to release it when not need anymore.
> Add missing put_device() in error path to avoid refcount
> leak.
> 
> Fixes: 43f01da0f279 ("MIPS/OCTEON/ata: Convert pata_octeon_cf.c to use device tree.")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> ---
>  drivers/ata/pata_octeon_cf.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/ata/pata_octeon_cf.c b/drivers/ata/pata_octeon_cf.c
> index 6b5ed3046b44..65688459acf1 100644
> --- a/drivers/ata/pata_octeon_cf.c
> +++ b/drivers/ata/pata_octeon_cf.c
> @@ -857,12 +857,14 @@ static int octeon_cf_probe(struct platform_device *pdev)
>  				res_dma = platform_get_resource(dma_dev, IORESOURCE_MEM, 0);
>  				if (!res_dma) {
>  					of_node_put(dma_node);
> +					put_device(&dma_dev->dev);
>  					return -EINVAL;
>  				}
>  				cf_port->dma_base = (u64)devm_ioremap(&pdev->dev, res_dma->start,
>  									 resource_size(res_dma));
>  				if (!cf_port->dma_base) {
>  					of_node_put(dma_node);
> +					put_device(&dma_dev->dev);
>  					return -EINVAL;
>  				}
>  

The extra reference should also be dropped at the end of the "if (dma_node)"
too, no ? Otherwise, early returns due to errors after that "if (dma_node)" will
also leak the extra ref.

Note that looking around at places where of_find_device_by_node() is being used,
very few users call put_device()... Looks like there are lots of device ref
leaks with that.

-- 
Damien Le Moal
Western Digital Research