Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762727AbXELCed (ORCPT ); Fri, 11 May 2007 22:34:33 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756263AbXELCe1 (ORCPT ); Fri, 11 May 2007 22:34:27 -0400 Received: from rhun.apana.org.au ([64.62.148.172]:3210 "EHLO arnor.apana.org.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755745AbXELCe0 (ORCPT ); Fri, 11 May 2007 22:34:26 -0400 From: Herbert Xu To: bhalevy@panasas.com (Benny Halevy) Subject: Re: [PATCH 1/12] crypto: don't pollute the global namespace with sg_next() Cc: jens.axboe@oracle.com, linux-kernel@vger.kernel.org Organization: Core In-Reply-To: <4643FD1C.1040401@panasas.com> X-Newsgroups: apana.lists.os.linux.kernel User-Agent: tin/1.7.4-20040225 ("Benbecula") (UNIX) (Linux/2.6.17-rc4 (i686)) Message-Id: Date: Sat, 12 May 2007 12:34:12 +1000 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1157 Lines: 27 Benny Halevy wrote: > > I was trying to say that the methods should be compatible, otherwise > bugs can happen, and that your scheme is better since it can > handle sglists with zero length entries that aren't the last. > A case that might be valid after dma mapping and merging. > If indeed this case is possible, this seems to be the right time > to converge to your scheme. Well right now this isn't possible because the crypto layer is not directly hooked to any DMA code since it's (mostly) software only. However, I completely agree that it should be converted to this new scheme. The only user of chaining right now is crypto/hmac.c so it should be easy to fix. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/