Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp86363iob; Wed, 11 May 2022 10:04:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwpNFWCOPBkG/728N3zghWwCh8TrY0UrujfpzvqdI+kSUU94CzOeLzVQ6nvsi/UzJJB8R6P X-Received: by 2002:a05:6808:148e:b0:326:abe8:af49 with SMTP id e14-20020a056808148e00b00326abe8af49mr3134855oiw.73.1652288639914; Wed, 11 May 2022 10:03:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652288639; cv=none; d=google.com; s=arc-20160816; b=j5wqp+n8fKYowzGV0DUmrQ17/IjmnbTIctSpsdKabKdg4fFHqK4PgNgu4TX1YQF7+T egkc5AWn1GSh+3ZkPN26+6+f3vcp3CcgHajJ416ql0Fa0Qm8kgkBTqKjRZ885vZGXdJI WdLHBnU5pUPL4Z5u35pTbi/pNkOvH7JqF3R6OIM6/g9L7+LLgiTicwOoNc0EvgDZXh8C pZelY/H2tOmyDXTdWWIiNzW3AAFe29HV2nlAU5mBsMweCCoJY077jTI6cUnTuqsyqvjS NsTtz35QEbd11JhU24/6FpO/lvKQfWaiMIgeUyA0N4QzAe5qW/znNIZ++4Wb5vIaD3mJ u24g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:mime-version :in-reply-to:references:user-agent:from:dkim-signature; bh=54jTwdZuall9EISUXsYNKQXDSMcFIE/XxoLsq2jSwtY=; b=uPHh+0ADDEGekZ0kZlu/c9aEPsH0kb+WQoyNfojiDBHfqQmWUgBmp/IxHuBdYWSbDK HjEPuuPAf+YTyt3hN75owvcmkM1ALP5YLXdMGZrZKpIuVPv3K2UKzRDfuOGjnbScMxfy 4ksi4SpHkel+6vpo1658dPAQ5nYqRt/boBu0fYk06DjMdKaaWO26Psv0CY0dPJurJFlv e/9Tt59Utt5DFXV3yNoN33lO+Q1ijE2odTEkD3PwCgmLL/vPgwacZ3uay+ALwMJ6Q8ug kZ+87xB3gGMsJ/TzfYn8G777zf2e+UbLnjeqn4+Fv9e+pEeTSkK3daCeF2hoHEVivOYk w4MQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20210112.gappssmtp.com header.s=20210112 header.b=xKNztW30; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m20-20020a0568080f1400b002ef0c347627si2765057oiw.167.2022.05.11.10.03.45; Wed, 11 May 2022 10:03:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20210112.gappssmtp.com header.s=20210112 header.b=xKNztW30; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242980AbiEKM7f (ORCPT + 99 others); Wed, 11 May 2022 08:59:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60300 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242923AbiEKM7T (ORCPT ); Wed, 11 May 2022 08:59:19 -0400 Received: from mail-vs1-xe2e.google.com (mail-vs1-xe2e.google.com [IPv6:2607:f8b0:4864:20::e2e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 48D94231CB1 for ; Wed, 11 May 2022 05:59:15 -0700 (PDT) Received: by mail-vs1-xe2e.google.com with SMTP id i186so1885063vsc.9 for ; Wed, 11 May 2022 05:59:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=from:user-agent:references:in-reply-to:mime-version:date:message-id :subject:to:cc; bh=54jTwdZuall9EISUXsYNKQXDSMcFIE/XxoLsq2jSwtY=; b=xKNztW30x/vSourm8aBcuql/OIHo9U0NTRi1ieR6M2L96rA4fQg+N03qgYsLaKBp3Q L0WbRrzd0RfFx55mLaqR0zGOqT5zFf5ZdE59M/oAa8nVPMScH22aZhWG7tfquY787L03 SvvYuaz2BtIDeQQGwAF3c8ix6rHyqZIFyt+PUU78lyDaxOr5dPIjyejcERZHULUUUX8V i5j4K5LvtODdjPpQnBNBZe2s0ykQJhLWig6QhlV+a2u5hEmD71VURlYQJmPq2GSpg1nb 4h0HHPPWh9JfNWFO7ZFHW/uGNUCvaXK6OmJ3pNVW9i7gVj7EgvVtRMqEaE5oOSHAHgrb mTiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:user-agent:references:in-reply-to :mime-version:date:message-id:subject:to:cc; bh=54jTwdZuall9EISUXsYNKQXDSMcFIE/XxoLsq2jSwtY=; b=PxhGY18rQHgl8Ic7CEMgu6jdaVeQyAepQuKljVX5j+GRHVT2gkFt0KPzYjuUNKr1gT pCdKeQOOKVPrrhiuPSe4PqvG4JkYz+DSjyiAqCHSXA6PuLwb2UyLTU2GR/SZp7CRIkkh FXUN7Z/sRfxEZZ8KNW//QPF9Cc9eU2hv3tWtLJb2qy+uvu1RoaPDp4rMlL1Ld64GWWkW fwPkeRrjQQWyXh1APOIPPAlO5E0CYCIhL9JOi3ZyLkfCoBo9ufcDWvwiaLniaqKoiT5+ 1gUdQ486CJmAi2YjJWW4t07b7E9++qkWbo7V9iVhwO0zfb4yW94JFuRayT13p+cGXGKS 8YgA== X-Gm-Message-State: AOAM532oFmPCh8+Yeb+/S9xny8kRCys4MlZraZMAsr5ipDYlF9WOMKJR UuAYrCqoVa4vn0mw/hPLl/v0pbGtFfgRSlgrZJGCsg== X-Received: by 2002:a67:f889:0:b0:32c:d0ea:1817 with SMTP id h9-20020a67f889000000b0032cd0ea1817mr13511693vso.64.1652273953998; Wed, 11 May 2022 05:59:13 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 11 May 2022 05:59:13 -0700 From: Guillaume Ranquet User-Agent: meli 0.7.2 References: <20220327223927.20848-1-granquet@baylibre.com> <20220327223927.20848-19-granquet@baylibre.com> <20220429083933.q3w75q3zuyyuvo4w@houat> In-Reply-To: <20220429083933.q3w75q3zuyyuvo4w@houat> MIME-Version: 1.0 Date: Wed, 11 May 2022 05:59:13 -0700 Message-ID: Subject: Re: [PATCH v9 18/22] drm/mediatek: Add mt8195 Embedded DisplayPort driver To: Maxime Ripard Cc: airlied@linux.ie, angelogioacchino.delregno@collabora.com, chunfeng.yun@mediatek.com, chunkuang.hu@kernel.org, ck.hu@mediatek.com, daniel@ffwll.ch, deller@gmx.de, jitao.shi@mediatek.com, kishon@ti.com, krzk+dt@kernel.org, maarten.lankhorst@linux.intel.com, matthias.bgg@gmail.com, p.zabel@pengutronix.de, robh+dt@kernel.org, tzimmermann@suse.de, vkoul@kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-phy@lists.infradead.org, markyacoub@google.com, Markus Schneider-Pargmann , kernel test robot Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 29 Apr 2022 10:39, Maxime Ripard wrote: >Hi Guillaume, > Hi Maxime, Thx for your review. >On Mon, Mar 28, 2022 at 12:39:23AM +0200, Guillaume Ranquet wrote: >> From: Markus Schneider-Pargmann >> >> This patch adds a DisplayPort driver for the Mediatek mt8195 SoC. >> >> It supports the mt8195, the embedded DisplayPort units. It offers >> DisplayPort 1.4 with up to 4 lanes. >> >> The driver shares its iomap range with the mtk-dp-phy driver using >> the regmap/syscon facility. >> >> This driver is based on an initial version by >> Jason-JH.Lin . >> >> Signed-off-by: Markus Schneider-Pargmann >> Signed-off-by: Guillaume Ranquet >> Reported-by: kernel test robot > >You don't need to set Reported-by on a patch introducing a new driver. >That would be typically done for a fix. > Ok. >> --- >> drivers/gpu/drm/mediatek/Kconfig | 8 + >> drivers/gpu/drm/mediatek/Makefile | 2 + >> drivers/gpu/drm/mediatek/mtk_dp.c | 2221 ++++++++++++++++++++++++ >> drivers/gpu/drm/mediatek/mtk_dp_reg.h | 568 ++++++ >> drivers/gpu/drm/mediatek/mtk_drm_drv.c | 1 + >> drivers/gpu/drm/mediatek/mtk_drm_drv.h | 1 + >> 6 files changed, 2801 insertions(+) >> create mode 100644 drivers/gpu/drm/mediatek/mtk_dp.c >> create mode 100644 drivers/gpu/drm/mediatek/mtk_dp_reg.h >> >> diff --git a/drivers/gpu/drm/mediatek/Kconfig b/drivers/gpu/drm/mediatek/Kconfig >> index 2976d21e9a34..03ffa9b896c3 100644 >> --- a/drivers/gpu/drm/mediatek/Kconfig >> +++ b/drivers/gpu/drm/mediatek/Kconfig >> @@ -28,3 +28,11 @@ config DRM_MEDIATEK_HDMI >> select PHY_MTK_HDMI >> help >> DRM/KMS HDMI driver for Mediatek SoCs >> + >> +config MTK_DPTX_SUPPORT >> + tristate "DRM DPTX Support for Mediatek SoCs" >> + depends on DRM_MEDIATEK >> + select PHY_MTK_DP >> + select DRM_DP_HELPER >> + help >> + DRM/KMS Display Port driver for Mediatek SoCs. >> diff --git a/drivers/gpu/drm/mediatek/Makefile b/drivers/gpu/drm/mediatek/Makefile >> index 29098d7c8307..d86a6406055e 100644 >> --- a/drivers/gpu/drm/mediatek/Makefile >> +++ b/drivers/gpu/drm/mediatek/Makefile >> @@ -21,3 +21,5 @@ mediatek-drm-hdmi-objs := mtk_cec.o \ >> mtk_hdmi_ddc.o >> >> obj-$(CONFIG_DRM_MEDIATEK_HDMI) += mediatek-drm-hdmi.o >> + >> +obj-$(CONFIG_MTK_DPTX_SUPPORT) += mtk_dp.o >> diff --git a/drivers/gpu/drm/mediatek/mtk_dp.c b/drivers/gpu/drm/mediatek/mtk_dp.c >> new file mode 100644 >> index 000000000000..7cd8459cf719 >> --- /dev/null >> +++ b/drivers/gpu/drm/mediatek/mtk_dp.c >> @@ -0,0 +1,2221 @@ >> +// SPDX-License-Identifier: GPL-2.0 >> +/* >> + * Copyright (c) 2019 MediaTek Inc. >> + * Copyright (c) 2021 BayLibre > >2022? right. > >> + */ >> + >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include