Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220510114852.1719018-1-zheyuma97@gmail.com>
In-Reply-To: <20220510114852.1719018-1-zheyuma97@gmail.com>
From:   Ricardo Ribalda Delgado <ribalda@kernel.org>
Date:   Wed, 11 May 2022 14:18:57 +0200
Message-ID: <CAPybu_2NCEmjVi2FZC+dPePkfZJQG9QT5qc=cRdHY4tHPEkVDg@mail.gmail.com>
Subject: Re: [PATCH] media: imx214: Fix the error handling in imx214_probe()
To:     Zheyu Ma <zheyuma97@gmail.com>
Cc:     Mauro Carvalho Chehab <mchehab@kernel.org>,
        linux-media <linux-media@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Zheyu

Do you have seen this issue in a real hardware?  The device enters
idle state unconditionally after power_on during probe.

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/media/i2c/imx214.c#n1008


On Tue, May 10, 2022 at 1:49 PM Zheyu Ma <zheyuma97@gmail.com> wrote:
>
> The driver should disable regulators when fails to probe.
>
> Signed-off-by: Zheyu Ma <zheyuma97@gmail.com>
> ---
>  drivers/media/i2c/imx214.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/i2c/imx214.c b/drivers/media/i2c/imx214.c
> index 83c1737abeec..61eeaefd4298 100644
> --- a/drivers/media/i2c/imx214.c
> +++ b/drivers/media/i2c/imx214.c
> @@ -1076,6 +1076,7 @@ static int imx214_probe(struct i2c_client *client)
>         mutex_destroy(&imx214->mutex);
>         v4l2_ctrl_handler_free(&imx214->ctrls);
>         pm_runtime_disable(imx214->dev);
> +       regulator_bulk_disable(IMX214_NUM_SUPPLIES, imx214->supplies);
>
>         return ret;
>  }
> --
> 2.25.1
>