Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220511072747.3960-1-jiangshanlai@gmail.com> <20220511072747.3960-3-jiangshanlai@gmail.com>
 <87h75wgycl.ffs@tglx>
In-Reply-To: <87h75wgycl.ffs@tglx>
From:   Lai Jiangshan <jiangshanlai@gmail.com>
Date:   Wed, 11 May 2022 20:40:38 +0800
Message-ID: <CAJhGHyCXCUDe_grNa9XdLXuCJYcX35G0m3KvjWnSvgYUApLbcA@mail.gmail.com>
Subject: Re: [PATCH 2/7] x86/entry: Move PTI_USER_* to arch/x86/include/asm/processor-flags.h
To:     Thomas Gleixner <tglx@linutronix.de>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        Borislav Petkov <bp@alien8.de>,
        Peter Zijlstra <peterz@infradead.org>,
        Josh Poimboeuf <jpoimboe@redhat.com>,
        Andy Lutomirski <luto@kernel.org>, X86 ML <x86@kernel.org>,
        Lai Jiangshan <jiangshan.ljs@antgroup.com>,
        Ingo Molnar <mingo@redhat.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
        Pasha Tatashin <pasha.tatashin@soleen.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, May 11, 2022 at 6:25 PM Thomas Gleixner <tglx@linutronix.de> wrote:
>
> On Wed, May 11 2022 at 15:27, Lai Jiangshan wrote:
> > From: Lai Jiangshan <jiangshan.ljs@antgroup.com>
> >
> > These constants will be also used in C file.
> >
> > Move them to arch/x86/include/asm/processor-flags.h which already has
> > a kin X86_CR3_PTI_PCID_USER_BIT defined in it.
> >
> > Remove PTI_PGTABLE_SWITCH_BIT and replace it with PTI_USER_PGTABLE_BIT
> > since they are the same in meaning and value.
>
> Just from looking at the patch it's obvious that it breaks the 32bit
> CONFIG_PAGETABLE_ISOLATION=y build. Sigh.

Ahhh.
Thank you!

I'm sorry and I will move the "#ifdef CONFIG_X86_64" down a
little bit in arch/x86/include/asm/processor-flags.h.

Thanks
Lai