Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp143363iob; Wed, 11 May 2022 11:10:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwxEI5XDWsEEcEgCZFYsdwYXrnXFuYBxI0ByAfoQOUQBezbGC/9Wk3Ty5q9pa+xPpCX23nc X-Received: by 2002:a05:6402:158a:b0:426:9efd:57a with SMTP id c10-20020a056402158a00b004269efd057amr29582671edv.85.1652292646329; Wed, 11 May 2022 11:10:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652292646; cv=none; d=google.com; s=arc-20160816; b=aVrpwvMglGuYhgiiMh7Se2yy1gjPvjRZZH4X9kyB4ImvjEk1lTuEWON040eOmJh5eQ MwjYxTD8DqcxP0oSBN1J3CVEzvI3ITrchBukrTbOg9oYy0CjmeGgaoBER9uJCPSea7Ob Nxg/gko9cYM34U4Es8jpvczx3CsQAKbJj7P9f21THDPKkG8GN76yl/vbGPsLS67hCZs1 cRBSF7dHo1ORyBd98nSOhZsYXZoQqGmonGvmUkIDGWi5SQ1u3ZD0r7KaIpD7QqKp6tWh k7my2TIKFe2VrXGhfzB2bDRMqH+SrAMfvSuDLokB+b1riRA3fnikzs+Yv4nfX6UFk5gY K/nw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=yqr8XcNNq/upqGPH8M419sYbkidivjRbBHWOxY/ntHQ=; b=UGX6bml+FA0hbkrBUybfQ+W2AEf6zOk4uyBQWVBmnsQapJNfyUI5+oH2FaYrzh1lPg HJaNAfosbumH+RFatxMcYCPLBiff0H1vDyCP30ZZsSGQnyzceOdJqs8KsMB4PBlVMppR C5l3OFML6feTwj/D3dVn6kVJVZMLD3ebrrDkLde2T0x39pxd/cHxbpqZaQA2ddQdZdeh 778GGMg3FAppMdusRC2irbTN/xXTVUOBfCu9ogjj79ewkQY9s8UfSwDjYJYcgMhJw7Xn mWx4trK2Nn7/N1Ybz7PN+v7aEIK9mfZRSKjHDywLZLnmcEcAVwatHlBHPUqnlU8Hrq4p hTUw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=8bytes.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id jg16-20020a170907971000b006f3786d89f6si3315916ejc.53.2022.05.11.11.10.15; Wed, 11 May 2022 11:10:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=8bytes.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240072AbiEKMYi (ORCPT + 99 others); Wed, 11 May 2022 08:24:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54042 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238572AbiEKMYc (ORCPT ); Wed, 11 May 2022 08:24:32 -0400 Received: from theia.8bytes.org (8bytes.org [81.169.241.247]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 750E61C345C for ; Wed, 11 May 2022 05:24:30 -0700 (PDT) Received: by theia.8bytes.org (Postfix, from userid 1000) id D6B675A4; Wed, 11 May 2022 14:24:28 +0200 (CEST) Date: Wed, 11 May 2022 14:24:23 +0200 From: =?iso-8859-1?Q?J=F6rg_R=F6del?= To: Linus Torvalds Cc: "Michael S. Tsirkin" , Konstantin Ryabitsev , KVM list , virtualization@lists.linux-foundation.org, Netdev , Linux Kernel Mailing List , mie@igel.co.jp Subject: Re: [GIT PULL] virtio: last minute fixup Message-ID: References: <20220510082351-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 10, 2022 at 11:23:11AM -0700, Linus Torvalds wrote: > And - once again - I want to complain about the "Link:" in that commit. I have to say that for me (probably for others as well) those Link tags pointing to the patch submission have quite some value: 1) First of all it is an easy proof that the patch was actually submitted somewhere for public review before it went into a maintainers tree. 2) The patch submission is often the entry point to the discussion which lead to this patch. From that email I can see what was discussed and often there is even a link to previous versions and the discussions that happened there. It helps to better understand how a patch came to be the way it is. I know this should ideally be part of the commit message, but in reality this is what I also use the link tag for. 3) When backporting a patch to a downstream kernel it often helps a lot to see the whole patch-set the change was submitted in, especially when it comes to fixes. With the Link: tag the whole submission thread is easy to find. I can stop adding them to patches if you want, but as I said, I think there is some value in them which make me want to keep them. Regards, Joerg