Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f8400e5da994b81dda0b90c840afb92489ca0061.camel@perches.com>
Subject: Re: [PATCH v2 5/5] clang-format: Fix space after for_each macros
From:   Joe Perches <joe@perches.com>
To:     =?ISO-8859-1?Q?Micka=EBl_Sala=FCn?= <mic@digikod.net>,
        Miguel Ojeda <ojeda@kernel.org>
Cc:     Andy Whitcroft <apw@canonical.com>,
        Brian Norris <briannorris@chromium.org>,
        Dwaipayan Ray <dwaipayanray1@gmail.com>,
        "Jason A . Donenfeld" <Jason@zx2c4.com>,
        Kees Cook <keescook@chromium.org>,
        Konstantin Meskhidze <konstantin.meskhidze@huawei.com>,
        Lukas Bulwahn <lukas.bulwahn@gmail.com>,
        Nathan Chancellor <nathan@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Paul Moore <paul@paul-moore.com>, Tom Rix <trix@redhat.com>,
        linux-kernel@vger.kernel.org, llvm@lists.linux.dev
Date:   Wed, 11 May 2022 10:38:50 -0700
In-Reply-To: <d519b20b-694a-d8a7-66ed-1c5961590d4b@digikod.net>
References: <20220506160106.522341-1-mic@digikod.net>
         <20220506160106.522341-6-mic@digikod.net>
         <e40f779c7de2f9abe5fdd76d0a77477e4bf1fe32.camel@perches.com>
         <d519b20b-694a-d8a7-66ed-1c5961590d4b@digikod.net>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.40.4-1ubuntu2 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Wed, 2022-05-11 at 19:34 +0200, Micka?l Sala?n wrote:
> On 11/05/2022 17:40, Joe Perches wrote:
> > On Fri, 2022-05-06 at 18:01 +0200, Micka?l Sala?n wrote:
> > > Set SpaceBeforeParens to ControlStatementsExceptForEachMacros to not add
> > > space between a for_each macro and the following parenthesis.  This
> > > option is available since clang-format-11 [1] and is in line with the
> > > checkpatch.pl rules [2].
> > 
> > If this is applied, could the .clang_format ForEachMacros:
> > block be removed?
> 
> The ForEachMacros block is still required to not put the " {" on the 
> next line.

Pity these aren't linked as many for_each macro definitions and uses
exist outside of the grep search paths.