Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7219b406-7677-748b-984c-66009d9f6327@ti.com>
Date:   Wed, 11 May 2022 16:27:25 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.0
Subject: Re: [PATCH v6 1/4] dt-bindings: thermal: k3-j72xx: Add VTM bindings
 documentation
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        <robh+dt@kernel.org>, <daniel.lezcano@linaro.org>,
        <rui.zhang@intel.com>, <amitk@kernel.org>, <kristo@kernel.org>,
        <vigneshr@ti.com>
CC:     <linux-pm@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <20220427064635.24898-1-j-keerthy@ti.com>
 <20220427064635.24898-2-j-keerthy@ti.com>
 <5859fed0-82b7-95eb-5719-9b0016916c50@ti.com>
 <eb0745a6-ecf2-4b70-368b-9ad8a322f208@linaro.org>
 <117f175f-62d1-17b5-742b-bcb250b7866f@ti.com>
 <091e6619-3341-4a98-90f6-48a6281f6275@linaro.org>
From:   "J, KEERTHY" <j-keerthy@ti.com>
In-Reply-To: <091e6619-3341-4a98-90f6-48a6281f6275@linaro.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 5/11/2022 1:45 PM, Krzysztof Kozlowski wrote:
> On 11/05/2022 09:53, J, KEERTHY wrote:
>>>>
>>>> Any comments on this version?
>>>
>>> You got Rob's review, so you don't need also mine.
>>>
>>> If you want, then in general look okay, except the description for "reg"
>>> you could split per items:
>>>
>>> reg:
>>>     items:
>>>       - description: VTM cfg1 register space
>>>       - description: VTM cfg2 register space
>>>       - description: efuse register space
>>>
>>> It's more obvious what items you expect.
>>
>> Hi Krzysztof,
>>
>> DTEX
>> Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.example.dts
>> Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.yaml: found
>> duplicate key "description" with value "VTM cfg2 register space"
>> (original value: "VTM cfg1 register space")
>> Documentation/devicetree/bindings/Makefile:26: recipe for target
>> 'Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.example.dts'
>> failed
>> make[1]: ***
>> [Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.example.dts] Er
>>
>> I believe multiple instances of description is failing. So can i keep
>> the description as is?
> 
> It looks weird. Can you share your code (pastebin/github/paste here)?

My bad. I had missed the '-' before description & hence it was erring 
out. I fixed. I will post v7 of this patch alone.

Thanks,
Keerthy

> 
> 
> Best regards,
> Krzysztof