Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220511115911.54960-1-max.oss.09@gmail.com> <20220511115911.54960-4-max.oss.09@gmail.com>
 <CAOMZO5AboNfb_E-4QVurZ6UTYephsOakW0QrAU8xRAMe8_zRow@mail.gmail.com> <CAEHkU3U=58qittoNazqXrkYKO9gs7VU3VW_67823fs+dt6r6eA@mail.gmail.com>
In-Reply-To: <CAEHkU3U=58qittoNazqXrkYKO9gs7VU3VW_67823fs+dt6r6eA@mail.gmail.com>
From:   Fabio Estevam <festevam@gmail.com>
Date:   Wed, 11 May 2022 10:35:20 -0300
Message-ID: <CAOMZO5BkcpNN+UVLTq+1-y7KdqDC9GAX5_FFqb930OaCewT_jg@mail.gmail.com>
Subject: Re: [PATCH v2 3/4] ARM: dts: imx6qdl-colibri: backlight pwm: Simplify
 inverted backlight
To:     Max Krummenacher <max.oss.09@gmail.com>
Cc:     Max Krummenacher <max.krummenacher@toradex.com>,
        Krzysztof Kozlowski <krzk+dt@kernel.org>,
        NXP Linux Team <linux-imx@nxp.com>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Rob Herring <robh+dt@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Shawn Guo <shawnguo@kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@lists.infradead.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, May 11, 2022 at 10:32 AM Max Krummenacher <max.oss.09@gmail.com> wrote:

> I disagree. Just setting the invert without at the same changing the
> brightness-levels does
> change the user experience way more than when one adapts the available
> duty cycles
> at the same time.
>
> With the change to use the PWM with inverted polarity the PWM signals
> is inverted to
> how it was before this patch. Keeping the brightness-levels will then
> have a big brightness
> jump from 0 to 127 duty cycle, the other 6 steps will then be barely noticable.
>
> I.e. before the change the brightness for level [0..7] was
> ['off', 128/255, 64/255, 32/255, 16/255, 8/255, 4/255, 'off'],
> if one only inverts the polarity it will be
> ['off', 128/255, 191/255, 223/255, 239/255, 247/255, 255/255].
> With the proposed patch it will be
> ['off', 4/255, 8/255, 16/255, 32/255, 64/255, 128/255, 255/255].

Ok, please add an explanation to the commit log as to why you are
changing the brightness levels
like you did here. Thanks