Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 11 May 2022 14:57:28 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Schspa Shi <schspa@gmail.com>
Cc:     rafael@kernel.org, ming.lei@canonical.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] driver: base: fix UAF when driver_attach failed
Message-ID: <YnuyuFRaDTY2n4VB@kroah.com>
References: <20220511124336.66705-1-schspa@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220511124336.66705-1-schspa@gmail.com>
Precedence: bulk

On Wed, May 11, 2022 at 08:43:36PM +0800, Schspa Shi wrote:
> When driver_attach(drv); failed, the driver_private will be freed.
> But it has been added to the bus, which caused a UAF.
> 
> To fix it, we need to delete it from the bus when failed.
> 
> Fixes: 190888ac01d0 ("driver core: fix possible missing of device probe")
> 
> Signed-off-by: Schspa Shi <schspa@gmail.com>

No blank line needed after fixes:

> ---
>  drivers/base/bus.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/base/bus.c b/drivers/base/bus.c
> index 97936ec49bde..7ca47e5b3c1f 100644
> --- a/drivers/base/bus.c
> +++ b/drivers/base/bus.c
> @@ -617,7 +617,7 @@ int bus_add_driver(struct device_driver *drv)
>  	if (drv->bus->p->drivers_autoprobe) {
>  		error = driver_attach(drv);
>  		if (error)
> -			goto out_unregister;
> +			goto out_del_list;
>  	}
>  	module_add_driver(drv->owner, drv);
>  
> @@ -644,6 +644,8 @@ int bus_add_driver(struct device_driver *drv)
>  
>  	return 0;
>  
> +out_del_list:
> +	klist_del(&priv->knode_bus);

Odd, how did you find this?  Has this ever been triggered by any
real-world situations?

thanks,

greg k-h