Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0db84168-5448-7a55-a074-ccd49ef063da@oracle.com>
Date:   Wed, 11 May 2022 19:58:10 +1000
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.9.0
Subject: Re: [PATCH 5/5] kernfs: Replace global kernfs_open_file_mutex with
 hashed mutexes.
Content-Language: en-US
To:     Tejun Heo <tj@kernel.org>
Cc:     viro@zeniv.linux.org.uk, gregkh@linuxfoundation.org,
        linux-kernel@vger.kernel.org
References: <20220428055431.3826852-1-imran.f.khan@oracle.com>
 <20220428055431.3826852-6-imran.f.khan@oracle.com>
 <YnQuH5ijv6bWUKPM@slm.duckdns.org>
From:   Imran Khan <imran.f.khan@oracle.com>
In-Reply-To: <YnQuH5ijv6bWUKPM@slm.duckdns.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c3BnVE02K1pmblFOYW9ucGRwSTU5S3lGaGtFTlFUTFRBZ2U5ams3czkwMWUy?=
 =?utf-8?B?cDZCWWJWb1R2dnVzZmp6MlVnUGJiVjAyMjRoaTVuVVB3SnVpcXRaYWc0Uy84?=
 =?utf-8?B?azQ3b0t1dVBOWGRadkdvWlU1bVhPYkxKd3NFTVZpTnFma1dVQjI4bWg5VGdM?=
 =?utf-8?B?U2VVMGZKOVl5T1k4VFhCY0R2L2hqbkJXQWg0U3MzZnRqVURyc0wvN1FUMmNX?=
 =?utf-8?B?enN3UmNUNnlvRWQ3WXZETjJyUDk2VStjSjJORmc2N2hqTUp4ajNoaXJBRTZI?=
 =?utf-8?B?VzErNGpadUJ0MHB2ancwc2J1NXVJSXhITXd1MjFQYTFYWWlXcXRick1YaEdI?=
 =?utf-8?B?MVhlME9GTFdLMTAySDk3NUcycTBFTVR4ZklvNzBiNENIRkRLTkJyMWhaaFRv?=
 =?utf-8?B?ZmwwQ1NIb01kdkF1MTVkOWhIaEJnZ1RaUTdaTGhCTW5mcUNjd3FENE8xUmJj?=
 =?utf-8?B?djR2ZzBlWVVZM3hJdnJVNW1aUnEwaTlpRDJlV1RORnZpNlczQVA5c0pKeFVi?=
 =?utf-8?B?VDllcU5qYUV3aGVQREVyNzlXZnpSL2toelk5aGpnd291QTJTcHd4ekNZMlBY?=
 =?utf-8?B?MS9ZbEJScE8yWm1aRklqcmNRakhyQysxNU9xd0oxOEhMQk9LUHByWXJManBu?=
 =?utf-8?B?dEdOY1kwKy9MWXZIaDdST1lSckxiR0U0MW0zNWhxZXZNSkdkUHlHaThwMjRq?=
 =?utf-8?B?dUtRK3ArZ2NJMWVCek9GQm42RnFERVNmVzlldGRZemo5Y1oxNEMxeXJZdkIr?=
 =?utf-8?B?WFdOMExJeVhwczMrKzNuV3RERHpmTzUvM0J4VFBOUG1xU080bzdMZUVXeEN0?=
 =?utf-8?B?RUZaUTZjNkEyM0IvcEh5K2I2WmlqZUlCVWY3WFBPTGZ4R2ZjTmJ1K004TThJ?=
 =?utf-8?B?TjdJZmRFTWNrZFFUL0VTMzhiRjZjR1NMRHl3RTNwclIzY2txTXFoSW9zV3N3?=
 =?utf-8?B?NTMyblNyakpnMit5ZWdjazRxemF1eHRtaDN3b0dnTW9NUlIzYS9UTEQxWkhU?=
 =?utf-8?B?SXFTdHpxSGlFWnJRTjZLdWtqaUgwWXlWd1pFRDFIZTlYRnUwMlBueEZxaStu?=
 =?utf-8?B?dlNIOENneFp5NWwydzBjU1VmOVo0WEJGVEVIYzZDRW9KWHYvV0tFQVBrVldG?=
 =?utf-8?B?Qk5HWlFDdmovcHNlT3NXTS8wT0tXbjhFY3pnS3l6TFBuRFluTmY2RU41UUk0?=
 =?utf-8?B?cGUzdksweHBDVVZHZ1hBOHB5NnJ3VWlVYm5aYW0rbHJmR1NDMVBlOVg0cjl1?=
 =?utf-8?B?bExXdlVUU0oveU5HcU1MVmVFdjF4QjVnTC9HNWZwcVQvNmFtWFNkOUQ0cWhI?=
 =?utf-8?B?M1FycUF0eG83cWNYUHlmbFZMVUdTdk0zcU9WVGVvYWdpU0VkeWhsWTI0aG9N?=
 =?utf-8?B?cnhQZWsxOGxWMWlpSmsyZWhjTWZJZDZLc1I1amlCRHRwa2F3bUFRQ1hLZE41?=
 =?utf-8?B?T2F6VzJTSEFrY0Y0ejh2L2RIT3BlR2ZqbXI2WUdEL3pBNU5taGl6aXlSdWxK?=
 =?utf-8?B?aUxsWTNnZXVrc1FBNVZuSDlWVTM5Zm1Pd0dRNE9MUGl0ZVBseFl2TzE4Y0hM?=
 =?utf-8?B?OUlSWWJDaUxXcG1yVEhBaTdseXNFOWRkMnVnaEYwdHhuWlgwRlhEWHlsNXNm?=
 =?utf-8?B?Q1NBU3NEMU44dTVhanJzdWF1UW9WR2xUWENjUFB5dnhCeEFVMy8raStIR0k3?=
 =?utf-8?B?eWo0ZzB0c2FPdThaQWJIbEZuSUZzUEYyUHcrVjBJZGpaUmt0K2VZb3JPOHVW?=
 =?utf-8?B?WitDN2EyeVFzbzVmbldwdjVURnB3YUdBUUs2c2ZXT3VMaHVMTjhKWXNUcnJI?=
 =?utf-8?B?ZkdLMkNOenpGbUQrMDVnUmFHNFIyTFRDVDFlbURXY3RzQ3Q1TzNXT21zci9z?=
 =?utf-8?B?UVlqZ2hxb3ROblZ3bjNVN0JRbE52U0dta0w4N3ExKzRTOXJackF5ODNXYjdh?=
 =?utf-8?B?THR5a0Jqc3kzOXZCWTRLbnJkanZ2cUgrUXI3cklYZG15Nmk2WWJCeHl2aW1l?=
 =?utf-8?B?M3ZOQUxDZGhBejNzbDJsRHppcHU0eXJlTUNtQmg2U3Z1WVIxbVpjYW0ya213?=
 =?utf-8?B?Q3pzSkhMV3o3SFBKanc2MHdVVVlqQU9hZHI2ejJ2eHVuNHFQSXc4ekRTejRU?=
 =?utf-8?B?bjlwZFlhM21ZUGp2QlV5NFNkRVVKSHpaZEl5YTRhbkpxek1FditvZU5kZzYz?=
 =?utf-8?B?QnRuczkvQWpvYXRlU1hUSW5vS3FKZEE2bHI4dHRJRHFkNzM3aFFqSnAwT1Nm?=
 =?utf-8?B?cUhSdFZEbTZUcVdkekIwUDlMZlNwQ1BPS3hsd2M5TU0xVFBYY0JXRTFWQ2R0?=
 =?utf-8?B?VmVoMXJGL2kzb01BY09ONDFDc1JLOUFaZXJvTHdYVXFVc2ZsdFpKN3VLREM0?=
 =?utf-8?Q?H2+7pICNBbirTGPI=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2a7e2eeb-5e02-4d1d-eed5-08da3334c5a0
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4468.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2022 09:58:17.6289
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jWj50LJeeOjHe7pyzhzTj/cMdY+xb38uQeVth8GRYCLcpTY3GAM7JA5fZdpyduQbSGg+dNROxFfJ4HHBGuuOXQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB2886
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858
 definitions=2022-05-11_03:2022-05-11,2022-05-11 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=957 adultscore=0
 spamscore=0 phishscore=0 suspectscore=0 mlxscore=0 bulkscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2205110044
X-Proofpoint-GUID: onAmUq_D4sGObOKTZLw7IP1Qw7rKUpHm
X-Proofpoint-ORIG-GUID: onAmUq_D4sGObOKTZLw7IP1Qw7rKUpHm
X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello Tejun,

On 6/5/22 6:05 am, Tejun Heo wrote:
> On Thu, Apr 28, 2022 at 03:54:31PM +1000, Imran Khan wrote:
>> +static void __init kernfs_mutex_init(void)
>> +{
>> +	int count;
>> +
>> +	for (count = 0; count < NR_KERNFS_LOCKS; count++)
>> +		mutex_init(&kernfs_locks->open_file_mutex[count]);
>> +}
> 
> Does this need to be a separate function?
> 

Above, I have moved mutex initialization from kernfs_lock_init to a
separate function kernfs_mutex_init. Could you please let me know if I
am missing something here ?
>> +static void __init kernfs_lock_init(void)
>> +{
>> +	kernfs_locks = kmalloc(sizeof(struct kernfs_global_locks), GFP_KERNEL);
>> +	WARN_ON(!kernfs_locks);
>> +
>> +	kernfs_mutex_init();
>> +}
>> +
>>  void __init kernfs_init(void)
>>  {
>>  	kernfs_node_cache = kmem_cache_create("kernfs_node_cache",
> 
> Other than that minor nitpick,
> 
> Acked-by: Tejun Heo <tj@kernel.org>
> 
> Thanks.
> 

Thanks,
 -- Imran