Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp492674iob; Wed, 11 May 2022 20:21:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz9xZok+l+KQrTdOvgzn0gGrkZuyMXxOlj5wGpJ39Lh7Ts/U/qpQSkXvQqR8E4Bdrk/Wt0t X-Received: by 2002:a05:6402:13c3:b0:425:d94b:4118 with SMTP id a3-20020a05640213c300b00425d94b4118mr32017080edx.75.1652325663379; Wed, 11 May 2022 20:21:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652325663; cv=none; d=google.com; s=arc-20160816; b=XxoVzBH552KJmO0jrHASPLtKH5gczQ4DuzwiCCEgqGxm/aUSQvBTyBo18Eu5iar1CP KSBKGe3tHOKN1X+vEQKOQM7TNly89YHpkWJEV4E8R2fosadK2DbglqFVIR5gsvbZMgYH /jB5hEy25b3asJIP5t493WjBeZk/xIVM1VIX9kgyyZT2rtdYIDWO59oA6DZMEsTOEG4/ eopo42w3JZVhOjysQ4MQ2iO6oO8oPcOPOv3aFkxUfAFvRzefZnymGMB04PCA+ztTuQPM IuGz1s/mxH7PghoHmEVZYgeIEYRoqtnMyN/2kWKnuo0I/qQ4Y5CajYoyaNK55Zwt6xLn U3Bg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:subject:user-agent:mime-version:date:message-id; bh=OFP36xgIebvTEIXBPFcNIgZib2kcqtBcbed+JuR+b9Q=; b=p0OK6BcE07K7lgXNabjxPYFJJe0KWMW5PZ4l4jf8AjMO0J6t74dkMOwTucqgtWl0OB n4TVDl8K5hD8wyMqxg5XbxFDIJtxypSsp3T5/ulKttfXNglqojaYdp7AvAbIj1cjPuwz 1t4xklCkePtD7P5nLvG58RetktackI6HwC4aRhsmRfWWb8ZoSbc/SE3Mwv4nfBDnqY1a 1FEe14+tZInYiKCA5jyf5UwXlj/Gc5CS/ICjEQm0jTSLnwbz+soPW21Sod4uLm8rDnkO uR/EZtjGkPauEisztFYe87bLstPursRL+KJp97Tf1xJ3D7U2GGDwFpFfyeGEyLtCSlFI Bd6w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o9-20020a170906974900b006f466911fdesi4834239ejy.285.2022.05.11.20.20.36; Wed, 11 May 2022 20:21:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234528AbiELB6n (ORCPT + 99 others); Wed, 11 May 2022 21:58:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45046 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234018AbiELB6i (ORCPT ); Wed, 11 May 2022 21:58:38 -0400 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB702393DE; Wed, 11 May 2022 18:58:36 -0700 (PDT) Received: from kwepemi500018.china.huawei.com (unknown [172.30.72.54]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4KzFJx1NKNz1JBmt; Thu, 12 May 2022 09:57:21 +0800 (CST) Received: from kwepemm600001.china.huawei.com (7.193.23.3) by kwepemi500018.china.huawei.com (7.221.188.213) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 12 May 2022 09:58:34 +0800 Received: from [10.174.176.245] (10.174.176.245) by kwepemm600001.china.huawei.com (7.193.23.3) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 12 May 2022 09:58:33 +0800 Message-ID: Date: Thu, 12 May 2022 09:58:32 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 0/3] Refix the socket leak in xs_setup_local() To: Trond Myklebust , "bfields@fieldses.org" , "anna@kernel.org" , "pabeni@redhat.com" , "davem@davemloft.net" , "chuck.lever@oracle.com" , "kuba@kernel.org" CC: "linux-nfs@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <20220511132232.4030-1-wanghai38@huawei.com> <2125358c4fbdcf2e9f84017a2f6b27830ffcb8f2.camel@hammerspace.com> From: "wanghai (M)" In-Reply-To: <2125358c4fbdcf2e9f84017a2f6b27830ffcb8f2.camel@hammerspace.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.176.245] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemm600001.china.huawei.com (7.193.23.3) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,NICE_REPLY_A, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2022/5/12 0:14, Trond Myklebust 写道: > On Wed, 2022-05-11 at 21:22 +0800, Wang Hai wrote: >> Patch1 and patch2 roll back the wrong solution to fix socket leaks. >> >> Patch3 adds safe teardown mechanism to re-fix socket leaks. >> >> Wang Hai (3): >>   Revert "SUNRPC: Ensure gss-proxy connects on setup" >>   Revert "Revert "SUNRPC: attempt AF_LOCAL connect on setup"" >>   SUNRPC: Fix local socket leak in xs_setup_local() >> >>  include/linux/sunrpc/clnt.h          |  1 - >>  net/sunrpc/auth_gss/gss_rpc_upcall.c |  2 +- >>  net/sunrpc/clnt.c                    |  3 --- >>  net/sunrpc/xprtsock.c                | 19 ++++++++++++++++++- >>  4 files changed, 19 insertions(+), 6 deletions(-) >> > Thanks, but there is already a fix for this queued up in the linux-next > branch. Thanks, sorry to bother you, I found it. I only subscribed to the linux-kernel@vger.kernel.org mailing list, not the linux-nfs@vger.kernel.org mailing list separately. So I didn't notice it was fixed. -- Wang Hai