Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 11 May 2022 15:24:21 +0200
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Oliver Hartkopp <socketcan@hartkopp.net>
Cc:     Oleksij Rempel <o.rempel@pengutronix.de>,
        Wolfgang Grandegger <wg@grandegger.com>,
        Devid Antonio Filoni <devid.filoni@egluetechnologies.com>,
        kernel@pengutronix.de, linux-can@vger.kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        David Jander <david@protonic.nl>
Subject: Re: [PATCH 1/1] can: skb: add and set local_origin flag
Message-ID: <20220511132421.7o5a3po32l3w2wcr@pengutronix.de>
References: <20220511121913.2696181-1-o.rempel@pengutronix.de>
 <b631b022-72d5-9160-fd13-f33c80dbbe59@hartkopp.net>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="regs3wlmb3rwqwth"
Content-Disposition: inline
In-Reply-To: <b631b022-72d5-9160-fd13-f33c80dbbe59@hartkopp.net>
Precedence: bulk


--regs3wlmb3rwqwth
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 11.05.2022 14:38:32, Oliver Hartkopp wrote:
> IMO this patch does not work as intended.
>=20
> You probably need to revisit every place where can_skb_reserve() is used,
> e.g. in raw_sendmsg().

And the loopback for devices that don't support IFF_ECHO:

| https://elixir.bootlin.com/linux/latest/source/net/can/af_can.c#L257

Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

--regs3wlmb3rwqwth
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEBsvAIBsPu6mG7thcrX5LkNig010FAmJ7uQIACgkQrX5LkNig
0112+Af+Pp84b/2x9pkUckJd7BiXaSSo95W2yPRSjLaA3r1A6jbGBVrogvYl49Xg
MnKDo6z/Av30GwwOaKLXnMSdtL1Q73PabyGKD+ILzKQLxpAp3kXMVcz9M2jZliMF
BqR6VjklD+9TrA6PBQ8YMqU1hROnr3Fb5shQtjhsa099Y1eG4riDSutyQ7AWUO9h
luo3MTyzvY6Lml/yxm82qzzpJLOd7tvmN1OpFS/DV1Eyu5lr9sXp3cYvlqpc6MK5
3Hc1tnbZ2Gss1drs9kKY5A6Fmx/YYklnsBzHVTAfiVBvqJ+Mgq9qw9SKIijG2nVa
zHwaaZf/y6fiuSXfiHYkmTnNq1FjWA==
=qnXD
-----END PGP SIGNATURE-----

--regs3wlmb3rwqwth--