Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
User-Agent: Cyrus-JMAP/3.7.0-alpha0-591-gfe6c3a2700-fm-20220427.001-gfe6c3a27
Mime-Version: 1.0
Message-Id: <7c87b9f7-0a26-41cf-ba34-3dbd37caa2b8@www.fastmail.com>
In-Reply-To: <87o803dijt.fsf@oldenburg.str.redhat.com>
References: <898932fe61db6a9d61bc2458fa2f6049f1ca9f5c.1652290558.git.luto@kernel.org>
 <87o803dijt.fsf@oldenburg.str.redhat.com>
Date:   Wed, 11 May 2022 12:03:14 -0700
From:   "Andy Lutomirski" <luto@kernel.org>
To:     "Florian Weimer" <fweimer@redhat.com>
Cc:     "the arch/x86 maintainers" <x86@kernel.org>,
        "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
        "Kees Cook" <keescook@chromium.org>
Subject: Re: [PATCH] x86/vsyscall: Remove CONFIG_LEGACY_VSYSCALL_EMULATE
Content-Type: text/plain
Precedence: bulk


On Wed, May 11, 2022, at 11:35 AM, Florian Weimer wrote:
> * Andy Lutomirski:
>
>> CONFIG_LEGACY_VSYSCALL_EMULATE is, as far as I know, only needed for the
>> combined use of exotic and outdated debugging mechanisms with outdated
>> binaries.  At this point, no one should be using it.  We would like to
>> implement dynamic switching of vsyscalls, but this is much more
>> complicated to support in EMULATE mode than XONLY mode.
>>
>> So let's force all the distros off of EMULATE mode.  If anyone actually
>> needs it, they can set vsyscall=emulate, and we can then get away with
>> refusing to support newer security models if that option is set.
>>
>> Cc: x86@kernel.org
>> Cc: Kees Cook <keescook@chromium.org>
>> Cc: Florian Weimer <fweimer@redhat.com>
>> Signed-off-by: Andy Lutomirski <luto@kernel.org>
>
> Sounds a good idea to me.
>
> Acked-by: Florian Weimer <fweimer@redhat.com>
>
> Regarding the mechanics, is it customary to remove the actual code (the
> EMULATE enum constant) in later commits?
>

Might be several versions later. This patch intentionally still supports booting with vsyscall=emulate.